From nobody Mon Jun 05 19:41:46 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QZkXH5n95z4b2h4 for ; Mon, 5 Jun 2023 19:42:23 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QZkXH5JZhz3w2h for ; Mon, 5 Jun 2023 19:42:23 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685994143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C13MQvjWGwqxp7Ql8JeUDEKt79SZOFz0xqCPD+VtOnA=; b=dVbepWEbN3v4hjTwcE3YGq2ou0AMie0vKUax+6irCN3Hyt7UcdXoMRT4e2WVQ+29fd2TF4 01d7nr+lhmaG0wjz24SU6C2ufkWH/ilbz65MhzIgsK7ebX5y4D688NQrOtnRf8vFn5wuR5 vosP5yQMnG1zdM6xiDl9RaIGv7mhYDbeJm5fq+Dm/Tjtzi0QtapIzZbuV05QP0Ayun6q5V tvzVZandEj44gY0zEu0sLcy6wn6S06bXIVoqoTF9pYQMcAWX/c7s7dmgxZjVEGtyQYFzzI UcUGCEQTbAnrnvUvGrfprPTLYpqHNhtfuZgahtKMJMYdutsMotX7vuAUkcoXEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685994143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C13MQvjWGwqxp7Ql8JeUDEKt79SZOFz0xqCPD+VtOnA=; b=mN4U1BWHS2f8eibBtOaA4KjDofQyuEjWA1WHNw8ZTcGiLYlwSZz4h7I3vxAY4qctFIrRi0 /W08jMInxtFm/74ZTHIjkrvor9DvW9dNpR0OodnIAvQqIrrK8lHqoLYK8PCfypDsq+OIut MxjBh0ykJqsd5F0W194a2yEv2pdImMzbe9fnB5Hb8850SkEt8phh38OEcooRCZ/1yQCqX5 xCRY17zJAM8Cnvq8cqPHS2YHsT4Wcc7JieXB+AIRJeXlO0oGlLLHhxthfIGfJhpLYvK7Kf 7bXw8tRWLsLULdfSXf7uSBeMkqGgnGTm9NtPrR1eS7A6yRJBKLzAU4+q1/XeOA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685994143; a=rsa-sha256; cv=none; b=d2WbLcsWuhh7mN9j+c9tg6QykCAt27mYeU3Fg3IdYE9+YOBdjy+/oaLkW1S2xR7J08CbK7 mcDLL1QS/b2zJFh7o4ZRiyZY2qplZnIZJHeoc0I+nwWrnlINNGfOgE4KnWlC7iX8kEGAJK UHCgeG/Na4Ur5jiTDjzil28wgWQq6VelXc1jiNAKoVzzIL0rq5lfruv5GrvPtrRn7MKt0B 48OnCKrBuHlyE7kVAp6CvKHKhdisn/kGO885lSejnBznsfqb4g+HKs1T0nZYx25NRq5yWc vnHCnN1tzLLeAv2fLHePvalIRpMmagO9n57jSgLpqAwySwP0rpYobKyTrfgD0w== Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QZkXH4BvKzQJS for ; Mon, 5 Jun 2023 19:42:23 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-514924b4f8cso7979938a12.3 for ; Mon, 05 Jun 2023 12:42:23 -0700 (PDT) X-Gm-Message-State: AC+VfDwZClS7TKXLs1q2MXkucPrrgyF3dvEDOxAnCFUbDcSh8UUj2cYs E6ak2LfM3TIOICIxd5iAPQMaYFjGeIyLGn8Q/Njs8w== X-Google-Smtp-Source: ACHHUZ61QPPaIMAlm9LtCodwR44YlVdXM6ZxlFoCKFi/J/ndvk2PHbGPvXlVvXi+lTDjsGYkIpwpCFRKN5v7YeDhSJg= X-Received: by 2002:a05:6402:1618:b0:509:f221:cee2 with SMTP id f24-20020a056402161800b00509f221cee2mr110028edv.32.1685994142527; Mon, 05 Jun 2023 12:42:22 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202306051901.355J1w9B078961@gitrepo.freebsd.org> In-Reply-To: From: Po-Chuan Hsieh Date: Tue, 6 Jun 2023 03:41:46 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 522d39ae76a1 - main - math/Imath: Fix GH_* usage To: Matthias Andree Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000f5901605fd6719ed" X-ThisMailContainsUnwantedMimeParts: N --000000000000f5901605fd6719ed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 6, 2023 at 3:07=E2=80=AFAM Matthias Andree wrote: > Am 05.06.23 um 21:01 schrieb Po-Chuan Hsieh: > > The branch main has been updated by sunpoet: > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3D522d39ae76a1d17440e529c800652= 50cedfd6224 > > > > commit 522d39ae76a1d17440e529c80065250cedfd6224 > > Author: Po-Chuan Hsieh > > AuthorDate: 2023-06-05 18:46:16 +0000 > > Commit: Po-Chuan Hsieh > > CommitDate: 2023-06-05 18:49:13 +0000 > > > > math/Imath: Fix GH_* usage > > > > Approved by: portmgr (blanket) > > --- > > math/Imath/Makefile | 3 ++- > > math/Imath/distinfo | 6 +++--- > > 2 files changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/math/Imath/Makefile b/math/Imath/Makefile > > index 9fa973911789..c2d5eea7d856 100644 > > --- a/math/Imath/Makefile > > +++ b/math/Imath/Makefile > > @@ -2,6 +2,7 @@ > > > > PORTNAME=3D Imath > > PORTVERSION=3D 3.1.9 > > +DISTVERSIONPREFIX=3D v > > PORTREVISION=3D 0 > > CATEGORIES=3D math devel graphics > > > > @@ -14,7 +15,7 @@ LICENSE=3D BSD3CLAUSE > > USES=3D cmake compiler:c++14-lang pathfix pkgconfig > > > > USE_GITHUB=3D yes > > -GH_TUPLE=3D AcademySoftwareFoundation:Imath:v${PORTVERSION} > > +GH_ACCOUNT=3D AcademySoftwareFoundation > > USE_LDCONFIG=3D yes > > > > CMAKE_ARGS+=3D -DCMAKE_DEBUG_POSTFIX=3D \ > > Hi Po-Chuan, > > Care to explain what there was to "fix"? It wasn't broken. > > Regards, > Matthias > > -- > Matthias Andree > FreeBSD ports committer > Hello Matthias, GH_TUPLE is used for multiple distributions. In this case: - We use GH_{ACCOUNT,PROJECT,TAGNAME}. - GH_PROJECT is the default. - GH_TAGNAME is slightly different from PORTVERSION, therefore we use DISTVERSIONPREFIX instead. Regards, sunpoet --000000000000f5901605fd6719ed Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Jun 6, 2023 at 3:07=E2=80=AFAM Ma= tthias Andree <mandree@freebsd.or= g> wrote:
Am 05.06.23 um 21:01 schrieb Po-Chuan Hsieh: > The branch main has been updated by sunpoet:
>
> URL: https:= //cgit.FreeBSD.org/ports/commit/?id=3D522d39ae76a1d17440e529c80065250cedfd6= 224
>
> commit 522d39ae76a1d17440e529c80065250cedfd6224
> Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > AuthorDate: 2023-06-05 18:46:16 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > CommitDate: 2023-06-05 18:49:13 +0000
>
>=C2=A0 =C2=A0 =C2=A0 math/Imath: Fix GH_* usage
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Approved by:=C2=A0 =C2=A0 portmgr (blanket)
> ---
>=C2=A0 =C2=A0math/Imath/Makefile | 3 ++-
>=C2=A0 =C2=A0math/Imath/distinfo | 6 +++---
>=C2=A0 =C2=A02 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/math/Imath/Makefile b/math/Imath/Makefile
> index 9fa973911789..c2d5eea7d856 100644
> --- a/math/Imath/Makefile
> +++ b/math/Imath/Makefile
> @@ -2,6 +2,7 @@
>=C2=A0 =C2=A0
>=C2=A0 =C2=A0PORTNAME=3D=C2=A0 =C2=A0Imath
>=C2=A0 =C2=A0PORTVERSION=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 3.1.9
> +DISTVERSIONPREFIX=3D=C2=A0 =C2=A0v
>=C2=A0 =C2=A0PORTREVISION=3D=C2=A0 =C2=A0 =C2=A0 =C2=A00
>=C2=A0 =C2=A0CATEGORIES=3D math devel graphics
>=C2=A0 =C2=A0
> @@ -14,7 +15,7 @@ LICENSE=3D=C2=A0 =C2=A0 BSD3CLAUSE
>=C2=A0 =C2=A0USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0cmake compiler:c++14-lang pathfix pkgconfig
>=C2=A0 =C2=A0
>=C2=A0 =C2=A0USE_GITHUB=3D yes
> -GH_TUPLE=3D=C2=A0 =C2=A0 AcademySoftwareFoundation:Imath:v${PORTVERSI= ON}
> +GH_ACCOUNT=3D=C2=A0 AcademySoftwareFoundation
>=C2=A0 =C2=A0USE_LDCONFIG=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0yes
>=C2=A0 =C2=A0
>=C2=A0 =C2=A0CMAKE_ARGS+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 -DCMAKE_DEBUG_PO= STFIX=3D \

Hi Po-Chuan,

Care to explain what there was to "fix"? It wasn't broken.
Regards,
Matthias

--
Matthias Andree
FreeBSD ports committer=C2=A0

Hello Mat= thias,

GH_TUPLE is used for multiple distributions= .
In this case:
- We use GH_{ACCOUNT,PROJECT,TAGNAM= E}.
- GH_PROJECT is the default.
- GH_TAGNAME is slight= ly different from PORTVERSION, therefore we use=C2=A0DISTVERSIONPREFIX inst= ead.

Regards,
sunpoet
--000000000000f5901605fd6719ed--