From nobody Fri Jun 02 07:11:49 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QXZ1l0xVlz4Yj9h; Fri, 2 Jun 2023 07:11:55 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QXZ1l0WzGz4KTn; Fri, 2 Jun 2023 07:11:55 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685689915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8cj+7cp5Kg+DEqVsrIYCbk5yZ3KTZJaAvVsZ39KQhFg=; b=Id8l8uARNnBh58qxkvmbxJLLuqc6Zc90vyCM4nSniugSmLdtHzSyYBPdTAW5PSG3gMurXU FfR8OnFMzZ7dB5sh2sZzWn4KUQh/ZCK0X/0oi1bgXEOrTBPBLEjYG5fhcuBCcDTMQ+NAM0 5hZbL826mUgos7X3kvEksyp6r0jFUlcigoALHbpTtaEI/diWZREgVKsA/4qSiw4ZWZhsta xCSnzgPnoDjfysw+st/Q/rj8Np+obpCq+AK+zC07fCTLkltUS5vna+whrUj4IfcSU8wAp6 /N7rftruNdtgaU3vU2UsiMjgrJcWlbbRsF3t5Cin7BvaYrwF/4p6JDTnCrVeiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685689915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8cj+7cp5Kg+DEqVsrIYCbk5yZ3KTZJaAvVsZ39KQhFg=; b=Hha1o+IuTl10AsNH1cVvCbMKHWG4wpdQUDEGn6ABDAJ99z9xK42nEUeNp5IL4REswKpnaq ZGY0DSDWER4Lge68eMJYxT4Ol2hzBQKHoDsro290R1QNPz/Q3p588quOaeT0eROATeAkkH s0FtfvdQQnnyzFGxNTQJNgmV9qYS3AfgfEvsNlRGmS44kYahRmA+yh2rsd9ZS8Ey0BH+yz 6+S7FG1d+9VJuUgAtlduXF2RHeaWfmWfcL39mSxd9aLoEPLFtsVD6Ax2V0xHTvpkUG8c4j CxSrL+CiX3qbCO8XA5mMt53ABtDWgcJrtg1rgdrLQOwUXFO+zdtRpXpgHueDLw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685689915; a=rsa-sha256; cv=none; b=vYNH7prpg0nkJU9mlM73KZe5mjKhynUSZlHQJwraPpNDvFcOu9tDxYNxxPj0v8KDWjasCE YflqQC70hQJMkQ1TZLfHiwJZzDgGSrAR3/COkVhdcSX+qbwldFJnvvWQhGsc24u1tYZWJE bjLgDSgavcPMbd5flkbLA8Jr2EvWjqvBuUzKpup34MXTFb9mJubr+ratv1tXn+C/Jhspcy Yl/WuCx3l6tINAqiHZz/4tEahlu8+fPNwnOmxSL6tr4n4Gy3HKoYqpheiEdv7OeFmqT6pi jNLs6+zhzEG6W6TOEzu2zNs8tZ1HzkNFJQpgMu3LDoc+at6v6v/QbGo8h40jrQ== Received: from mail.j.mat.cc (owncloud.cube.mat.cc [IPv6:2a01:678:4:1::228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.j.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QXZ1k5yRPz10N5; Fri, 2 Jun 2023 07:11:54 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:678:ab:50:9f67:e0ec:2b1f:9484]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 03BA1942D80; Fri, 2 Jun 2023 07:11:50 +0000 (UTC) Date: Fri, 2 Jun 2023 09:11:49 +0200 From: Mathieu Arnold To: Yuri Victorovich Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 67ce8cec004c - main - Mk/Scripts: Fix the 'stripped' check from 'make check-plist' to report all unstripped files Message-ID: References: <202306020645.3526jV0Y019662@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="veklw5qtdr6y6pe2" Content-Disposition: inline In-Reply-To: <202306020645.3526jV0Y019662@gitrepo.freebsd.org> X-ThisMailContainsUnwantedMimeParts: N --veklw5qtdr6y6pe2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 02, 2023 at 06:45:31AM +0000, Yuri Victorovich wrote: > The branch main has been updated by yuri: >=20 > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D67ce8cec004c85caeee5a6e9= 65bd10f872e1b895 >=20 > commit 67ce8cec004c85caeee5a6e965bd10f872e1b895 > Author: Yuri Victorovich > AuthorDate: 2023-06-02 06:40:46 +0000 > Commit: Yuri Victorovich > CommitDate: 2023-06-02 06:45:29 +0000 >=20 > Mk/Scripts: Fix the 'stripped' check from 'make check-plist' to repor= t all unstripped files > =20 > Prior to this patch, the 'stripped' check always skipped the first > unstripped file. > =20 > It uses the "find [...] -exec sh -c 'readelf -S -- /dev/null $0 "$@" = || :' -- {} +" > command. When arguments are passed to shell like this: > "sh -c 'script' arg1 arg2 arg3" - $@ within the script is assigned > to 'arg2 arg3', and $0 is assigned to arg1. This is a quirk in > how shells handle arguments in case when the script is passed > using -c. > =20 > This patch adds $0 to account for the first passed file. So, you are right, when you run `sh -c 'script' arg1 arg2 arg3`, arg1 is in $0, and arg2 and arg3 are in $@. Now, here, we are running `sh -c 'script' -- arg1 arg2 arg3`, so, $0 contains `--`, and arg1-3 are in $@. > - -exec sh -c 'readelf -S -- /dev/null "$@" || :' -- {} + 2>/dev/null= | awk ' > + -exec sh -c 'readelf -S -- /dev/null $0 "$@" || :' -- {} + 2>/dev/n= ull | awk ' If the patch was correct, you would need to quote "$0". But as I pointed out, it is not correct, so please revert. --=20 Mathieu Arnold --veklw5qtdr6y6pe2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmR5ljVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb5jpQv9FdloavQ21l15UMID5Xd0ixtxRzyail1KJCJgACFYicf6oNtKGDxrB8Rz rQsxQx8DRZbpZdliQSh7mt1OSq4O0pIsi4qvmD5iY0+QS7s3j/G9UZkAM7snAcwH oFQGUD1PIgdDEAMQeqz3B1Ui2NGxtWyJWR+0rRyGbdPpufJ0ccf196BE5mxXJaEB hWNVEq/NOhmYpoSYdt5hkeNSyTO4o0/mRE1xZd0v8WPXG7E4Das+pwiY8UJ6n9Eo afgdhU3LMzkF+OA4PM+2Wn/lop4GHKL5F+jkU1QVo24152gmPUT4N7yGEJOXUiCf Fk8FrqZjRgz4Y+obYd+k0R5YI1ebmsVyZlXOPSMyvBcn2SSU5Cme45aZEDyDPscZ hgXDmrlM0gm+uL2pzoWmPaBWUzMfr251CHl1WppBwowKsheBoletJpDyh6kI9dna yUvOhg94hgqdBcIVLW2jpHEdu6+FKzA94u8ZVLu2YlzYvRkkaYONNC/6H9NbF+bz SBA/aJ4x =dWCe -----END PGP SIGNATURE----- --veklw5qtdr6y6pe2--