From nobody Mon Jul 31 18:15:59 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RF62w5vkQz4pN9G; Mon, 31 Jul 2023 18:19:24 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RF5yt0VW6z3rnk; Mon, 31 Jul 2023 18:16:05 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Authentication-Results: mx1.freebsd.org; none Received: by mail.gandi.net (Postfix) with ESMTPA id 8C1E7E0004; Mon, 31 Jul 2023 18:15:59 +0000 (UTC) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Date: Mon, 31 Jul 2023 20:15:59 +0200 From: Daniel Engberg To: "Jason E. Hale" Cc: Vladimir Druzenko , Charlie Li , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 7ebddd96d372 - main - multimedia/mlt7*: Update to 7.18.0 In-Reply-To: References: <202307302015.36UKFpFO036109@gitrepo.freebsd.org> <39e34dfa-db88-0b05-6ae1-02137701dd9d@freebsd.org> <21e21bfd-e0e2-f3d8-2f7c-34333f2c94dd@freebsd.org> <5afa5396-12f2-baa7-573a-6608225c25b2@freebsd.org> <0a630993-2521-e330-02dd-606ac146b91a@freebsd.org> Message-ID: X-Sender: diizzy@FreeBSD.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Sasl: daniel.engberg@pyret.net X-Rspamd-Queue-Id: 4RF5yt0VW6z3rnk X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29169, ipnet:2001:4b98::/32, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On 2023-07-31 17:37, Jason E. Hale wrote: > On Sun, Jul 30, 2023 at 9:15 PM Vladimir Druzenko > wrote: >> >> 31.07.2023 03:02, Daniel Engberg пишет: >> > On 2023-07-31 01:45, Charlie Li wrote: >> >> Vladimir Druzenko wrote: >> >>> It's very big dependency. I can create patch for multimedia/mlt7 >> >>> with choice which libebur128 to use: 1) huge external on rust or 2) >> >>> small internal on C. >> >>> >> >> There is no rust code anywhere in audio/libebur128 or its >> >> dependencies. So don't even think about it any further. >> >> >> >> Furthermore, MLT and its consumers are not designed or intended to be >> >> used in insufficiently-resourced computing environments. >> > >> > We actually have two implementations available in tree, >> > >> > audio/ebur128 and audio/libebur128 >> > >> > audio/ebur128 is a Rust implementation that performs noticably better >> > and we moved all consumers almost 3 months ago to that variant. >> > https://cgit.freebsd.org/ports/commit/?id=4cd440845e24202042e8b35a1c1db08a928b5946 >> > >> > >> > Worth mentioning is that it's only a build dependency >> > >> > Best regards, >> > Daniel >> >> > If there's a need further down the road we can add an option to choose >> > between. >> The need has arisen. >> > > I think the most sensible approach would be to handle the ebur128 > dependency similar to librsvg2 and pycryptography. It would be trivial > to create a Mk/Uses/ebur128.mk and allow the user to set whether they > wanted to use the legacy C implementation via DEFAULT_VERSIONS in > /etc/make.conf. The rust version would still be the default, however. > Does that sound like an agreeable solution? > > -Jason While that would be the correct way of handling multiple conflicting libraries I just think it adds unnecessary complexity to very little benefit as I don't see the issue since its a build dependency. Poudriere does also support overlay if you want to modify the tree with local patches. Best regards, Daniel