Re: git: 79e5fba255ef - main - cad/PrusaSlicer: update to 2.6.0

On Sat, Jul 29, 2023 at 7:17 AM Alexey Dokuchaev <danfe@freebsd.org> wrote:

> On Fri, Jul 28, 2023 at 04:40:11PM +0200, Fernando Apestegu??a wrote:
> > El vie, 28 jul 2023, 15:02, Alexey Dokuchaev escribi??:
> > > On Fri, Jul 28, 2023 at 12:48:14PM +0000, Fernando Apestegu??a wrote:
> > > > commit 79e5fba255ef2620dd872e21bdd7dc667fea3c19
> > > >
> > > >   cad/PrusaSlicer: update to 2.6.0
> > > >
> > > >   PR:             272730
> > > >   Reported by:    michal.zielonka.8001@gmail.com
> > > >   Approved by:    teodorsigaev@gmail.com (maintainer)
> > > > ---
> > > >  cad/PrusaSlicer/Makefile                           |   14 +-
> > > >  cad/PrusaSlicer/distinfo                           |    6 +-
> > > >  cad/PrusaSlicer/files/patch-CMakeLists.txt         |   19 +-
> > > >  cad/PrusaSlicer/files/patch-src_CMakeLists.txt     |   15 +-
> > > >  cad/PrusaSlicer/files/patch-src_avrdude_arduino.c  |   10 +
> > > >  .../files/patch-src_libnanosvg_nanosvg.h           | 3109
> > > ++++++++++++++++++++
> > > >  .../files/patch-src_libnanosvg_nanosvgrast.h       | 1485 ++++++++++
> > >
> > > Who reviewed this?  First, we don't create files via patches, and
> >
> > Maintainer did. It's in the commit log and in the PR.
>
> Which means they don't have a clue, and you as committer should have
> requested this whole mess reworked, not checked in as is.  These are
>
the basics your mentor should have explained, did he not?
>

You can contact them and ask them. I assume you know how to get that
information.

About how to contribute to FreeBSD, well, I **don't do** patch review/build
testing in all supported platforms I can get my hands on/run testing in
clean environments/modernization of old ports/train submitters/etc.
But I *keep my fingers crossed when I do git push*. That has to count for
something right?

Have a nice day.


>
> ./danfe
>