Re: git: 7ebddd96d372 - main - multimedia/mlt7*: Update to 7.18.0

From: Charlie Li <vishwin_at_freebsd.org>
Date: Sun, 30 Jul 2023 23:29:50 UTC
Vladimir Druzenko wrote:
> 30.07.2023 23:15, Jason E. Hale wrote:
>>   PLUS_DESC=        Enable plus module
>> -PLUS_LIB_DEPENDS=    libfftw3.so:math/fftw3
>> +PLUS_LIB_DEPENDS=    libebur128.so:audio/ebur128 \
>> +            libfftw3.so:math/fftw3
>>   PLUS_CMAKE_BOOL=    MOD_PLUS
> 
> I'm not mlt guru, but multimedia/mlt7 build fine with PLUS option ON and 
> without audio/ebur128 in PLUS_LIB_DEPENDS.
> Is this dependency really necessary?
> Or maybe it should be in a separate option?
> 
> make configure:
> < … cut … >
> -- Checking for module 'libebur128'
> --   Package 'libebur128', required by 'virtual:world', not found
> < … cut … >
> -- The following features have been enabled:
> < … cut … >
>   * Module: Plus
>   * Module: PlusGPL
> < … cut … >
> 
> Fast search in sources show that there is internal/embedded libebur128 
> and build system use it if can't find external. Isn't it?
> 
MLT tends to use bundled libraries if a feature is enabled but the 
(shared) library does not exist on the target system. We want to use the 
existing shared library here.

-- 
Charlie Li
…nope, still don't have an exit line.