From nobody Sat Jul 29 05:17:24 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RCXnJ45CZz4q5rn; Sat, 29 Jul 2023 05:17:24 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RCXnJ3QKnz3rS4; Sat, 29 Jul 2023 05:17:24 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690607844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oyGfg0trvE4QY86M8J4AAmdFO0jp7lA1k0aTzn4w8dM=; b=EyHpXz3XfdZGwLYWAy0n0EML1CxGF8frbJW/dn1kfEGexH0Ul/OcFrLLCFMZLjZ8xlSAIK RKdepdpfIEJvI8Mo14dKz4U9crAYigrgHrnx2ocVByKAteS+SlvR5gEwOjwtKxGNmFqQy/ hK96voHAHuyoN830qIXjHx3TCyVHFTJZqvZPw/sm0Jx/c5WfUlUgNwDSplSQFfafGTsQNh phfINZkRDuKJefPYqS6YoGqtASazZkjp1VkUpckbZHf/hc7Lrio6Q06hWK4cE8RAQqZ/9i RUGaZJPI2bmDWEIq7DmYbk29/nWzsDGexntpfQhemcOeCFkhCL/SXnEtkaqf2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690607844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oyGfg0trvE4QY86M8J4AAmdFO0jp7lA1k0aTzn4w8dM=; b=a9QsgomLtWRRdywBFI5jrUBV2LWiM+prgd/CPpP0NjJgJjwjbNzmWmxjVpG7XaRK5nYFsc 2u3M1rnnwoIp9e6Y1YpQkJUZz2F6WkdilXNztO7VnVQg+bIqzx4oJaaXQwFHmTNWMb2SaU 5fKKYd4SSubMqVlnZNqru//63kLPo2XjcvssfLkj/0oy+HT5TDii9uNNsZj4Hd/qBhyBQT rIXCVOkstP+VpNQihUQYniUiHNt2E3/41+25gQQw7hb4UmKAsYCsXStsNA3QDFt2Fj6eXy XZsCauQa+KcSrHnTT1g6BX3WWtR33QYxRnYKzOoUWdVUF+DEwdal/uQ69HjbUQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690607844; a=rsa-sha256; cv=none; b=xiocjMQqV3qXhNiQ8q0xXgvBJpYLj6UwshKkMu8U2r1D9clIebWl5RLqtWwMnl4iOTh2yr wbPkvb1Ko+kZXYnKHLlQJahBPTdj2I5sgJXtnw4yQJKbBXUgz4HyGp97cT9d9vXmwqtEcE 65SyAKWsQeKhAtP+eZQiPUTiFiGxIavQB3AklrLLZpnoZaZ4ctkUYGKV/++61GPalhz3RP th18k9xY9z/oGoHGSce8zCxNaGS4AGKVgLkGbBq5RUBFZuw7qTC5NOPpHZYObF6YHcVaXb InSbJahS0gtzVB8FKhxK8BukpZxzl2WQ4iUAqc1cf+jzWF+W2uQid8mMXtgysQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 4E664B0AF; Sat, 29 Jul 2023 05:17:24 +0000 (UTC) Date: Sat, 29 Jul 2023 05:17:24 +0000 From: Alexey Dokuchaev To: Fernando Apestegu??a Cc: "ports-committers@FreeBSD.org" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 79e5fba255ef - main - cad/PrusaSlicer: update to 2.6.0 Message-ID: References: <202307281248.36SCmERV027986@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jul 28, 2023 at 04:40:11PM +0200, Fernando Apestegu??a wrote: > El vie, 28 jul 2023, 15:02, Alexey Dokuchaev escribi??: > > On Fri, Jul 28, 2023 at 12:48:14PM +0000, Fernando Apestegu??a wrote: > > > commit 79e5fba255ef2620dd872e21bdd7dc667fea3c19 > > > > > > cad/PrusaSlicer: update to 2.6.0 > > > > > > PR: 272730 > > > Reported by: michal.zielonka.8001@gmail.com > > > Approved by: teodorsigaev@gmail.com (maintainer) > > > --- > > > cad/PrusaSlicer/Makefile | 14 +- > > > cad/PrusaSlicer/distinfo | 6 +- > > > cad/PrusaSlicer/files/patch-CMakeLists.txt | 19 +- > > > cad/PrusaSlicer/files/patch-src_CMakeLists.txt | 15 +- > > > cad/PrusaSlicer/files/patch-src_avrdude_arduino.c | 10 + > > > .../files/patch-src_libnanosvg_nanosvg.h | 3109 > > ++++++++++++++++++++ > > > .../files/patch-src_libnanosvg_nanosvgrast.h | 1485 ++++++++++ > > > > Who reviewed this? First, we don't create files via patches, and > > Maintainer did. It's in the commit log and in the PR. Which means they don't have a clue, and you as committer should have requested this whole mess reworked, not checked in as is. These are the basics your mentor should have explained, did he not? ./danfe