From nobody Fri Jul 28 14:40:11 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RC9KS1TtPz4ps0K; Fri, 28 Jul 2023 14:40:28 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RC9KR6Ggyz3wg3; Fri, 28 Jul 2023 14:40:27 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-4fe1b00fce2so2823940e87.3; Fri, 28 Jul 2023 07:40:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690555224; x=1691160024; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tI4r1SLv8Tg0+kWiLHzLm1DzkH/TEKlqPG+nkvkOuj4=; b=h96UQX55fvAOZOYlTkpn5NKEoR7macbnZ/GKKJCmRzoIbGZzDE/ULOz6wljaMrlXId qVixGcws5dI9Cr4Vs3Lkk1SrRdMIRBf4mUgku9UlA+gHdnbv7jHUaqyk5ntZ1snDU7ez 7w7m5rfe9Pcx4XK0XqsPTLWa152YQoxu4UW44gzIWx+z0Iqu0316Qihg0qNuYKweHgvJ G0u2TS9G1zyeeYLdFeDWSv0A7eTumLVRS7xSrKYQDeqJhDz3vdnTkONg0BChlkiXQuAf MGA2NCWAl8sOd4F3VRex/KeH7S8KBxEU+s+AIsg6I3lVlGG3YecMfZ2EZX64njqpEpDg cBnw== X-Gm-Message-State: ABy/qLa8EzaQo8Eyjxb84y/xNvXBTHwcMUYn3nR8yLiy1aC78hZ5NFxy 0mq4xg+D+SWLk9zV5qBH36JqeXAb7mI= X-Google-Smtp-Source: APBJJlHbQrK+yb+Hj62m4w7c6Fyqe0kapk68JVF9P0Dwc0VTMBkK7Tta3QGyltQIo9vOgoYi8S8D2w== X-Received: by 2002:ac2:5b10:0:b0:4fb:93db:fff3 with SMTP id v16-20020ac25b10000000b004fb93dbfff3mr1828583lfn.16.1690555224118; Fri, 28 Jul 2023 07:40:24 -0700 (PDT) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com. [209.85.208.176]) by smtp.gmail.com with ESMTPSA id j28-20020ac2551c000000b004fe0c51fb41sm857203lfk.45.2023.07.28.07.40.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 07:40:24 -0700 (PDT) Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2b9b904bb04so33774821fa.1; Fri, 28 Jul 2023 07:40:24 -0700 (PDT) X-Received: by 2002:a2e:9f42:0:b0:2b2:1f2f:705f with SMTP id v2-20020a2e9f42000000b002b21f2f705fmr2064455ljk.4.1690555223845; Fri, 28 Jul 2023 07:40:23 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202307281248.36SCmERV027986@gitrepo.freebsd.org> In-Reply-To: From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Fri, 28 Jul 2023 16:40:11 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 79e5fba255ef - main - cad/PrusaSlicer: update to 2.6.0 To: Alexey Dokuchaev Cc: "ports-committers@FreeBSD.org" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000009730fe06018d0f18" X-Rspamd-Queue-Id: 4RC9KR6Ggyz3wg3 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated --0000000000009730fe06018d0f18 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable El vie, 28 jul 2023, 15:02, Alexey Dokuchaev escribi=C3= =B3: > On Fri, Jul 28, 2023 at 12:48:14PM +0000, Fernando Apestegu??a wrote: > > commit 79e5fba255ef2620dd872e21bdd7dc667fea3c19 > > > > cad/PrusaSlicer: update to 2.6.0 > > > > PR: 272730 > > Reported by: michal.zielonka.8001@gmail.com > > Approved by: teodorsigaev@gmail.com (maintainer) > > --- > > cad/PrusaSlicer/Makefile | 14 +- > > cad/PrusaSlicer/distinfo | 6 +- > > cad/PrusaSlicer/files/patch-CMakeLists.txt | 19 +- > > cad/PrusaSlicer/files/patch-src_CMakeLists.txt | 15 +- > > cad/PrusaSlicer/files/patch-src_avrdude_arduino.c | 10 + > > .../files/patch-src_libnanosvg_nanosvg.h | 3109 > ++++++++++++++++++++ > > .../files/patch-src_libnanosvg_nanosvgrast.h | 1485 ++++++++++ > > Who reviewed this? First, we don't create files via patches, and > Maintainer did. It's in the commit log and in the PR. second, why not properly depend on `graphics/nanosvg' port? > > > diff --git a/cad/PrusaSlicer/files/patch-src_libnanosvg_nanosvg.h > b/cad/PrusaSlicer/files/patch-src_libnanosvg_nanosvg.h > > new file mode 100644 > > index 000000000000..08bf0beb1ef1 > > --- /dev/null > > +++ b/cad/PrusaSlicer/files/patch-src_libnanosvg_nanosvg.h > > @@ -0,0 +1,3109 @@ > > +--- src/libnanosvg/nanosvg.h.orig 1970-01-01 01:00:00.000000000 +01= 00 > > ++++ src/libnanosvg/nanosvg.h 2022-12-22 00:42:08.000000000 +0100 > > +@@ -0,0 +1,3106 @@ > > ++/* > > ++ * Copyright (c) 2013-14 Mikko Mononen memon@inside.org > > ... > > ./danfe > --0000000000009730fe06018d0f18 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


El vie, 28 jul 2023, 15:02, Alexey Dokuchaev <danfe@freebsd.org> escribi=C3=B3:
On Fri, Jul 28, 2023 at 12:48:14PM +0= 000, Fernando Apestegu??a wrote:
> commit 79e5fba255ef2620dd872e21bdd7dc667fea3c19
>
>=C2=A0 =C2=A0cad/PrusaSlicer: update to 2.6.0
>
>=C2=A0 =C2=A0PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0272730<= br> >=C2=A0 =C2=A0Reported by:=C2=A0 =C2=A0 michal.zielonka.8001= @gmail.com
>=C2=A0 =C2=A0Approved by:=C2=A0 =C2=A0 teodorsigaev@gmail.com (= maintainer)
> ---
>=C2=A0 cad/PrusaSlicer/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A014= +-
>=C2=A0 cad/PrusaSlicer/distinfo=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 6= +-
>=C2=A0 cad/PrusaSlicer/files/patch-CMakeLists.txt=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0|=C2=A0 =C2=A019 +-
>=C2=A0 cad/PrusaSlicer/files/patch-src_CMakeLists.txt=C2=A0 =C2=A0 =C2= =A0|=C2=A0 =C2=A015 +-
>=C2=A0 cad/PrusaSlicer/files/patch-src_avrdude_arduino.c=C2=A0 |=C2=A0 = =C2=A010 +
>=C2=A0 .../files/patch-src_libnanosvg_nanosvg.h=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0| 3109 ++++++++++++++++++++
>=C2=A0 .../files/patch-src_libnanosvg_nanosvgrast.h=C2=A0 =C2=A0 =C2=A0= =C2=A0| 1485 ++++++++++

Who reviewed this?=C2=A0 First, we don't create files via patches, and<= br>

M= aintainer did. It's in the commit log and in the PR.


second, why not properly depend on `graphics/nanosvg' port?

> diff --git a/cad/PrusaSlicer/files/patch-src_libnanosvg_nanosvg.h b/ca= d/PrusaSlicer/files/patch-src_libnanosvg_nanosvg.h
> new file mode 100644
> index 000000000000..08bf0beb1ef1
> --- /dev/null
> +++ b/cad/PrusaSlicer/files/patch-src_libnanosvg_nanosvg.h
> @@ -0,0 +1,3109 @@
> +--- src/libnanosvg/nanosvg.h.orig=C2=A0 =C2=A0 1970-01-01 01:00:00.00= 0000000 +0100
> ++++ src/libnanosvg/nanosvg.h 2022-12-22 00:42:08.000000000 +0100
> +@@ -0,0 +1,3106 @@
> ++/*
> ++ * Copyright (c) 2013-14 Mikko Mononen memon@inside.org
> ...

./danfe
--0000000000009730fe06018d0f18--