Re: git: 79e5fba255ef - main - cad/PrusaSlicer: update to 2.6.0

From: Fernando_Apesteguía <fernape_at_freebsd.org>
Date: Fri, 28 Jul 2023 14:40:11 UTC
El vie, 28 jul 2023, 15:02, Alexey Dokuchaev <danfe@freebsd.org> escribió:

> On Fri, Jul 28, 2023 at 12:48:14PM +0000, Fernando Apestegu??a wrote:
> > commit 79e5fba255ef2620dd872e21bdd7dc667fea3c19
> >
> >   cad/PrusaSlicer: update to 2.6.0
> >
> >   PR:             272730
> >   Reported by:    michal.zielonka.8001@gmail.com
> >   Approved by:    teodorsigaev@gmail.com (maintainer)
> > ---
> >  cad/PrusaSlicer/Makefile                           |   14 +-
> >  cad/PrusaSlicer/distinfo                           |    6 +-
> >  cad/PrusaSlicer/files/patch-CMakeLists.txt         |   19 +-
> >  cad/PrusaSlicer/files/patch-src_CMakeLists.txt     |   15 +-
> >  cad/PrusaSlicer/files/patch-src_avrdude_arduino.c  |   10 +
> >  .../files/patch-src_libnanosvg_nanosvg.h           | 3109
> ++++++++++++++++++++
> >  .../files/patch-src_libnanosvg_nanosvgrast.h       | 1485 ++++++++++
>
> Who reviewed this?  First, we don't create files via patches, and
>

Maintainer did. It's in the commit log and in the PR.


second, why not properly depend on `graphics/nanosvg' port?
>
> > diff --git a/cad/PrusaSlicer/files/patch-src_libnanosvg_nanosvg.h
> b/cad/PrusaSlicer/files/patch-src_libnanosvg_nanosvg.h
> > new file mode 100644
> > index 000000000000..08bf0beb1ef1
> > --- /dev/null
> > +++ b/cad/PrusaSlicer/files/patch-src_libnanosvg_nanosvg.h
> > @@ -0,0 +1,3109 @@
> > +--- src/libnanosvg/nanosvg.h.orig    1970-01-01 01:00:00.000000000 +0100
> > ++++ src/libnanosvg/nanosvg.h 2022-12-22 00:42:08.000000000 +0100
> > +@@ -0,0 +1,3106 @@
> > ++/*
> > ++ * Copyright (c) 2013-14 Mikko Mononen memon@inside.org
> > ...
>
> ./danfe
>