From nobody Sun Jul 23 07:15:45 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R7vhx4Jh8z4msNR for ; Sun, 23 Jul 2023 07:16:01 +0000 (UTC) (envelope-from dfr@rabson.org) Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R7vhx0rq3z3Gdr for ; Sun, 23 Jul 2023 07:16:00 +0000 (UTC) (envelope-from dfr@rabson.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-577497ec6c6so37300207b3.2 for ; Sun, 23 Jul 2023 00:16:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rabson-org.20221208.gappssmtp.com; s=20221208; t=1690096557; x=1690701357; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zDGAs0aCkBQDlbZADvUaiJ9/nsALjV1nU8VasjZ8rKw=; b=iqKNYkBL2ViMmipr6WpQPMUR0mCASVQH34shHWYK1zpBZ6Awtda7j4KkpeInfOFdCJ MYJAmkCtMv2DuLzshdJhs7C9VlEz6XrZLhEjqfYIAlBpKg4sHLS1Ua160LP39b/08M/F /l7ewR5chlPVebeZzPoukz+QvJMUtgZwAAVHSJ9cxc1AJnyCJulN3aD0DSH6OQc9dwrw bX7xBTD0+1plaGwuHKMr52cjPu1UsJKEtBpQP7T0y/nlT3KdPQkk2zstSP6c0/KQQ37d cGtjCmlkTL66WkU8U5Oo6B3bFpdryIGVyS6IcBNR1CtIcgDiq8pA2nE8RF08XoH79lLM DFFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690096557; x=1690701357; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zDGAs0aCkBQDlbZADvUaiJ9/nsALjV1nU8VasjZ8rKw=; b=icMULFwGf/LolnKRf46K+dVkITP+zBK9opfJh9veVe7VLou3iqGq+GsOStGYg91R5W TjG8Gdyk5P1KHDhnqBk3NiEkgdPR1hY3H0X35i96tNIYW1kqSRbg2dvWm1/p0LAq8TZp YjuP3YPu2zQbqZaKHmAtxWrOSl87dr3Sjfx88CZuEy3szO/d2VuPd7QbjlTNjjjUZB1A BYRYXB8gGpzykcbAaGhsqryoNBbIKnEjOPKv5JMJNkw1lkL6FB3c//n6SUm6irg6iuII wRZUP4O8WM8ucagj8nF4sGkW19GLoItc15/7xaFzhqH+xNKsCmBwgQcrGP+fAeBwLVXJ 2eIw== X-Gm-Message-State: ABy/qLaZgUJo16cEGlWMJYMGJxz6ZuV5n4kQ5bNnDJ+sGBudlSOZCorA F+8myR+XyDCKPYlL4lcv/NZzYEseMPpo9ONHXkdWyzKuTqGeU9yQTcE= X-Google-Smtp-Source: APBJJlFtg7r60TAQ/XAVlTk0bdZC8XQyj4IQpiZ16qPkq4XvGYZxVQLEgIEV6fsXNAzByCl7e+W2vSUi3l9lWuyP/Ug= X-Received: by 2002:a0d:d584:0:b0:570:81f1:7b49 with SMTP id x126-20020a0dd584000000b0057081f17b49mr3359821ywd.6.1690096557137; Sun, 23 Jul 2023 00:15:57 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202307221238.36MCc06w097209@gitrepo.freebsd.org> In-Reply-To: From: Doug Rabson Date: Sun, 23 Jul 2023 08:15:45 +0100 Message-ID: Subject: Re: git: da411ab69810 - main - sysutils/catatonit: new port To: Daniel Engberg Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000ecb2ca0601224467" X-Rspamd-Queue-Id: 4R7vhx0rq3z3Gdr X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated --000000000000ecb2ca0601224467 Content-Type: text/plain; charset="UTF-8" On Sat, 22 Jul 2023 at 15:21, Daniel Engberg wrote: > > Why is pre-configure section needed if you use USES= autoreconf ? > LICENSE seems to be incorrect? > > https://github.com/dfr/catatonit/commit/96760cc0acb3643a266505b71d025b484e2c4a98 > (see commit message and README.md) > Please define LICENSE_FILE > HAS_CONFIGURE should be GNU_CONFIGURE > Is gmake really needed? Works fine on 13.2-RELEASE using (b)make > If you only have two files in pkg-plist you can also define plist in the > Makefile instead. (optional) > Thanks for the feedback. I don't think I even tried to build with bmake - I guess I assumed that autoconf tends to imply gmake. I'll send you a patch to fix the license issue and other nits. Doug. --000000000000ecb2ca0601224467 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sat, 22 Jul 2023 at 15:21, Daniel = Engberg <diizzy@freebsd.org>= ; wrote:

Why is pre-configure section needed if you use USES=3D autoreconf ?
LICENSE seems to be incorrect?
https://github.com/d= fr/catatonit/commit/96760cc0acb3643a266505b71d025b484e2c4a98
(see commit message and README.md)
Please define LICENSE_FILE
HAS_CONFIGURE should be GNU_CONFIGURE
Is gmake really needed? Works fine on 13.2-RELEASE using (b)make
If you only have two files in pkg-plist you can also define plist in the Makefile instead. (optional)

Thanks for= the feedback. I don't think I even tried to build with bmake - I guess= I assumed that autoconf tends to imply gmake. I'll send you a patch to= fix the license issue and other nits.

=C2=A0Doug.=
--000000000000ecb2ca0601224467--