Re: git: da411ab69810 - main - sysutils/catatonit: new port

On 2023-07-22 14:38, Doug Rabson wrote:
> The branch main has been updated by dfr:
> 
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=da411ab69810ce4452c294ce0d80f9de7cdcd74e
> 
> commit da411ab69810ce4452c294ce0d80f9de7cdcd74e
> Author:     Doug Rabson <dfr@FreeBSD.org>
> AuthorDate: 2023-06-12 12:07:18 +0000
> Commit:     Doug Rabson <dfr@FreeBSD.org>
> CommitDate: 2023-07-22 12:36:46 +0000
> 
>     sysutils/catatonit: new port
> 
>     Approved by: lwhsu
> 
>     This is a very simple init-like command intended for use with
>     'podman run --init' or 'docker run --init'.
> ---
>  sysutils/Makefile            |  1 +
>  sysutils/catatonit/Makefile  | 26 ++++++++++++++++++++++++++
>  sysutils/catatonit/distinfo  |  3 +++
>  sysutils/catatonit/pkg-descr |  2 ++
>  sysutils/catatonit/pkg-plist |  2 ++
>  5 files changed, 34 insertions(+)
> 
> diff --git a/sysutils/Makefile b/sysutils/Makefile
> index 7050a7d3b783..af023d300ae7 100644
> --- a/sysutils/Makefile
> +++ b/sysutils/Makefile
> @@ -163,6 +163,7 @@
>      SUBDIR += bvm
>      SUBDIR += byobu
>      SUBDIR += calamares
> +    SUBDIR += catatonit
>      SUBDIR += catfish
>      SUBDIR += catsit
>      SUBDIR += cbsd
> diff --git a/sysutils/catatonit/Makefile b/sysutils/catatonit/Makefile
> new file mode 100644
> index 000000000000..8758f9a678cc
> --- /dev/null
> +++ b/sysutils/catatonit/Makefile
> @@ -0,0 +1,26 @@
> +PORTNAME=	catatonit
> +DISTVERSIONPREFIX=	v
> +DISTVERSION=	0.1.7
> +CATEGORIES=	sysutils
> +
> +MAINTAINER=	dfr@FreeBSD.org
> +COMMENT=	A signal-forwarding process manager for containers
> +WWW=		https://github.com/openSUSE/catatonit
> +
> +LICENSE=	GPLv3
> +
> +USES=		autoreconf gmake
> +USE_GITHUB=	yes
> +GH_ACCOUNT=	dfr
> +GH_TAGNAME=	65a1a0f
> +
> +HAS_CONFIGURE=	yes
> +
> +pre-configure:
> +	@(cd ${WRKSRC} && ./autogen.sh)
> +
> +post-install:
> +	@${MKDIR} ${STAGEDIR}${PREFIX}/libexec/podman
> +	@${RLN} ${STAGEDIR}${PREFIX}/bin/catatonit
> ${STAGEDIR}${PREFIX}/libexec/podman/catatonit
> +
> +.include <bsd.port.mk>
> diff --git a/sysutils/catatonit/distinfo b/sysutils/catatonit/distinfo
> new file mode 100644
> index 000000000000..8d60e5ac61ae
> --- /dev/null
> +++ b/sysutils/catatonit/distinfo
> @@ -0,0 +1,3 @@
> +TIMESTAMP = 1686565868
> +SHA256 (dfr-catatonit-v0.1.7-65a1a0f_GH0.tar.gz) =
> e189a16b8b31a275ed9184c1c985f1cb197817b917805a99f0e576f4ec5bcfaf
> +SIZE (dfr-catatonit-v0.1.7-65a1a0f_GH0.tar.gz) = 22325
> diff --git a/sysutils/catatonit/pkg-descr 
> b/sysutils/catatonit/pkg-descr
> new file mode 100644
> index 000000000000..03f2a4a25322
> --- /dev/null
> +++ b/sysutils/catatonit/pkg-descr
> @@ -0,0 +1,2 @@
> +A container init that is so simple it's effectively brain-dead. See
> +https://github.com/openSUSE/catatonit#readme for more details.
> diff --git a/sysutils/catatonit/pkg-plist 
> b/sysutils/catatonit/pkg-plist
> new file mode 100644
> index 000000000000..039ba1e7cc3c
> --- /dev/null
> +++ b/sysutils/catatonit/pkg-plist
> @@ -0,0 +1,2 @@
> +bin/catatonit
> +libexec/podman/catatonit

Hi,

Why is pre-configure section needed if you use USES= autoreconf ?
LICENSE seems to be incorrect? 
https://github.com/dfr/catatonit/commit/96760cc0acb3643a266505b71d025b484e2c4a98 
(see commit message and README.md)
Please define LICENSE_FILE
HAS_CONFIGURE should be GNU_CONFIGURE
Is gmake really needed? Works fine on 13.2-RELEASE using (b)make
If you only have two files in pkg-plist you can also define plist in the 
Makefile instead. (optional)

Best regards,
Daniel