From nobody Tue Jul 11 18:43:33 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R0qWs5sz1z3cLWD; Tue, 11 Jul 2023 18:43:37 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Received: from mailer.gwdg.de (mailer.gwdg.de [134.76.10.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4R0qWr6gxLz4N0b; Tue, 11 Jul 2023 18:43:36 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Authentication-Results: mx1.freebsd.org; none Received: from excmbx-22.um.gwdg.de ([134.76.9.232] helo=email.gwdg.de) by mailer.gwdg.de with esmtp (GWDG Mailer) (envelope-from ) id 1qJIKk-000CL4-AS; Tue, 11 Jul 2023 20:43:34 +0200 Received: from MBX19-GWD-03.um.gwdg.de (10.108.142.56) by excmbx-22.um.gwdg.de (134.76.9.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.2507.27; Tue, 11 Jul 2023 20:43:34 +0200 Received: from [192.168.178.23] (10.250.9.199) by MBX19-GWD-03.um.gwdg.de (10.108.142.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1118.30; Tue, 11 Jul 2023 20:43:33 +0200 Message-ID: <8a1b8efc-9d27-4860-7cfe-30b5514b280d@gwdg.de> Date: Tue, 11 Jul 2023 20:43:33 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: git: b56d0bc41af7 - main - devel/libcutl: Explain why USE_CXXSTD=c++11 is used Content-Language: en-US To: Raphael Kubo da Costa CC: , , References: <202307050850.3658oPOA049562@gitrepo.freebsd.org> <6cf6a5eb00dfac8358dfcb1e1d5b69f293c3e85a.camel@FreeBSD.org> <4701f862-7a0b-afab-48fd-a62b6f5ec308@gwdg.de> <5bd4df5587c773d3e8916fe64d093f2b96e67e24.camel@FreeBSD.org> Reply-To: "Hurling, Rainer" From: Rainer Hurling In-Reply-To: <5bd4df5587c773d3e8916fe64d093f2b96e67e24.camel@FreeBSD.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.250.9.199] X-ClientProxiedBy: excmbx-16.um.gwdg.de (134.76.9.227) To MBX19-GWD-03.um.gwdg.de (10.108.142.56) X-Virus-Scanned: (clean) by clamav X-Rspamd-Queue-Id: 4R0qWr6gxLz4N0b X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:680, ipnet:134.76.0.0/16, country:DE] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Hi Raphael, Am 11.07.23 um 20:16 schrieb Raphael Kubo da Costa: > On Thu, 2023-07-06 at 20:48 +0200, Rainer Hurling wrote: >> Am 06.07.23 um 10:51 schrieb Raphael Kubo da Costa: >>>> As for a PORTREVISION bump: it _could_ be the case that the >>>> generated >>>> files differ now, as in the past the default standard was gnu++14 >>>> rather than c++11. For leaf ports like these two I don't think >>>> the >>>> difference really matters, but I've been semi-abstent for so long >>>> that >>>> portmgr@ or someone more active may have a better guideline. >>> >>> By the way, one other possibility that I haven't tested myself if >>> compatibility is an issue would be doing something like >>> https://cgit.freebsd.org/ports/commit/?id=4e0c2ae319222145ab0b3f37c0ba52f596426d5a >>> >>> but passing USE_STDCXX=gnu++14 instead of changing CXXFLAGS. This >>> would >>> guarantee that non-main with older clang releases remain untouched >>> while also making clang 16 use the same standard that the older >>> clang >>> releases use. >> >> Since the eboard project is hardly maintained, an upstream patch is >> currently difficult to implement. Therefore I consider to take the >> tip >> to heart and to change to USE_STDCXX=gnu++14 in the games/eboard >> port. >> The port builds well, the program seems to work without errors. >> >> Still, one more question: is it safe to remove USES=compiler:c++11- >> lang >> for architectures other than amd64 and i386 and just use >> USE_STDCXX=gnu++14. I have no way to test for arm, etc. > > Nuno asked about this in https://reviews.freebsd.org/D40939 a while > ago, and pkubaj@ explained in which situations those keywords (or at > least some of them) are required: > > https://reviews.freebsd.org/D40939#932674 > > By having those entries, you basically ensure the port builds on > FreeBSD 12 for Tier 2 architectures like powerpc and powerpc64 which > still use GCC 4.2 on FreeBSD 12. Thanks for the pointer. Yes, this helps one step further :) And, this also means that USES=compiler:C++11-lang provides anything gcc specific? Then it would also be unnecessary to use USE_CXXSTD=gnu++11 instead of USE_CXXSTD=c++11? Sorry if this should have been clarified already and I just didn't understand it yet.