From nobody Fri Jul 07 11:29:38 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QyB5B4vkxz4lXbk; Fri, 7 Jul 2023 11:29:50 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QyB5B42d8z4MvL; Fri, 7 Jul 2023 11:29:50 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688729390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tkR4a0roZ48hspy4T02RdejVvI4HZhau95QsoIkUDLA=; b=w2VttVRFfIordAwI1DyPqiI0Js0ufShqo0nmXdaQ3cjamoi0qJyztdBXUIsc/J+HxXB2YG Yha3+D4S6OBS5YVz+3s2UIFOLuB3PaMFIcH6qRHux42RjsJZ7gaikfYUHyoYO1EQnHHM1v UkvfoA4JvW8GpPu8T6jMB06IlF521Qj2Fx7Pa/HfNVaJRvCm2tgrL/ZW+im+RDZ5AjHvmc 4YoZKVVH9IEz4Dn6sDh5vDYuqYOgv1822Hp45rTDv8GfwScj4wIR71+3xe807pNBDrSn7X yuiHgjeDSvDmYDN6Tn3DCXxBkBdh1I5RqipNZ3hp0Z3AaxSGzYdisl3VtXEjmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688729390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tkR4a0roZ48hspy4T02RdejVvI4HZhau95QsoIkUDLA=; b=Y02giFUfWRw5lUAqxXInMOancR1TVvFyfOfFkTJ+G3uR7yWGpl0gq6XPqliXh51Ug8eiIS ek+sPyXOsrXBshsqB2hPyeukvxqFo7oLCu+iQaZDxMvCU2ipjXsKF4p8JbFsYpuFVtVVzc LB6QjpuD4mM9U75xZTrn8m55/w4iDw+G7FRR7RcDzJUE00y+UYbTtJ2k5vfw28U7hM2EPj kQNSuNgUEaxF21uJ8qapOtXfJ/c419AqJWi6rv0VUNDXse+0YKgowaEpFoMGOP3bwvVVfy jkKtPGAoNtMqE4ZrkryKsLIBZkiLn+4eJ36Hq+fDZ/txdaK2A8zf/wU+C1KhPw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1688729390; a=rsa-sha256; cv=none; b=CBav4B6mMCvhOA/g/BzyUiUxfBt5EOSf8Vwd6FFUY2Na60us3nK432zjxf5AubvuSdyg8e 0msqUKbPwt3UTbAXK+FgoswFWE98+MJdZfKJ2mzcGBGKBM9k1iDsLcGLhRqzVLH4QTFhG1 Ung3UR8oI2S0uVv+s5hchgjhYQW5zzZvlV27BhepyzxaGkaBB8/6pghQuRHFgN2ox9LI3y 6HgrSDtVHJDfTfWcugcp+skRP/QdIuReeUPI7+OmTD0Qy7Cd6MU71gYKipMccTQs6iMBxu Erl+v8mghvKqXbAYjpUI0B7RmR+q8hk+yuGOntqxojT6mrNpaZaWU/FVmLpW7A== Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QyB5B2zTtzg41; Fri, 7 Jul 2023 11:29:50 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-40373bc598dso14702081cf.1; Fri, 07 Jul 2023 04:29:50 -0700 (PDT) X-Gm-Message-State: ABy/qLZFmmSUiVdAFa29tBHITaH9Ro4dfW1SN6EIXCPfIRnG1bvuMAhc g02vxONIF6nw0necA1CEkSKYW97z/2e6ofEfJws= X-Google-Smtp-Source: APBJJlF0SPg0EaAmiTj5ffcT+dHDPUuMoQq0yS0+8UffbBW77Yo/nlUHV6QiUPK8x70V9PBUS+orUGue9R0bFMlfXKg= X-Received: by 2002:a05:622a:1483:b0:400:8713:d2de with SMTP id t3-20020a05622a148300b004008713d2demr6240499qtx.24.1688729389519; Fri, 07 Jul 2023 04:29:49 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202307050850.3658oPOA049562@gitrepo.freebsd.org> <6cf6a5eb00dfac8358dfcb1e1d5b69f293c3e85a.camel@FreeBSD.org> <4701f862-7a0b-afab-48fd-a62b6f5ec308@gwdg.de> <4cc5665f-a4ef-a4ef-226a-a9a59b29f3a0@gwdg.de> <45470f65-48c3-9a18-b7bd-26ce17160afd@gwdg.de> In-Reply-To: <45470f65-48c3-9a18-b7bd-26ce17160afd@gwdg.de> From: Nuno Teixeira Date: Fri, 7 Jul 2023 12:29:38 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: b56d0bc41af7 - main - devel/libcutl: Explain why USE_CXXSTD=c++11 is used To: "Hurling, Rainer" Cc: Raphael Kubo da Costa , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000006259db05ffe3f3de" X-ThisMailContainsUnwantedMimeParts: N --0000000000006259db05ffe3f3de Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable PORTREVISION=3D11: USE_CXXSTD=3Dgnu++14 http://freebsdrpi4.hopto.org/data/13Saarch64-main/2023-07-07_12h12m14s/logs= /eboard-1.1.3_11.log PORTREVISION=3D10: USE_CXXSTD=3Dc++14 http://freebsdrpi4.hopto.org/data/13Saarch64-main/2023-07-07_09h44m48s/logs= /eboard-1.1.3_10.log Both revs 10 and 11 runs OK. I've take a look at logs and it seems that glib2 deprecations could be the reason for c++17 build failures. Could you take a look at: https://cgit.freebsd.org/ports/commit/?id=3De95c4bea425b3e3c49b63e0cf4eff24= af40c574b it also includes link to mailing full discussion. This is what we should do when possible, fix the code as said in previous messages. Rainer Hurling escreveu no dia sexta, 7/07/2023 =C3=A0(s) 10:53: > Am 07.07.23 um 10:59 schrieb Nuno Teixeira: > > Hello! > > > > I've bumped PORTREVISION to 10 so we can identify better each experimen= t > > build: > > > > PORTREVISION=3D10: USE_CXXSTD=3Dc++14 > > build status: > > > http://freebsdrpi4.hopto.org/build.html?mastername=3D13Saarch64-main&buil= d=3D2023-07-07_09h44m48s > < > http://freebsdrpi4.hopto.org/build.html?mastername=3D13Saarch64-main&buil= d=3D2023-07-07_09h44m48s > > > > > > and when built I will do a run test. > > > > Oops, yes! > > > Shoud I test gnu++14 too? > > I accidentally provided a patch with c++14 that I had used for another > test of my own. Meant was gnu++14, so please feel free to test that one > too. Thanks! > > > > > > > > > > > Rainer Hurling > escreveu no > > dia sexta, 7/07/2023 =C3=A0(s) 06:42: > > > > Hi Nuno, > > > > Am 06.07.23 um 23:51 schrieb Nuno Teixeira: > > > Hello Rainer, > > > > > > Still, one more question: is it safe to remove > > USES=3Dcompiler:c++11-lang > > > for architectures other than amd64 and i386 and just use > > > USE_STDCXX=3Dgnu++14. I have no way to test for arm, etc. > > > > > > > > > I've asked the same for compiler:c11 on mailing today. > > > My doubt is: is it neccessary using c11, c++11, etc when availab= le > > > compilers support it or have capabilities for it? > > > > > > I can do poudriere testport and run test on a rpi4 running 13 > > stable, > > > just send me diff. > > > > Thanks for the offer. Here is a diff against games/eboard with the = to > > changes: > > > > diff --git a/games/eboard/Makefile b/games/eboard/Makefile > > index 3f78f9e91874..ce399415cba8 100644 > > --- a/games/eboard/Makefile > > +++ b/games/eboard/Makefile > > @@ -20,10 +20,10 @@ LIB_DEPENDS=3D > > libfontconfig.so:x11-fonts/fontconfig \ > > libfreetype.so:print/freetype2 \ > > libpng.so:graphics/png > > > > -USES=3D compiler:c++11-lang gnome gstreamer perl5 pkgconf= ig > > shebangfix tar:bzip2 > > +USES=3D gnome gstreamer perl5 pkgconfig shebangfix tar:bz= ip2 > > # eboard 1.1.13 is not compatible with C++17, which is the > > default since > > # clang 16. This means ports depending on it also need to use at > > most > > C++14. > > -USE_CXXSTD=3D c++11 > > +USE_CXXSTD=3D c++14 > > USE_GITHUB=3D yes > > GH_ACCOUNT=3D fbergo > > USE_GNOME=3D cairo gdkpixbuf2 gtk20 > > > > > > It would be very nice if you could also look for arm, if the packag= e > is > > still binary compatible compared to the unpatched version :) > > > > Thanks a lot ! > > > > Best wishes, > > Rainer > > > > > > > > Cheers, > > > > > > -- > > > Nuno Teixeira > > > FreeBSD Committer (ports) > > > > > > > > -- > > Nuno Teixeira > > FreeBSD Committer (ports) > > --=20 Nuno Teixeira FreeBSD Committer (ports) --0000000000006259db05ffe3f3de Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
PORTREVISION=3D11:=C2=A0 USE= _CXXSTD=3Dgnu++14

PORTREV= ISION=3D10:=C2=A0 USE_CXXSTD=3Dc++14

Both revs 10 = and 11 runs OK.

I've take a look at logs and i= t seems that glib2 deprecations could be the reason for c++17 build failure= s.
Could you take a look at:
it also includes link to mailing full discussion.
=

This is what we should do when possible, fix the code a= s said in previous messages.

=
Rainer Hurling <rhurlin@gwdg.de> escreveu no dia sexta, 7/07/2023 = =C3=A0(s) 10:53:
Am 07.07.23 um 10:59 schrieb Nuno Teixeira:
> Hello!
>
> I've bumped PORTREVISION to 10 so we can identify better each expe= riment
> build:
>
> PORTREVISION=3D10:=C2=A0 USE_CXXSTD=3Dc++14
> build status:
> http://freebsdrpi4.hopto.org/build.html?mastername=3D13Saarch64-main&= amp;build=3D2023-07-07_09h44m48s <http://freebsdrpi4.hopto.org/buil= d.html?mastername=3D13Saarch64-main&build=3D2023-07-07_09h44m48s>= ;
>
> and when built I will do a run test.
>

Oops, yes!

> Shoud I test gnu++14 too?

I accidentally provided a patch with c++14 that I had used for another
test of my own. Meant was gnu++14, so please feel free to test that one too. Thanks!

>
>
>
>
> Rainer Hurling <rhurlin@gwdg.de <mailto:rhurlin@gwdg.de>> escreveu no
> dia sexta, 7/07/2023 =C3=A0(s) 06:42:
>
>=C2=A0 =C2=A0 =C2=A0Hi Nuno,
>
>=C2=A0 =C2=A0 =C2=A0Am 06.07.23 um 23:51 schrieb Nuno Teixeira:
>=C2=A0 =C2=A0 =C2=A0 > Hello Rainer,
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0Still, one more question: = is it safe to remove
>=C2=A0 =C2=A0 =C2=A0USES=3Dcompiler:c++11-lang
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0for architectures other th= an amd64 and i386 and just use
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0USE_STDCXX=3Dgnu++14. I ha= ve no way to test for arm, etc.
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > I've asked the same for compiler:c11 on m= ailing today.
>=C2=A0 =C2=A0 =C2=A0 > My doubt is: is it neccessary using c11, c++1= 1, etc when available
>=C2=A0 =C2=A0 =C2=A0 > compilers support it or have capabilities for= it?
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > I can do poudriere testport and run test on a= rpi4 running 13
>=C2=A0 =C2=A0 =C2=A0stable,
>=C2=A0 =C2=A0 =C2=A0 > just send me diff.
>
>=C2=A0 =C2=A0 =C2=A0Thanks for the offer. Here is a diff against games/= eboard with the to
>=C2=A0 =C2=A0 =C2=A0changes:
>
>=C2=A0 =C2=A0 =C2=A0diff --git a/games/eboard/Makefile b/games/eboard/M= akefile
>=C2=A0 =C2=A0 =C2=A0index 3f78f9e91874..ce399415cba8 100644
>=C2=A0 =C2=A0 =C2=A0--- a/games/eboard/Makefile
>=C2=A0 =C2=A0 =C2=A0+++ b/games/eboard/Makefile
>=C2=A0 =C2=A0 =C2=A0@@ -20,10 +20,10 @@ LIB_DEPENDS=3D
>=C2=A0 =C2=A0 =C2=A0libfontconfig.so:x11-fonts/fontconfig \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0libfreetype.so:print/freetype2 \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0libpng.so:graphics/png
>
>=C2=A0 =C2=A0 =C2=A0-USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler= :c++11-lang gnome gstreamer perl5 pkgconfig
>=C2=A0 =C2=A0 =C2=A0shebangfix tar:bzip2
>=C2=A0 =C2=A0 =C2=A0+USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gnome gs= treamer perl5 pkgconfig shebangfix tar:bzip2
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 # eboard 1.1.13 is not compatible with C++1= 7, which is the
>=C2=A0 =C2=A0 =C2=A0default since
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 # clang 16. This means ports depending on i= t also need to use at
>=C2=A0 =C2=A0 =C2=A0most
>=C2=A0 =C2=A0 =C2=A0C++14.
>=C2=A0 =C2=A0 =C2=A0-USE_CXXSTD=3D=C2=A0 =C2=A0 c++11
>=C2=A0 =C2=A0 =C2=A0+USE_CXXSTD=3D=C2=A0 =C2=A0 c++14
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 USE_GITHUB=3D=C2=A0 =C2=A0 yes
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 GH_ACCOUNT=3D=C2=A0 =C2=A0 fbergo
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 USE_GNOME=3D=C2=A0 =C2=A0 =C2=A0cairo gdkpi= xbuf2 gtk20
>
>
>=C2=A0 =C2=A0 =C2=A0It would be very nice if you could also look for ar= m, if the package is
>=C2=A0 =C2=A0 =C2=A0still binary compatible compared to the unpatched v= ersion :)
>
>=C2=A0 =C2=A0 =C2=A0Thanks a lot !
>
>=C2=A0 =C2=A0 =C2=A0Best wishes,
>=C2=A0 =C2=A0 =C2=A0Rainer
>
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > Cheers,
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > --
>=C2=A0 =C2=A0 =C2=A0 > Nuno Teixeira
>=C2=A0 =C2=A0 =C2=A0 > FreeBSD Committer (ports)
>
>
>
> --
> Nuno Teixeira
> FreeBSD Committer (ports)



--
Nuno Teixeira
FreeBSD Committ= er (ports)
--0000000000006259db05ffe3f3de--