From nobody Fri Jan 27 10:17:13 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P3D7X1xknz3bG3v; Fri, 27 Jan 2023 10:18:48 +0000 (UTC) (envelope-from yasu@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P3D7X0lfxz43pJ; Fri, 27 Jan 2023 10:18:48 +0000 (UTC) (envelope-from yasu@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674814728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tBm+Xab54Ncsu65XTggZo7yqd4N8SPzN41R2aKymo80=; b=lHMXhpUyfriruASDsp4cWyHTgSR4IgeNFNXktTABUcgDjD7Int5R5vPThAAnj2ktjjRBo/ PytL1WtNpQHb4nKoZZT5aE8G1f3aUlM1CBwnkL/RJt/e5ePqNSl82OCKpCLucVXnOW8SC5 zZEvRi1J/JQDv8T1Kw2SrRzrcNmWlo/YZJuYoRI6PWCIxz6lUU52owYKumNb+rjUcX8bEl /cdcLgMPSC8i8tYGhh4aENucQl/0V1kfZiH3SXdLVV8vEFB5JbSao6q8Uip1j57wyCpke+ wvXscfbhESajBq5k2iAnVxoUCbASyO2O85BcsRppcEA4DJc6OrjWgdHb6csxiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674814728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tBm+Xab54Ncsu65XTggZo7yqd4N8SPzN41R2aKymo80=; b=Bnd6JDif8yviYX+1+f3d3DTojx1Z1ppvJHllQZGOoMgMm+n1BbmBU6YtypqsDQJ6NcJjVX 4PvU5PSR1nTNrxz2rgotS7Dk4WsBG5OkXE2NgEFXWxNSKSftGbh9bMJ33fRLSvw6/pulBz Z+nQSgyf3F0L77ck8936aYgczcjRS/GT8Te2w2DAYhMeJVXKkuQoGF2iKoxmZf6frkaYA3 lYYjpb/qU36RwX1rUTytycQF0s63oTTvHRU6oqcgFPdRWIfOl9NlaA/mlLZcQUsrdEwyfk +PdOMzh6dS+Dqjgm7RenV4Zp9UTDTEa0dSkB/gKxTxVoPCPPMC2dhvcyhzDwKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674814728; a=rsa-sha256; cv=none; b=YyIrEz3Omrh5gb8pkStNaHs3D3j1zwQrzBeV+2UjZZ7Qg6bOwVTA73vdMlhoMHQXfYffup tMTlsZd7Qx70QFjH1VEtJ06ftGrh6oajfxS1xgNSHo+jksCwWyR0oQMmRWqik7YY/hQTkZ zGOldWuqX8sRmBR0jTMe9pLdVh53GFTeE4uNhuNbOGgWAhpTp+xJxMt8UJqg9ebpzuv4tm AsWqFMGQ7bUdSiloIUt+wTo4lUohd453KSjPQhtPHOot2w5VWCvsAPj+2rfF5fBCyoNVsC lBrrRs3T4WtPDUeuKaGZFUM6Y+aM4IxAytbg7Bu9E6d9K+TVZCyhZDXIkdq3PA== Received: from localhost (unknown [IPv6:240b:11:220:fe00::174:32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: yasu/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4P3D7V5mdmz12Kj; Fri, 27 Jan 2023 10:18:46 +0000 (UTC) (envelope-from yasu@FreeBSD.org) Date: Fri, 27 Jan 2023 19:17:13 +0900 (JST) Message-Id: <20230127.191713.2183382863074960001.yasu@FreeBSD.org> To: bofh@FreeBSD.org Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 0983bbffe275 - main - devel/rubygem-oj: Fix build From: Yasuhiro Kimura In-Reply-To: <202301181534.30IFYYOw066510@gitrepo.freebsd.org> References: <202301181534.30IFYYOw066510@gitrepo.freebsd.org> X-Mailer: Mew version 6.8 on Emacs 30.0.50 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N From: Muhammad Moinur Rahman Subject: git: 0983bbffe275 - main - devel/rubygem-oj: Fix build Date: Wed, 18 Jan 2023 15:34:34 GMT > The branch main has been updated by bofh: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=0983bbffe275d18b7b7c576817f3eb57e2504bfe > > commit 0983bbffe275d18b7b7c576817f3eb57e2504bfe > Author: Muhammad Moinur Rahman > AuthorDate: 2023-01-18 15:28:49 +0000 > Commit: Muhammad Moinur Rahman > CommitDate: 2023-01-18 15:32:49 +0000 > > devel/rubygem-oj: Fix build > > Currently the header files are not included although there is a > post-install step. However there is a missing line where we need to > create the directories. > > This fixes the builds of gitlab-ce. Unfortunately build still fails after this commit. "${INSTALL_DATA} -d" creates directory with 0644 and it result in failing to copy header files with 'permission denied'. Attached patch fixes it. It uses "${INSTALL} -d" instead. So directory is created with 0755 and now header files are copied successfully. From 3a01bac7a4793cc191bc605fbb81b0380ab26959 Mon Sep 17 00:00:00 2001 From: Yasuhiro Kimura Date: Fri, 27 Jan 2023 18:41:22 +0900 Subject: [PATCH] devel/rubygem-oj: Create directoy with proper mode "${INSTALL_DATA} -d" creates directory with 0644 and it result in failing to copy header files with 'permission denied'. So use "${INSTALL} -d" instead.It creates directory with 0755 and header files are copied successfully. Fixes: 0983bbffe275 --- devel/rubygem-oj/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/devel/rubygem-oj/Makefile b/devel/rubygem-oj/Makefile index 374e6a43edc7..367164535c29 100644 --- a/devel/rubygem-oj/Makefile +++ b/devel/rubygem-oj/Makefile @@ -1,6 +1,6 @@ PORTNAME= oj PORTVERSION= 3.13.23 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= devel rubygems MASTER_SITES= RG @@ -16,7 +16,7 @@ USES= gem # TODO: find a better way to do this # Copy all header file, as it is required by rubygem-oj-introspect post-install: - ${INSTALL_DATA} -d ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}-${PORTVERSION}/ext/oj + ${INSTALL} -d ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}-${PORTVERSION}/ext/oj cd ${WRKSRC}/ext/oj && ${FIND} * -name "*.h" -type f -exec ${INSTALL_DATA} {} "${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}-${PORTVERSION}/ext/oj/{}" \; .include -- 2.39.1 --- Yasuhiro Kimura