From nobody Mon Jan 16 21:12:30 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nwl995DFbz2pBCP; Mon, 16 Jan 2023 21:12:45 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nwl993YRtz42Kd; Mon, 16 Jan 2023 21:12:45 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-f41.google.com with SMTP id br9so9063800lfb.4; Mon, 16 Jan 2023 13:12:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mwLqk4ft7TDKEEdKPU5y0s42nqr/XCNu62h9CtVm43s=; b=uyUO0I1P4l/cIkhv6Ea8TzUBhgyo2W/SlMe/yda7Xp4rWcf1snr4pcZnspLXJectZT 0pMq8+2A8r+agyiYH2I3VsL+L72OPeCelwkwi8YKmkZJNXSgLKDFOszrPwON0owRyI4H vHNz0FmdXre/M6EF6Y2WfzJU5rvQJ5mvAXg5NrFaSEfbHMVKbl0ymx4eIIsqDS/mbhYI VXdD93MjTC6xA14HaL2BoBQH7k4TYbpZHRmowJXJbEp6/qs4lNKmb/9fEurqM342PURJ 1xv9/Do5C3eBd/VOFD8/yfxp6WL4TkgXzdc2TXvbdl9yuwCD6yzBP0nLUBuqSC9fdCz0 DdRg== X-Gm-Message-State: AFqh2ko0rA6+UqNZUvP4ktiQsTAPKVXO9/T04dk/+BBYzeWLwV5svN19 yvGCxBrxrhHNO9zrWWDOQP/778r4X3RpmBtq X-Google-Smtp-Source: AMrXdXtOssuvKSFveU7roeYlTomPs5cTR6Z8ZhdKVEv8P8NtbT7P+pcjfOwIDqr8gWldyDfUE5rPqg== X-Received: by 2002:a05:6512:114e:b0:4d0:8469:b196 with SMTP id m14-20020a056512114e00b004d08469b196mr174445lfg.3.1673903562797; Mon, 16 Jan 2023 13:12:42 -0800 (PST) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com. [209.85.167.49]) by smtp.gmail.com with ESMTPSA id d20-20020a056512369400b004cafe989c6dsm5151141lfs.91.2023.01.16.13.12.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 13:12:42 -0800 (PST) Received: by mail-lf1-f49.google.com with SMTP id br9so9063714lfb.4; Mon, 16 Jan 2023 13:12:42 -0800 (PST) X-Received: by 2002:ac2:42d7:0:b0:4cc:7a42:d93f with SMTP id n23-20020ac242d7000000b004cc7a42d93fmr21761lfl.500.1673903561926; Mon, 16 Jan 2023 13:12:41 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202301161248.30GCmHnK091914@gitrepo.freebsd.org> In-Reply-To: From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Mon, 16 Jan 2023 22:12:30 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 38e6e935efa6 - main - dns/unbound: add dynlib port option To: Adam Weinberger Cc: "ports-committers@FreeBSD.org" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000326c6005f2680b94" X-Rspamd-Queue-Id: 4Nwl993YRtz42Kd X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000326c6005f2680b94 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable El lun., 16 ene. 2023 19:50, Adam Weinberger escribi=C3= =B3: > > > On Mon, Jan 16, 2023 at 5:48 AM Fernando Apestegu=C3=ADa > wrote: > >> The branch main has been updated by fernape: >> >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=3D38e6e935efa67110ba6d2d1e3225= 55f0afbb8383 >> >> commit 38e6e935efa67110ba6d2d1e322555f0afbb8383 >> Author: Fernando Apestegu=C3=ADa >> AuthorDate: 2023-01-15 19:29:38 +0000 >> Commit: Fernando Apestegu=C3=ADa >> CommitDate: 2023-01-16 12:44:02 +0000 >> >> dns/unbound: add dynlib port option >> > >> PR: 268942 >> Reported by: me@rcm.sh >> Approved by: jaap@NLnetLabs.nl (maintainer) >> --- >> dns/unbound/Makefile | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) >> >> > Does this need a pkg-plist change? If the plist is the same with this > option on and off, what is this option actually controlling? > The dynlib option is to build that module into the same daemon: https://unbound.docs.nlnetlabs.nl/en/latest/manpages/unbound.conf.html#dyna= mic-library-module-options > # Adam > > diff --git a/dns/unbound/Makefile b/dns/unbound/Makefile >> index 6d101575fd4f..3e0ad7dcdcc3 100644 >> --- a/dns/unbound/Makefile >> +++ b/dns/unbound/Makefile >> @@ -1,5 +1,6 @@ >> PORTNAME=3D unbound >> DISTVERSION=3D 1.17.1 >> +PORTREVISION=3D 1 >> CATEGORIES=3D dns >> MASTER_SITES=3D https://www.nlnetlabs.nl/downloads/unbound/ >> >> @@ -32,15 +33,16 @@ PORTDOCS=3D CNAME-basedRedirectionDesignNotes.pdf >> CREDITS Changelog \ >> ietf67-design-02.pdf requirements.txt >> >> OPTIONS_DEFINE=3D DEP-RSA1024 DNSCRYPT DNSTAP DOCS DOH >> ECDSA EVAPI \ >> - FILTER_AAAA GOST HIREDIS LIBEVENT MUNIN_PLUGIN >> PYTHON \ >> - SUBNET TFOCL TFOSE THREADS >> -OPTIONS_DEFAULT=3D DNSCRYPT DOH ECDSA GOST LIBEVENT THREADS >> + DYNLIB FILTER_AAAA GOST HIREDIS LIBEVENT >> MUNIN_PLUGIN \ >> + PYTHON SUBNET TFOCL TFOSE THREADS >> +OPTIONS_DEFAULT=3D DNSCRYPT DOH DYNLIB ECDSA GOST LIBEVENT THREAD= S >> OPTIONS_SUB=3D yes >> >> DEP-RSA1024_DESC=3D Deprecate the use of RSA 1024 keys >> DNSCRYPT_DESC=3D Enable dnscrypt support >> DNSTAP_DESC=3D Enable dnstap logging support >> DOH_DESC=3D Enable DNS-over-HTTPS support >> +DYNLIB_DESC=3D Enable dynamic (shared) library support >> ECDSA_DESC=3D Enable ECDSA (elliptic curve) support (OpenSSL= >=3D >> 1.0) >> EVAPI_DESC=3D (Experimental) pluggable event based libunboun= d >> API support >> FILTER_AAAA_DESC=3D Build with AAAA filter functionality (contrib) >> @@ -63,6 +65,7 @@ DNSTAP_LIB_DEPENDS=3D libfstrm.so:devel/fstr= m \ >> DNSTAP_CONFIGURE_ENABLE=3D dnstap >> DOH_LIB_DEPENDS=3D libnghttp2.so:www/libnghttp2 >> DOH_CONFIGURE_ON=3D --with-libnghttp2 >> +DYNLIB_CONFIGURE_ON=3D --with-dynlibmodule >> ECDSA_CONFIGURE_ENABLE=3D ecdsa >> ECDSA_VARS=3D DEPENDS_ARGS+=3DWITH_ECDSA=3Dyes >> EVAPI_CONFIGURE_ENABLE=3D event-api >> > > > -- > Adam Weinberger > adamw@adamw.org > https://www.adamw.org > --000000000000326c6005f2680b94 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


El lun., 16 ene. 2023 19:50, Adam Weinberger <adamw@adamw.org> escribi=C3=B3:


On M= on, Jan 16, 2023 at 5:48 AM Fernando Apestegu=C3=ADa <fernape@freebsd.o= rg> wrote:
= https://cgit.FreeBSD.org/ports/commit/?id=3D38e6e935efa67110ba6d2d1e322555f= 0afbb8383

commit 38e6e935efa67110ba6d2d1e322555f0afbb8383
Author:=C2=A0 =C2=A0 =C2=A0Fernando Apestegu=C3=ADa <fernape@FreeBSD.org= >
AuthorDate: 2023-01-15 19:29:38 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Fernando Apestegu=C3=ADa <fernape@FreeBSD.org= >
CommitDate: 2023-01-16 12:44:02 +0000

=C2=A0 =C2=A0 dns/unbound: add dynlib port option

=C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0268942
=C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 me@rcm.sh
=C2=A0 =C2=A0 Approved by:=C2=A0 =C2=A0 jaap@NLnetLabs.nl (maintainer)
---
=C2=A0dns/unbound/Makefile | 9 ++++++---
=C2=A01 file changed, 6 insertions(+), 3 deletions(-)


Does this need a pkg-plist change? If the plist is= the same with this option on and off, what is this option actually control= ling?

The dynlib option is to build that module into the same = daemon:



# Adam

diff --git a/dns/unbound/Makefile b/dns/unbound/Makefile
index 6d101575fd4f..3e0ad7dcdcc3 100644
--- a/dns/unbound/Makefile
+++ b/dns/unbound/Makefile
@@ -1,5 +1,6 @@
=C2=A0PORTNAME=3D=C2=A0 =C2=A0 =C2=A0 unbound
=C2=A0DISTVERSION=3D=C2=A0 =C2=A01.17.1
+PORTREVISION=3D=C2=A0 1
=C2=A0CATEGORIES=3D=C2=A0 =C2=A0 dns
=C2=A0MASTER_SITES=3D=C2=A0 https://www.nlnetl= abs.nl/downloads/unbound/

@@ -32,15 +33,16 @@ PORTDOCS=3D=C2=A0 =C2=A0CNAME-basedRedirectionDesignNot= es.pdf CREDITS Changelog \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ietf67-design-02.pd= f requirements.txt

=C2=A0OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 DEP-RSA1024 DNSCRYPT DNSTAP DOCS DOH ECDSA EVAPI \
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0FILTER_AAAA GOST HIREDIS LIBEVENT MUNIN_PLUGIN PYTHON \
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0SUBNET TFOCL TFOSE THREADS
-OPTIONS_DEFAULT=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0DNSCRYPT DOH ECDSA GOST LIBEV= ENT THREADS
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0DYNLIB FILTER_AAAA GOST HIREDIS LIBEVENT MUNIN_PLUGIN \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0PYTHON SUBNET TFOCL TFOSE THREADS
+OPTIONS_DEFAULT=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0DNSCRYPT DOH DYNLIB ECDSA GOS= T LIBEVENT THREADS
=C2=A0OPTIONS_SUB=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0yes

=C2=A0DEP-RSA1024_DESC=3D=C2=A0 =C2=A0 =C2=A0 Deprecate the use of RSA 1024= keys
=C2=A0DNSCRYPT_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Enable dnscrypt sup= port
=C2=A0DNSTAP_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Enable dnstap = logging support
=C2=A0DOH_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Enable DN= S-over-HTTPS support
+DYNLIB_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Enable dynamic (sha= red) library support
=C2=A0ECDSA_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Enable ECDSA (= elliptic curve) support (OpenSSL >=3D 1.0)
=C2=A0EVAPI_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (Experimental)= pluggable event based libunbound API support
=C2=A0FILTER_AAAA_DESC=3D=C2=A0 =C2=A0 =C2=A0 Build with AAAA filter functi= onality (contrib)
@@ -63,6 +65,7 @@ DNSTAP_LIB_DEPENDS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0libfstrm.so:devel/fstrm \
=C2=A0DNSTAP_CONFIGURE_ENABLE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0dnstap
=C2=A0DOH_LIB_DEPENDS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0libnghttp2.so:www/libnghttp2
=C2=A0DOH_CONFIGURE_ON=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 -= -with-libnghttp2
+DYNLIB_CONFIGURE_ON=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--with-dynl= ibmodule
=C2=A0ECDSA_CONFIGURE_ENABLE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 ecdsa
=C2=A0ECDSA_VARS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 DEPENDS_ARGS+=3DWITH_ECDSA=3Dyes
=C2=A0EVAPI_CONFIGURE_ENABLE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 event-api


--
--000000000000326c6005f2680b94--