From nobody Mon Jan 16 18:50:05 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nwh0v424tz2t4SX for ; Mon, 16 Jan 2023 18:50:23 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nwh0v16Z1z3lQl for ; Mon, 16 Jan 2023 18:50:22 +0000 (UTC) (envelope-from adamw@adamw.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x536.google.com with SMTP id v10so40692512edi.8 for ; Mon, 16 Jan 2023 10:50:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=iAMgd2xepppEQpQnYwrcA8b5nmPWoFLbBWCxLRkZSlU=; b=t/KpaikU1A4cjONatF4ZB/ghI5T87F1L/kPofyYE/+fg0pLGhGgZnCiVmazfQjB1TS wmIeDhrrHy6xMdLl3RDTXEiOTTUeBNvdpb45j0XG2XXWc9eg9AEQVKH8Y30PnTmE4Naa YpTHPwyXWDfZmGM8yyua8gGP2X8ztHWgNplEGzFKWM/ExDbKXwHdcCfMnLI6OER84964 CJbwQthGoKM/lDEcUyX/Qgz0XFG6OVGMoe29Hf6yULu0kyFNXFtHtTvwDMoP7I28P2W9 /PMkaaRPnHP2gWhGfogOPbnM0OAz0UJ9wFP/Lwv/136WuMflCjgqUfkTffKS3yc6qtfa RZNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iAMgd2xepppEQpQnYwrcA8b5nmPWoFLbBWCxLRkZSlU=; b=1E3XBHHCIfHO7n0KmJQPYrEbo8uTeKc9DX5G2iAvy9Pwo6Rq7pYnp2ct0NH/p8N3W3 el1HHtEXK/Z+TW4w0399+788KdOCtzNASm21a+wRi4nOcsENNB2dKD3UcVKQovzWWTm7 ub+jljiZ1y+csLszN496/Qchz9R7KwUJMMb89nUDGURo/mQ2ZW7jUEMBOD5OTXnYgIrw xLiWQM4skYi8NfEG19xPjqJZfeQbmt+pOaIEqa9/0jE8Vd11l93jJTyAlK9oNu3YCfcX Q1UT8IsefoXn1HJv3TOj3rfTH5Ly+41gQ8YUGTtbV7PgpmywhqxiRh4hbb1Rd0do4W3i hDtw== X-Gm-Message-State: AFqh2krWJmcgjDVlBwsq1SwuKvvAgFVWVgNocVQrr5n+j2SfJNvxmsHI 3DhEDcLrADV2fanAPlepDRrV5VYrcAKs+kmOCmmw0Q== X-Google-Smtp-Source: AMrXdXt0se45L+pmLMRYrDXyI2DK12czjkTR5Ovodw3kO8Jx4Pfiww0Nfrsog6c++RPsz6HLXHX9BiHXD8tyluGA31U= X-Received: by 2002:aa7:c9cf:0:b0:499:c265:752a with SMTP id i15-20020aa7c9cf000000b00499c265752amr32093edt.257.1673895021609; Mon, 16 Jan 2023 10:50:21 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202301161248.30GCmHnK091914@gitrepo.freebsd.org> In-Reply-To: <202301161248.30GCmHnK091914@gitrepo.freebsd.org> From: Adam Weinberger Date: Mon, 16 Jan 2023 11:50:05 -0700 Message-ID: Subject: Re: git: 38e6e935efa6 - main - dns/unbound: add dynlib port option To: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000027987d05f2660e4e" X-Rspamd-Queue-Id: 4Nwh0v16Z1z3lQl X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --00000000000027987d05f2660e4e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 16, 2023 at 5:48 AM Fernando Apestegu=C3=ADa wrote: > The branch main has been updated by fernape: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3D38e6e935efa67110ba6d2d1e32255= 5f0afbb8383 > > commit 38e6e935efa67110ba6d2d1e322555f0afbb8383 > Author: Fernando Apestegu=C3=ADa > AuthorDate: 2023-01-15 19:29:38 +0000 > Commit: Fernando Apestegu=C3=ADa > CommitDate: 2023-01-16 12:44:02 +0000 > > dns/unbound: add dynlib port option > > PR: 268942 > Reported by: me@rcm.sh > Approved by: jaap@NLnetLabs.nl (maintainer) > --- > dns/unbound/Makefile | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > Does this need a pkg-plist change? If the plist is the same with this option on and off, what is this option actually controlling? # Adam diff --git a/dns/unbound/Makefile b/dns/unbound/Makefile > index 6d101575fd4f..3e0ad7dcdcc3 100644 > --- a/dns/unbound/Makefile > +++ b/dns/unbound/Makefile > @@ -1,5 +1,6 @@ > PORTNAME=3D unbound > DISTVERSION=3D 1.17.1 > +PORTREVISION=3D 1 > CATEGORIES=3D dns > MASTER_SITES=3D https://www.nlnetlabs.nl/downloads/unbound/ > > @@ -32,15 +33,16 @@ PORTDOCS=3D CNAME-basedRedirectionDesignNotes.pdf > CREDITS Changelog \ > ietf67-design-02.pdf requirements.txt > > OPTIONS_DEFINE=3D DEP-RSA1024 DNSCRYPT DNSTAP DOCS DOH EC= DSA > EVAPI \ > - FILTER_AAAA GOST HIREDIS LIBEVENT MUNIN_PLUGIN > PYTHON \ > - SUBNET TFOCL TFOSE THREADS > -OPTIONS_DEFAULT=3D DNSCRYPT DOH ECDSA GOST LIBEVENT THREADS > + DYNLIB FILTER_AAAA GOST HIREDIS LIBEVENT > MUNIN_PLUGIN \ > + PYTHON SUBNET TFOCL TFOSE THREADS > +OPTIONS_DEFAULT=3D DNSCRYPT DOH DYNLIB ECDSA GOST LIBEVENT THREADS > OPTIONS_SUB=3D yes > > DEP-RSA1024_DESC=3D Deprecate the use of RSA 1024 keys > DNSCRYPT_DESC=3D Enable dnscrypt support > DNSTAP_DESC=3D Enable dnstap logging support > DOH_DESC=3D Enable DNS-over-HTTPS support > +DYNLIB_DESC=3D Enable dynamic (shared) library support > ECDSA_DESC=3D Enable ECDSA (elliptic curve) support (OpenSSL = >=3D > 1.0) > EVAPI_DESC=3D (Experimental) pluggable event based libunbound > API support > FILTER_AAAA_DESC=3D Build with AAAA filter functionality (contrib) > @@ -63,6 +65,7 @@ DNSTAP_LIB_DEPENDS=3D libfstrm.so:devel/fstrm= \ > DNSTAP_CONFIGURE_ENABLE=3D dnstap > DOH_LIB_DEPENDS=3D libnghttp2.so:www/libnghttp2 > DOH_CONFIGURE_ON=3D --with-libnghttp2 > +DYNLIB_CONFIGURE_ON=3D --with-dynlibmodule > ECDSA_CONFIGURE_ENABLE=3D ecdsa > ECDSA_VARS=3D DEPENDS_ARGS+=3DWITH_ECDSA=3Dyes > EVAPI_CONFIGURE_ENABLE=3D event-api > --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org --00000000000027987d05f2660e4e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


<= div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jan 16, 2023 at 5:48 AM Fernan= do Apestegu=C3=ADa <fernape@freeb= sd.org> wrote:
The branch main has been updated by fernape:

URL: https://cgi= t.FreeBSD.org/ports/commit/?id=3D38e6e935efa67110ba6d2d1e322555f0afbb8383

commit 38e6e935efa67110ba6d2d1e322555f0afbb8383
Author:=C2=A0 =C2=A0 =C2=A0Fernando Apestegu=C3=ADa <fernape@FreeBSD.org= >
AuthorDate: 2023-01-15 19:29:38 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Fernando Apestegu=C3=ADa <fernape@FreeBSD.org= >
CommitDate: 2023-01-16 12:44:02 +0000

=C2=A0 =C2=A0 dns/unbound: add dynlib port option

=C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0268942
=C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 me@rcm.sh
=C2=A0 =C2=A0 Approved by:=C2=A0 =C2=A0 jaap@NLnetLabs.nl (maintainer)
---
=C2=A0dns/unbound/Makefile | 9 ++++++---
=C2=A01 file changed, 6 insertions(+), 3 deletions(-)


Does this need a pkg-plist change? If the plist is= the same with this option on and off, what is this option actually control= ling?

# Adam

diff --git a/dns/unbound/Makefile b/dns/unbound/Makefile
index 6d101575fd4f..3e0ad7dcdcc3 100644
--- a/dns/unbound/Makefile
+++ b/dns/unbound/Makefile
@@ -1,5 +1,6 @@
=C2=A0PORTNAME=3D=C2=A0 =C2=A0 =C2=A0 unbound
=C2=A0DISTVERSION=3D=C2=A0 =C2=A01.17.1
+PORTREVISION=3D=C2=A0 1
=C2=A0CATEGORIES=3D=C2=A0 =C2=A0 dns
=C2=A0MASTER_SITES=3D=C2=A0 https://www.nlnetlabs.nl/down= loads/unbound/

@@ -32,15 +33,16 @@ PORTDOCS=3D=C2=A0 =C2=A0CNAME-basedRedirectionDesignNot= es.pdf CREDITS Changelog \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ietf67-design-02.pd= f requirements.txt

=C2=A0OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 DEP-RSA1024 DNSCRYPT DNSTAP DOCS DOH ECDSA EVAPI \
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0FILTER_AAAA GOST HIREDIS LIBEVENT MUNIN_PLUGIN PYTHON \
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0SUBNET TFOCL TFOSE THREADS
-OPTIONS_DEFAULT=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0DNSCRYPT DOH ECDSA GOST LIBEV= ENT THREADS
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0DYNLIB FILTER_AAAA GOST HIREDIS LIBEVENT MUNIN_PLUGIN \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0PYTHON SUBNET TFOCL TFOSE THREADS
+OPTIONS_DEFAULT=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0DNSCRYPT DOH DYNLIB ECDSA GOS= T LIBEVENT THREADS
=C2=A0OPTIONS_SUB=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0yes

=C2=A0DEP-RSA1024_DESC=3D=C2=A0 =C2=A0 =C2=A0 Deprecate the use of RSA 1024= keys
=C2=A0DNSCRYPT_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Enable dnscrypt sup= port
=C2=A0DNSTAP_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Enable dnstap = logging support
=C2=A0DOH_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Enable DN= S-over-HTTPS support
+DYNLIB_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Enable dynamic (sha= red) library support
=C2=A0ECDSA_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Enable ECDSA (= elliptic curve) support (OpenSSL >=3D 1.0)
=C2=A0EVAPI_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (Experimental)= pluggable event based libunbound API support
=C2=A0FILTER_AAAA_DESC=3D=C2=A0 =C2=A0 =C2=A0 Build with AAAA filter functi= onality (contrib)
@@ -63,6 +65,7 @@ DNSTAP_LIB_DEPENDS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0libfstrm.so:devel/fstrm \
=C2=A0DNSTAP_CONFIGURE_ENABLE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0dnstap
=C2=A0DOH_LIB_DEPENDS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0libnghttp2.so:www/libnghttp2
=C2=A0DOH_CONFIGURE_ON=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 -= -with-libnghttp2
+DYNLIB_CONFIGURE_ON=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--with-dynl= ibmodule
=C2=A0ECDSA_CONFIGURE_ENABLE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 ecdsa
=C2=A0ECDSA_VARS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 DEPENDS_ARGS+=3DWITH_ECDSA=3Dyes
=C2=A0EVAPI_CONFIGURE_ENABLE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 event-api


--
--00000000000027987d05f2660e4e--