From nobody Tue Feb 28 19:32:22 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PR6vY3d4tz3tr5V; Tue, 28 Feb 2023 19:32:25 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PR6vY3BpXz3sY3; Tue, 28 Feb 2023 19:32:25 +0000 (UTC) (envelope-from mandree@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677612745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aRsPjdQ/7eV4BbST0NSkSVAD7YWxyjYcIcLJzVhmUX8=; b=bRtC8kHOEMWLHXD4VOUxiRGKcYJ1dzQ+KcFfPthk6kUYeOzlMu+NWa4NNwJ+pLClHarIMy u2XboowBWnTA7W1dHO1A4d011UEK+TH2WQHTwQ4uz9Qpg33lppwSIu9WmL3ds5Wy4dlc2l UMRJcdpgKOpmW0T2XMU9JZ5FGkEVPjOuoVMHQk1yG/3tIngq/NjA2QPknXtPFcZ7Gkc9bx AAEVvcjk9YrIvgTaQI5gyu2x70qDOvNAQALt0beWF5lhSwMlvODTw00ALOdNrGap9s+y6y PJaE5ivlLEAdVBEFRsy9eJ2ik/fsqMjG548gd+Sx2AgkZ27lLskHNqZfJ3qsMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677612745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aRsPjdQ/7eV4BbST0NSkSVAD7YWxyjYcIcLJzVhmUX8=; b=vDa2Z+3b/F/8FN35y58p6+6j/28A30WkB1u9ok7jcxnxQ62nKbdCmbDQiqGW2ZO2I4k53i tDW83onK4LMigcc32ECjylO/McomOoz4vKS9ZwFjJ6VmNTAQ4bVlNwnL5ymBuDx2251qw+ 201X5LN19QFXfbwBNstjIKJxa5wMODFJsvmuXkVoAIQCwu0TW+jcqDLsDB+edJDzozHtI+ 4crlCaXetUJeUpTA7c9j6Z1ggVzBacNQpVVaL8qREcr0X2JnA4Qw1lg83AHRdHy4jo7+Ct 2MpsawU0HfvwpXHmM5If3tXx2VEjeGITzfnp1l+qgDIvG/ZtVwahnbGBsz9wAg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677612745; a=rsa-sha256; cv=none; b=Ubkih9+DL5cOJPq5Y9h7iPMn9YQ0qys8B4W8A8IOiT2/n3bXTK5GIOCFRPXToS5EVv3WDY E/kfCXhuO/oQ23vslc/Lh6W3gSK6pSh/YIWfLInjUOCsndo0H+F1rt1elDDtby49Tj4ErF S5WDqySSCUoNJmSsauT57pPD111B6gAB5cRdiNB+i1SecIqxx2BF0vlZzmvE28ovOu9Zt8 cMgL8++Zhs2UhdwN0W9Uf8i3jdFl877MNZ/agt9RdL0CnHDZNSoxsiH2dB1Xo28pM54RvJ 01iLWVVXKd5+CbcXf3eLRBjWIF87pNDz26qzI8yUdAKa3DrwT95FfDApwAx2xw== Received: from mandree.no-ip.org (p54a03c23.dip0.t-ipconnect.de [84.160.60.35]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mandree/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PR6vY1S6HzdH6; Tue, 28 Feb 2023 19:32:25 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from [127.0.0.1] (localhost [127.0.0.1]) by ryzen.an3e.de (Postfix) with ESMTP id E9EE8CF0830; Tue, 28 Feb 2023 20:32:22 +0100 (CET) Message-ID: Date: Tue, 28 Feb 2023 20:32:22 +0100 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Matthias Andree Content-Language: en-US To: Baptiste Daroussin , Charlie Li , "Tobias C. Berner" Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202302272105.31RL593a014619@gitrepo.freebsd.org> <20230228075455.b7otamo7ezahtqxi@aniel.nours.eu> Organization: FreeBSD.org Subject: Re: git: a9d9d3a42723 - main - lang/python: Revert "add bytecode trigger" In-Reply-To: <20230228075455.b7otamo7ezahtqxi@aniel.nours.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N Am 28.02.23 um 08:54 schrieb Baptiste Daroussin: > On Mon, Feb 27, 2023 at 09:05:09PM +0000, Matthias Andree wrote: >> The branch main has been updated by mandree: >> >> URL: https://cgit.FreeBSD.org/ports/commit/?id=a9d9d3a4272303bf226b9deb55c42303e4fcebdc >> >> commit a9d9d3a4272303bf226b9deb55c42303e4fcebdc >> Author: Matthias Andree >> AuthorDate: 2023-02-27 21:01:32 +0000 >> Commit: Matthias Andree >> CommitDate: 2023-02-27 21:04:52 +0000 >> >> lang/python: Revert "add bytecode trigger" >> >> This reverts commit c17ddfbf66e2801ec620d49979aca3d7077d7002. >> >> This causes breakage on several ports, and the next iteration >> requires a full exp-run. See: >> >> Differential Revision: https://reviews.freebsd.org/D34739 > > This is not how this is supposed to be done! while you have a point about the > issue and the full exp-run, the issue is easily fixable, you should have let > time to the committer to revert by himself, by asking him to revert instead of > abruply reverting! > > Best regards, > Bapt Am 28.02.23 um 06:44 schrieb Tobias C. Berner: > Moin moin > > So you reverted the first major change to the python framework in ages > due to a leaf-port breakin non-fatally? > This looks a little bit like overstepping the bounds of good taste a bit to me. Baptiste, Tobias, First, let's get the timeline straight: Feb 15, Charlie commits. Feb 18, Antoine claims the bug via mailing list. Feb 18, Mathieu asks why this was committed without prior -exp run, via reviews.freebsd.org - silence - Feb 27, Matthias (yours truly) reverts that breaking change Feb 27 - 28, people pick at Matthias with emotional and non-technical reasons which are all besides the factual point. There was NO acknowledgment of the bug, no hint that anyone was working, and we had broken sphinx and breathe ports, so we needed to fix things. Then, half of the messages on IRC, mailing list, and the reviews were also non-technical, attacking me instead of the bug in Charlie's stuff and revealing who was getting touchy. All in all, can we now please stop confusing cause and effect, and can those who have been touchy now please grow up? Thanks everyone. -- Matthias Andree FreeBSD ports committer