From nobody Sat Feb 18 22:11:59 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PK2yn6rYTz3rxf9; Sat, 18 Feb 2023 22:14:09 +0000 (UTC) (envelope-from bofh@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PK2yn6ND4z3mBT; Sat, 18 Feb 2023 22:14:09 +0000 (UTC) (envelope-from bofh@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676758449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cJi8NYYO9QmBL8/qYVyrqIJcWCwm/FHTI9sCU0HvW14=; b=rjIt7w6qhYhV+nloK+IHazU/qPiKq97oVAuuIgl3uehyY9WzpKenn1cATZBkF+GEuF91K2 9hnF+64DfZe/vsnqVd+wdim9blQALzhaZO4cpCVteqDzttWLtQQ2vEg79vwGb5J2/Z2O3o oeiLptBADHGOK0rONu39A6eIvmq4ofhEAZMFpdX1zPH8/SIreFt2uk6+CWP9+AkhSx0+Pa dwdnS4S/R9bK+iod39ZHa+7qW/XML2StDeUUH/gB2F2H0gVSvofFBVrvgap5bhQntFfZXQ 9AI2eUUuuTJf1O/99qHxj1TyAzroib6xoBOGZh5t3d42+WwYSsI4lkdgbv4Oig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676758449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cJi8NYYO9QmBL8/qYVyrqIJcWCwm/FHTI9sCU0HvW14=; b=dyfDBuv3qoZ2GnBdpc1mRSKIFbeHKwQ2/QR6YznXDG8glAH4aupwuObrfab+r2k6QY0G0+ wAoLSdV4yCs4vSGFpl9z+UHWheSJks7MIxskHIbRRt81ovV5KXbHEp7j5OsCmsDH8aYFmk kXAawFWak9y66PpFGk48/1x4JQIOwLZ+t3v5VgAu+av6XbtCodiilySs3sjGMU/A8rdkMc S3wY0E/BVn+35B75Ybm5OUhszJxnBnxgnHZH8V/SS5I/f9uNrE/GBLQSusDRP0avHnMRWK 2O88HDUETNHOFHggJVtN4r7hrhC42fnknJdXfbjNXeOq2X/FfM9RHv48SwPk3g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676758449; a=rsa-sha256; cv=none; b=LzF/jiTNBvCYY9mFktp5ZjKMnKqWfy2dcA1WwOfav1E1Y3IegtWp4B7L5dMwsX8oLgKpnV V5owkseHfsgIm2lMdo9LKzkTAl1znKMsEBvY0+Z1eefqbyGDnD7s4Boj61qgvXDSQt4wZM FlM+bO9kekYn3ZLmyRBJWBmIyMsgXBIAA9t9iGXFuaEhblccNH6RBK/Mrdrxds8HyHGqwr eFjeu10hRdzci9QLuuPo2rkz0pI16Q2XmtMc6h4/H+CMe49GP633bh8pP5xTV+Mtsl1sOJ PIa3rK3+ogfWK9cP1RJUNX5qm9DIpzMyKVhpG1bc3DhFwuKL5L2MnXiBXXRHqw== Received: from mx.bofh.network (mx.bofh.network [IPv6:2a0d:2787:2::28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.bofh.network", Issuer "R3" (verified OK)) (Authenticated sender: bofh/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PK2yn1hXXzLyY; Sat, 18 Feb 2023 22:14:09 +0000 (UTC) (envelope-from bofh@freebsd.org) Received: from smtpclient.apple (unn-169-150-218-6.datapacket.com [169.150.218.6]) by mx.bofh.network (OpenSMTPD) with ESMTPSA id b315c010 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sat, 18 Feb 2023 22:14:08 +0000 (UTC) Content-Type: multipart/signed; boundary="Apple-Mail=_ACCE3B31-1230-4660-9CB6-8A2AA3B255BB"; protocol="application/pgp-signature"; micalg=pgp-sha512 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 1c1e0975ade6 - main - databases/mysql-connector-odbc: remove expired port From: Moin Rahman In-Reply-To: Date: Sat, 18 Feb 2023 23:11:59 +0100 Cc: "ports-committers@freebsd.org" , "dev-commits-ports-all@freebsd.org" , "dev-commits-ports-main@freebsd.org" Message-Id: <95E651CF-5C8F-4D17-8AC5-44E9C35E4963@freebsd.org> References: <202302182007.31IK7JWK071189@gitrepo.freebsd.org> To: Antoine Brodin X-Mailer: Apple Mail (2.3696.120.41.1.1) X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_ACCE3B31-1230-4660-9CB6-8A2AA3B255BB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Feb 18, 2023, at 11:03 PM, Antoine Brodin = wrote: >=20 > On Sat, Feb 18, 2023 at 10:01 PM Moin Rahman wrote: >>=20 >> Unless you are confused or watching the logs of mysql exp-run for = changing the default version this is not correct. >>=20 >> Just for the sake of the conversation I have rebuilt the ports with = now mysql 5.7 as default and here are the results: >> = https://pdr.bofh.network/data/latest-per-pkg/mysql-connector-odbc-unixodbc= -mysql57/5.3.14/123-default.log >> = https://pdr.bofh.network/data/latest-per-pkg/mysql-connector-odbc-unixodbc= -mysql57/5.3.14/123i386-default.log >> = https://pdr.bofh.network/data/latest-per-pkg/mysql-connector-odbc-unixodbc= -mysql57/5.3.14/131-default.log >>=20 >> And neither do I see any PKGBASE conflicts: >> cd databases/mysql-connector-odbc && make -v PKGBASE >> cd databases/mysql-connector-odbc-80 && = mysql-connector-odbc-unixodbc-mysql57 >> make -v PKGBASE >> mysql-connector-odbc-unixodbc-mysql80 >>=20 >> Please revert. >=20 > The default version of mysql switched to mysql 8.0 so there is a > PKGBASE conflict. > I think mysql-connector-odbc should have used USES=3Dmysql:somever That does not imply that you have to remove this. > Antoine >=20 >>> On Feb 18, 2023, at 9:40 PM, Antoine Brodin = wrote: >>>=20 >>> On Sat, Feb 18, 2023 at 8:16 PM Moin Rahman = wrote: >>>>=20 >>>> Why did you expire this port? This is marked to expire on = 2012-12-31. >>>=20 >>> It has not been built for months (ignored) and its PKGBASE now >>> collides with mysql-connector-odbc-80. >>>=20 >>> Antoine >>>=20 >>>> On Feb 18, 2023, at 9:07 PM, Antoine Brodin = wrote: >>>>=20 >>>> The branch main has been updated by antoine: >>>>=20 >>>> URL: = https://cgit.FreeBSD.org/ports/commit/?id=3D1c1e0975ade679a1f13c10709cf443= bc82dde3b9 >>>>=20 >>>> commit 1c1e0975ade679a1f13c10709cf443bc82dde3b9 >>>> Author: Antoine Brodin >>>> AuthorDate: 2023-02-18 20:06:29 +0000 >>>> Commit: Antoine Brodin >>>> CommitDate: 2023-02-18 20:06:29 +0000 >>>>=20 >>>> databases/mysql-connector-odbc: remove expired port >>>> --- >>>> MOVED | 1 + >>>> databases/Makefile | 1 - >>>> databases/mysql-connector-odbc/Makefile | 38 = ---------------------- >>>> databases/mysql-connector-odbc/distinfo | 3 -- >>>> .../files/patch-CMakeLists.txt | 30 = ----------------- >>>> .../mysql-connector-odbc/files/patch-driver_dll.cc | 11 ------- >>>> .../files/patch-driver_handle.cc | 11 ------- >>>> databases/mysql-connector-odbc/pkg-descr | 1 - >>>> 8 files changed, 1 insertion(+), 95 deletions(-) >>>>=20 >>>> diff --git a/MOVED b/MOVED >>>> index bfe2d1dcb026..6823b3c2e314 100644 >>>> --- a/MOVED >>>> +++ b/MOVED >>>> @@ -17765,3 +17765,4 @@ = x11/plasma5-kwayland-server|x11-wm/plasma5-kwin|2023-02-07|Reintegrated = into x11 >>>> finance/py-TA-Lib|finance/py-ta-lib|2023-02-12|Remove duplicate = port >>>> x11-toolkits/gnocl||2023-02-13|Fails to build, newer snapshot = depends on a removed port >>>> games/opendungeons||2023-02-14|Has expired: Broken for more than 6 = months >>>> = +databases/mysql-connector-odbc|databases/mysql-connector-odbc-80|2023-02-= 18|Has expired: Requires EOLd mysql version >>>> diff --git a/databases/Makefile b/databases/Makefile >>>> index 3a6cbb867cc9..598e34d376ae 100644 >>>> --- a/databases/Makefile >>>> +++ b/databases/Makefile >>>> @@ -204,7 +204,6 @@ >>>> SUBDIR +=3D mysql-connector-c++ >>>> SUBDIR +=3D mysql-connector-java >>>> SUBDIR +=3D mysql-connector-java51 >>>> - SUBDIR +=3D mysql-connector-odbc >>>> SUBDIR +=3D mysql-connector-odbc-80 >>>> SUBDIR +=3D mysql-q4m >>>> SUBDIR +=3D mysql-udf >>>> diff --git a/databases/mysql-connector-odbc/Makefile = b/databases/mysql-connector-odbc/Makefile >>>> deleted file mode 100644 >>>> index b61392aee08b..000000000000 >>>> --- a/databases/mysql-connector-odbc/Makefile >>>> +++ /dev/null >>>> @@ -1,38 +0,0 @@ >>>> -PORTNAME=3D mysql-connector-odbc >>>> -PORTVERSION=3D 5.3.14 >>>> -CATEGORIES=3D databases >>>> -MASTER_SITES=3D MYSQL/Connector-ODBC/5.3 >>>> -PKGNAMESUFFIX=3D -${DRIVER_MANAGER}-mysql${MYSQL_VER} >>>> -DISTNAME=3D ${PORTNAME}-${PORTVERSION}-src >>>> - >>>> -MAINTAINER=3D bofh@FreeBSD.org >>>> -COMMENT=3D ODBC driver for MySQL${MYSQL_VER} / ${DRIVER_MANAGER} >>>> -WWW=3D https://www.mysql.com/ >>>> - >>>> -LICENSE=3D GPLv2 >>>> -LICENSE_FILE=3D ${WRKSRC}/LICENSE.txt >>>> - >>>> -DEPRECATED=3D Requires EOLd mysql version >>>> -EXPIRATION_DATE=3D 2023-12-31 >>>> - >>>> -LIB_DEPENDS=3D libodbc.so:databases/unixODBC >>>> - >>>> -USES=3D cmake compiler:c++11-lang localbase:ldflags mysql ssl >>>> -IGNORE_WITH_MYSQL=3D 101m 102m 103m 57p 57w 80 >>>> -USE_LDCONFIG=3D yes >>>> - >>>> -CMAKE_ARGS=3D -DDISABLE_GUI=3D1 \ >>>> - -DWITH_UNIXODBC=3D1 >>>> - >>>> -MAKE_JOBS_UNSAFE=3D yes >>>> - >>>> -DRIVER_MANAGER=3D unixodbc >>>> - >>>> -PLIST_FILES=3D bin/myodbc-installer \ >>>> - lib/libmyodbc5a.so \ >>>> - lib/libmyodbc5w.so >>>> -PORTDOCS=3D * >>>> - >>>> -OPTIONS_DEFINE=3D DOCS >>>> - >>>> -.include >>>> diff --git a/databases/mysql-connector-odbc/distinfo = b/databases/mysql-connector-odbc/distinfo >>>> deleted file mode 100644 >>>> index 702e816bc4ff..000000000000 >>>> --- a/databases/mysql-connector-odbc/distinfo >>>> +++ /dev/null >>>> @@ -1,3 +0,0 @@ >>>> -TIMESTAMP =3D 1675364196 >>>> -SHA256 (mysql-connector-odbc-5.3.14-src.tar.gz) =3D = 302d068ef0d8e1e9ada6e42e48c149151d4b722f9317efb106f801e483e74a7f >>>> -SIZE (mysql-connector-odbc-5.3.14-src.tar.gz) =3D 3010166 >>>> diff --git = a/databases/mysql-connector-odbc/files/patch-CMakeLists.txt = b/databases/mysql-connector-odbc/files/patch-CMakeLists.txt >>>> deleted file mode 100644 >>>> index f184b2a0e6f4..000000000000 >>>> --- a/databases/mysql-connector-odbc/files/patch-CMakeLists.txt >>>> +++ /dev/null >>>> @@ -1,30 +0,0 @@ >>>> ---- CMakeLists.txt.orig 2019-04-15 16:56:34 UTC >>>> -+++ CMakeLists.txt >>>> -@@ -431,7 +431,6 @@ ENDIF(NOT DISABLE_GUI) >>>> - >>>> - ADD_SUBDIRECTORY(dltest) >>>> - ADD_SUBDIRECTORY(installer) >>>> --ADD_SUBDIRECTORY(test) >>>> - >>>> - # For dynamic linking use the built-in sys and strings >>>> - IF(NOT MYSQLCLIENT_STATIC_LINKING) >>>> -@@ -501,8 +500,8 @@ cmake/sql.*\\\\.c$ >>>> - #------------ Installation --------------------------- >>>> - >>>> - >>>> --INSTALL(FILES LICENSE.txt DESTINATION .) >>>> --INSTALL(FILES README.txt DESTINATION .) >>>> -+INSTALL(FILES LICENSE.txt DESTINATION = ./share/doc/mysql-connector-odbc/) >>>> -+INSTALL(FILES README.txt DESTINATION = ./share/doc/mysql-connector-odbc/) >>>> - >>>> - IF(WIN32) >>>> - >>>> -@@ -542,7 +541,7 @@ IF(WIN32) >>>> - >>>> - ELSE(WIN32) >>>> - >>>> -- INSTALL(FILES ChangeLog DESTINATION .) >>>> -+ INSTALL(FILES ChangeLog DESTINATION = ./share/doc/mysql-connector-odbc/) >>>> - >>>> - ENDIF(WIN32) >>>> - >>>> diff --git = a/databases/mysql-connector-odbc/files/patch-driver_dll.cc = b/databases/mysql-connector-odbc/files/patch-driver_dll.cc >>>> deleted file mode 100644 >>>> index b69ce6b9e812..000000000000 >>>> --- a/databases/mysql-connector-odbc/files/patch-driver_dll.cc >>>> +++ /dev/null >>>> @@ -1,11 +0,0 @@ >>>> ---- driver/dll.cc.orig 2019-04-15 16:56:34 UTC >>>> -+++ driver/dll.cc >>>> -@@ -125,7 +125,7 @@ void myodbc_end() >>>> - This eliminates the delay when mysys_end() is called and = other threads >>>> - have been initialized but not ended. >>>> - */ >>>> -- my_thread_end_wait_time=3D 0; >>>> -+ static uint my_thread_end_wait_time=3D 0; >>>> - #endif >>>> - >>>> - /* >>>> diff --git = a/databases/mysql-connector-odbc/files/patch-driver_handle.cc = b/databases/mysql-connector-odbc/files/patch-driver_handle.cc >>>> deleted file mode 100644 >>>> index 3a12e522fa4e..000000000000 >>>> --- a/databases/mysql-connector-odbc/files/patch-driver_handle.cc >>>> +++ /dev/null >>>> @@ -1,11 +0,0 @@ >>>> ---- driver/handle.cc.orig 2019-04-15 16:56:34 UTC >>>> -+++ driver/handle.cc >>>> -@@ -646,7 +646,7 @@ SQLRETURN SQL_API = my_SQLFreeStmtExtended(SQLHSTMT hstm >>>> - #if MYSQL_VERSION_ID >=3D 50722 && MYSQL_VERSION_ID < 80000 >>>> - if (stmt->result !=3D NULL >>>> - #else >>>> -- if((stmt->result !=3D NULL) && (stmt->result->field_alloc = !=3D NULL) >>>> -+ if((stmt->result !=3D NULL) && (&stmt->result->field_alloc = !=3D NULL) >>>> - #if (!MYSQLCLIENT_STATIC_LINKING || !MYSQL8) >>>> - && (stmt->result->field_alloc.pre_alloc !=3D NULL ) >>>> - #endif >>>> diff --git a/databases/mysql-connector-odbc/pkg-descr = b/databases/mysql-connector-odbc/pkg-descr >>>> deleted file mode 100644 >>>> index 0441dd6a5d7f..000000000000 >>>> --- a/databases/mysql-connector-odbc/pkg-descr >>>> +++ /dev/null >>>> @@ -1 +0,0 @@ >>>> -MySQL Connector ODBC is an ODBC driver for interfacing to MySQL = databases. --Apple-Mail=_ACCE3B31-1230-4660-9CB6-8A2AA3B255BB Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEETfdREoUGjQZKBS+fvbm1phfAvJEFAmPxTS9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDRE Rjc1MTEyODUwNjhEMDY0QTA1MkY5RkJEQjlCNUE2MTdDMEJDOTEACgkQvbm1phfA vJFeGw//drhunwpeF+gOfYGLbmrBuAjNcICrSSGgCyL1e2UzG4Q8Hr03biPW1jkm RfDEhbIpCVlYp2D0/X2Qy8WOYq8Q67tgNH4XgPnPi+sFRS4HvwzzRYMUphUG9QQF wqMhnU5gSawgG9Q09MpT56LP/kfTVx6mujBvWPCy9RiQU7qbA9FhOwNrpq5jgxOP I0nkpijVpuGNdaJ/axugeSL+RaKfIE1fPXLVDGDnWwYYzChadyIEqCam2104sR1i U1eDh8QzxgvzHz7a5s5T++D3OFp82dO84iy1br7nFU9MH3potO0SGv+4PRs7znry VpNwiqNEvpvDDCJfvcFGvB+ParbG3idf3fGQyvInoHiv5Au3sqbiMY6w+OS9DHSA m2oTw0D54YVuzjZ6By9RUmlKKesgJWbqPTcNeEjFdm19AQrFsFLhJhy8nhkHVV3D NEHOrblEn+DXmoQlx+nNLATC6tSWiv3HPKV4TtfWP0IxD2N4jMRdB/ZtkgBmvOX7 EbP5/8uhHch7gFxphl7RslYq3vujHTVvvrpMtbw1vEKRqLHMHb+sBLtShv1BOfOo pIg6mtVHlw0AeZW6FEG4PtHaJvZg/4UXWiBxy8mv3sOeBU0WcGjLNfdPD2v3fUXn LY+Fx5QorWEDgQfi7Zb/ywVgP2pF5/d0DIRNp+9ef2NDOXBBZOw= =GMw0 -----END PGP SIGNATURE----- --Apple-Mail=_ACCE3B31-1230-4660-9CB6-8A2AA3B255BB--