From nobody Tue Feb 14 09:48:01 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PGGbl1rFKz3rTkK; Tue, 14 Feb 2023 09:48:03 +0000 (UTC) (envelope-from ehaupt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PGGbl1KC4z3QKS; Tue, 14 Feb 2023 09:48:03 +0000 (UTC) (envelope-from ehaupt@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676368083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9PA2jdTou09AD6btxnRQwC5B8Oel2M3qJXOXChL3dsA=; b=SJJ39D0P3RNqZUdTJBnthF2bSquwNiJe5p7FTnWH+hzG/mYd1a5r0HQTXLx0VGR9vf+/by 6ufKXo4Z7rM6jnQAbzNLYlEPw4s+YqdbS5HdtQvW/atIovmA1nGV30c0ns9a2moVxuho4m U3xRSo/7Yo8nZkYzTCVLrAodS3Imu3+1oXg3ZYSUMbzsKHo5v5dEXizjoAKSPCZF8GX5Tr fe4I6OdtHomXYs59aWk7Nm8VEniuPv/CoUNwyccC6HtLVMkfJiE8N0Zk/naFHO/5PxcEvJ iVbfMUwW6cdqxEVBJGc+HncD1bLnjQEhzSyWPWMXUIT5IWxaz2I1jsb5kn6Rag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676368083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9PA2jdTou09AD6btxnRQwC5B8Oel2M3qJXOXChL3dsA=; b=JaxDCSQG6ICBTnGJzmDgZJOa1UpaONSfkTkz0AH1JQXCW+zlnn2m1hy1JcEjIK6hdfefm7 eUin6pikmki2w3+FmcbUGMmp4T+ar9tVk7KZTjEWgbyqKsuCyZwRCzzmCpHbBl5Zliy+/h /VIAouiM/5bDKMpUPojI3lMxWEJeU4sISqIJu4YyAlQxphZ6k3WdkGxJQy2iQfsRWvzKyH nDVKmbNrt4JHz0prZMxNlQiXAetrBEYqUOOjBxjWW0SJVyxINwonXGBbSjwWiUhrHuXy7d Yw3+vkLkEhESHI8LQRzLuDZM6GajOCqSBYVS63qV7nUJWIUIwNCC0xD78VnCmg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676368083; a=rsa-sha256; cv=none; b=ruroxm0UqB4szczpQBq6zSSJPT/0P2RUBeWtn9DFmikymEHq8scS6kKq5q6sTL0Yd3eVkG KZrhEnhDwaBHp3rg1govU05BVwNY+KqSv6ym5HL0/bDciVK3rTnZhVYGmrHHYUf8mVVUcU kwCRGRTSnztxtipiBKQSfxAy2Be6NwXw5SKQUBm6qQEK0RjQZOAfEl3pRo7xuH3A1yHKWG chZDd11SSyuSnQub0nvDOSIfdKZudgbustebD91uEK7WxPnyUzBGIgZVwWdfl8SqoxgWm+ hX6IdsuOfIXjZxhjm01pImyxBnQQ01xdGnvQ71QTL0hBFTJfRu6rf8cgTitlyA== Received: from beaver (unknown [IPv6:2a02:169:175:0:12bf:48ff:fee1:88e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: ehaupt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PGGbk2TrQzYqw; Tue, 14 Feb 2023 09:48:02 +0000 (UTC) (envelope-from ehaupt@FreeBSD.org) Date: Tue, 14 Feb 2023 10:48:01 +0100 From: Emanuel Haupt To: Alexey Dokuchaev Cc: Emanuel Haupt , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ce282f9818c3 - main - mail/nbsmtp: Does not build with clang 15 Message-Id: <20230214104801.0f50cc64788e1bc2753f3fb2@FreeBSD.org> In-Reply-To: References: <202302131420.31DEKZMF076523@gitrepo.freebsd.org> <20230214101626.a419aa8e076809d267c40a1b@FreeBSD.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd13.0) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N Alexey Dokuchaev wrote: > On Tue, Feb 14, 2023 at 10:16:26AM +0100, Emanuel Haupt wrote: > > Alexey Dokuchaev wrote: > > > On Mon, Feb 13, 2023 at 02:20:35PM +0000, Emanuel Haupt wrote: > > > > commit ce282f9818c344616ad9e3df29d01dab55acf8b2 > > > > > > > > mail/nbsmtp: Does not build with clang 15 > > > > > > > > +.include > > > > + > > > > +.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1400079 > > > > +USE_GCC= yes > > > > +.endif > > > > > > Why not just fix the code instead of pulling whole another > > > compiler suite? Looks like it bogusly assigns (char)NULL instead > > > of '\0' in several places (unless, of course, there are other, > > > more complicated errors, but commit log does not mention anything > > > specific). > > > > I'll have a list of ports that fail. My main priority is to unbreak > > the ports on main and have working packages again. Fixing the the > > code to build with clang 15 is a midterm priority. > > Clang 15 simply revealed the problem with the code, easily fixable. > By falling back to GCC you'd rage your users and merely postpone the > solution until GCC would become more strict and start complaining > just as Clang did just now. Fixing this particular bug would take > less time than calculating the 1400079 values for OSVERSION above. :-) Cool, I'll await yout patch :-)