From nobody Tue Feb 14 09:44:17 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PGGWP4RKBz3rTRR; Tue, 14 Feb 2023 09:44:17 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PGGWP4122z3PmT; Tue, 14 Feb 2023 09:44:17 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676367857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v7ZCQf5wnCrT10rAMIntT4rPBECsv467LiD9vuzNuBk=; b=ve2YmoJPUS3SX0BI9BgVzk0VsSen2IAMx98NcwF3yqjzI3gmLgZ0t5RHCwGLjykCCRxBts D55r+emD8Egl2NddzHbSccWVLSazXSpO+WWDYTzqtoAlo16c1pRnmjhHry/ZkoRMIvuwus RqVLnhffgse00ysJXxtIDBL7YRd01PUMB4rSHelmRkXuMdk+7PbVKZHZ6BIkP06Gh6yYNs g2AB8GqZ6mr8Aaslu4GZSFdOGwuDj1F50Xps9WGkb15O+tNW7yfoFrVNZtam65GpSGRdww lMOsESDNNtZusAPl72nWw5AM+7ccNKdguvhS+GevsKrIrGbNbgu7bOo9vvaKjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676367857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v7ZCQf5wnCrT10rAMIntT4rPBECsv467LiD9vuzNuBk=; b=fC111C9hjhm9Shi1UrheAY9meZ+dKokDt+63rLZ4I9mY6V8h3a0Fx07JrZ4xZxa/8mVs30 taw6MsgjGt7lUBrQ7Q7PiobjaxJjXuZph+LGIZq+NWUYWvz1F/Ezn8vH6g1u8JQqTOpHvI U9u4pMxmprthU70TlOnV52IkSx8cPoMVS0BscFZedwYI7CvMko0beLW5RV/dJW7IauWXyL w07ePLS3up7uBWxUF/Ty5daANORtuV962OUjBOqJNV2IwCPDYQ3c8RMG0paYQWN32Hys6l 4VnieaxSCVLXIdaG1zLxgIhzTK0qQAFU3U0aqIG7kUS75udTVUx+Deo8ne/iOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676367857; a=rsa-sha256; cv=none; b=pVOSozgcHtGT44hv2ZUeIksghosaG0yP4muV9M3etjHavmoqcjF9ITbUME05krIQqBS20g fAU+FmX2jBNXeNiGU1FMknKxzdbK5fPcry/4iupbSb6Jrvbug3B8wbQmAw7hsVZgy596x8 1A2+h9oBj4S/T4GsHXmXUuR9ovbSADyNyHjZGRDLGPMPb27Y7rCw+kz7k7vAIZpSw+1T8Q y3CIJqKJAyF5CFlWRNUuuCEBdC6JTTwfcf18vTcaePFInMOpkenZj4DpH9vBdPlHg34VUe h1IHoFijiw4tZxmU6wFf3/ekZaRHtMXq7OCOjkn3V1yvMA4AxzGOPiJKAUeKRg== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 789A21B5BA; Tue, 14 Feb 2023 09:44:17 +0000 (UTC) Date: Tue, 14 Feb 2023 09:44:17 +0000 From: Alexey Dokuchaev To: Emanuel Haupt Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ce282f9818c3 - main - mail/nbsmtp: Does not build with clang 15 Message-ID: References: <202302131420.31DEKZMF076523@gitrepo.freebsd.org> <20230214101626.a419aa8e076809d267c40a1b@FreeBSD.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230214101626.a419aa8e076809d267c40a1b@FreeBSD.org> X-ThisMailContainsUnwantedMimeParts: N On Tue, Feb 14, 2023 at 10:16:26AM +0100, Emanuel Haupt wrote: > Alexey Dokuchaev wrote: > > On Mon, Feb 13, 2023 at 02:20:35PM +0000, Emanuel Haupt wrote: > > > commit ce282f9818c344616ad9e3df29d01dab55acf8b2 > > > > > > mail/nbsmtp: Does not build with clang 15 > > > > > > +.include > > > + > > > +.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1400079 > > > +USE_GCC= yes > > > +.endif > > > > Why not just fix the code instead of pulling whole another compiler > > suite? Looks like it bogusly assigns (char)NULL instead of '\0' in > > several places (unless, of course, there are other, more complicated > > errors, but commit log does not mention anything specific). > > I'll have a list of ports that fail. My main priority is to unbreak the > ports on main and have working packages again. Fixing the the code to > build with clang 15 is a midterm priority. Clang 15 simply revealed the problem with the code, easily fixable. By falling back to GCC you'd rage your users and merely postpone the solution until GCC would become more strict and start complaining just as Clang did just now. Fixing this particular bug would take less time than calculating the 1400079 values for OSVERSION above. :-) ./danfe