Re: git: afcde63b907f - main - games/slump: Jettison byteswap/endian hacks

From: Jan Beich <jbeich_at_FreeBSD.org>
Date: Sun, 31 Dec 2023 07:00:35 UTC 
Muhammad Moinur Rahman <bofh@FreeBSD.org> writes:

> diff --git a/games/slump/files/patch-dump.c b/games/slump/files/patch-dump.c
> deleted file mode 100644
> index 44bf886aaa69..000000000000
> --- a/games/slump/files/patch-dump.c
> +++ /dev/null
> @@ -1,15 +0,0 @@
> ---- ./dump.c.orig	Sun May 29 23:48:57 2005
> -+++ ./dump.c	Mon Oct  9 23:53:07 2006
> -@@ -36,6 +36,12 @@
> - #include <assert.h>
> - #include "slump.h"
> - 
> -+#include <machine/endian.h>
> -+
> -+#if BYTE_ORDER == BIG_ENDIAN
> -+#define ENDIAN_BIG
> -+#endif

${WRKSRC}/Makefile.big-endian is unused but nothing else defines ENDIAN_BIG.
I think, this part should be reverted and/or converted to <endian.h>.

See also https://austingroupbugs.net/view.php?id=162