Re: git: f776ecb14ef3 - main - graphics/gdal: Update to 3.8.2

Am 25.12.23 um 21:45 schrieb Po-Chuan Hsieh:
> Hello,
> 
> On Mon, Dec 25, 2023 at 7:11 PM Rainer Hurling <rhurlin@gwdg.de 
> <mailto:rhurlin@gwdg.de>> wrote:
> 
>     Hi Sunpoet,
> 
>     Am 25.12.23 um 10:08 schrieb Po-Chuan Hsieh:
>      > The branch main has been updated by sunpoet:
>      >
>      > URL:
>     https://cgit.FreeBSD.org/ports/commit/?id=f776ecb14ef338ffe0ecb0d649c5513001ef31f0 <https://cgit.FreeBSD.org/ports/commit/?id=f776ecb14ef338ffe0ecb0d649c5513001ef31f0>
>      >
>      > commit f776ecb14ef338ffe0ecb0d649c5513001ef31f0
>      > Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
>      > AuthorDate: 2023-12-25 08:59:50 +0000
>      > Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
>      > CommitDate: 2023-12-25 08:59:50 +0000
>      >
>      >      graphics/gdal: Update to 3.8.2
>      >
>      >      - Add AEC option
>      >
>      >      Changes: https://github.com/OSGeo/gdal/releases
>     <https://github.com/OSGeo/gdal/releases>
>      > https://github.com/OSGeo/gdal/blob/release/3.8/NEWS.md
>     <https://github.com/OSGeo/gdal/blob/release/3.8/NEWS.md>
> 
>     Thanks again for the patch!
> 
>     But hmm, on my box (recent 115.0-CURRENT amd64) I can't build it
>     because
>     of a problem with finding lz4 in the configure phase:
> 
>     # make configure
>     [..snip..]
>     -- Looking for BZ2_bzCompressInit - found
>     CMake Warning at
>     /usr/local/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76
>     (find_package):
>         By not providing "Findlz4.cmake" in CMAKE_MODULE_PATH this
>     project has
>         asked CMake to find a package configuration file provided by
>     "lz4", but
>         CMake did not find one.
> 
>         Could not find a package configuration file provided by "lz4"
>     with any of
>         the following names:
> 
>           lz4Config.cmake
>           lz4-config.cmake
> 
>         Add the installation prefix of "lz4" to CMAKE_PREFIX_PATH or set
>     "lz4_DIR"
>         to a directory containing one of the above files.  If "lz4"
>     provides a
>         separate development package or SDK, be sure it has been installed.
>     Call Stack (most recent call first):
>         /usr/local/lib/cmake/TileDB/TileDBConfig.cmake:41 (find_dependency)
>         cmake/helpers/CheckDependentLibraries.cmake:145 (find_package)
>         cmake/helpers/CheckDependentLibraries.cmake:721 (gdal_check_package)
>         gdal.cmake:265 (include)
>         CMakeLists.txt:246 (include)
> 
>     CMake Warning at cmake/helpers/CheckDependentLibraries.cmake:145
>     (find_package):
>         Found package configuration file:
> 
>           /usr/local/lib/cmake/TileDB/TileDBConfig.cmake
> 
>         but it set TileDB_FOUND to FALSE so package "TileDB" is
>     considered to be
>         NOT FOUND.  Reason given by package:
> 
>         TileDB could not be found because dependency lz4 could not be found.
> 
>     Call Stack (most recent call first):
>         cmake/helpers/CheckDependentLibraries.cmake:721 (gdal_check_package)
>         gdal.cmake:265 (include)
>         CMakeLists.txt:246 (include)
> 
>     CMake Error at cmake/helpers/CheckDependentLibraries.cmake:202
>     (message):
>         Configured to use TILEDB, but not found
>     Call Stack (most recent call first):
>         cmake/helpers/CheckDependentLibraries.cmake:721 (gdal_check_package)
>         gdal.cmake:265 (include)
>         CMakeLists.txt:246 (include)
> 
>     -- Configuring incomplete, errors occurred!
>     *** Error code 1
> 
> 
>     archivers/liblz4 is installed, but obviously not found from this
>     version
>     of GDAL?
>     Do you have any idea what's going wrong here? Thanks for any help. 
> 
> 
>     Best wishes,
>     Rainer
> 
> 
> It should be fixed in 86f828477d2dfbee2ac10886745ea915f0bdb6c1.
> gdal is tested with all options enabled (except PODOFO).
> It is caused by tiledb cmake files.
> And that's why I do not like cmake.

Wow, that's fast! Thank you very much, I would not have thought so 
quickly that the search for lz4 as a dependency in tiledb is the actual 
cause.

Yes, cmake can sometimes get very confusing. But in the end I have 
almost always been able to solve my configuration problems with it.

Would the patch be something for Upstream?

Regards,
Rainer

> 
> Regards,
> sunpoet