From nobody Sun Dec 24 21:38:58 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SyvYm4pBVz54XgM; Sun, 24 Dec 2023 21:39:08 +0000 (UTC) (envelope-from mi+t@virtual-estates.net) Received: from symbion.zaytman.com (symbion.zaytman.com [64.112.176.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "symbion", Issuer "Narawntapu" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SyvYm49bzz3S4j; Sun, 24 Dec 2023 21:39:08 +0000 (UTC) (envelope-from mi+t@virtual-estates.net) Authentication-Results: mx1.freebsd.org; none Received: from aldan.narawntapu (pool-100-1-252-187.nwrknj.fios.verizon.net [100.1.252.187]) by symbion.zaytman.com (8.17.1/8.16.1) with ESMTPS id 3BOLd1WX044571 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK); Sun, 24 Dec 2023 16:39:01 -0500 (EST) (envelope-from mi+t@virtual-estates.net) X-Authentication-Warning: symbion.zaytman.com: Host pool-100-1-252-187.nwrknj.fios.verizon.net [100.1.252.187] claimed to be aldan.narawntapu Received: from [192.168.1.10] (aldan [192.168.1.10]) by aldan.narawntapu (8.17.2/8.17.1) with ESMTP id 3BOLcwdL096071; Sun, 24 Dec 2023 16:38:59 -0500 (EST) (envelope-from mi+t@virtual-estates.net) X-Authentication-Warning: aldan.narawntapu: Host aldan [192.168.1.10] claimed to be [192.168.1.10] Content-Type: multipart/alternative; boundary="------------11rPJi26WIvqEZ0XUFj8rLC9" Message-ID: <22e32001-b097-47d8-8866-083727424152@virtual-estates.net> Date: Sun, 24 Dec 2023 16:38:58 -0500 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 76772c2b0759 - main - www/websh: Unbreak, undeprecate, unexpire. Add LICENSE. Content-Language: en-US To: Gleb Popov , Mikhail Teterin Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202312242103.3BOL3Ea7060148@gitrepo.freebsd.org> From: "Mikhail T." In-Reply-To: X-DCC-www.nova53.net-Metrics: aldan.narawntapu 1204; bulk rep Body=5 Fuz1=5 Fuz2=5 rep=45% X-Spam-Status: No, score=-2.9 required=23.7 tests=ALL_TRUSTED,BAYES_00, HTML_MESSAGE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on aldan.narawntapu X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:394548, ipnet:64.112.176.0/24, country:US]; TAGGED_FROM(0.00)[t] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4SyvYm49bzz3S4j This is a multi-part message in MIME format. --------------11rPJi26WIvqEZ0XUFj8rLC9 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit 24.12.23 16:07, Gleb Popov: > Porter Handbook suggests defining TEST_TARGET: TEST_TARGET identifies the make-target in the upstream's Makefile, does not it? Not in the port's Makefile, which, as you can see upon closer examination, is different... The problem with the upstream's test-target is that it always succeeds -- even if a test fails. So I have a little awk-script, which parses the results. > https://docs.freebsd.org/en/books/porters-handbook/book/#make-test I don't see, where that text prohibits -- or even discourages -- what I am doing. Do you? -mi --------------11rPJi26WIvqEZ0XUFj8rLC9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
24.12.23 16:07, Gleb Popov:
Porter Handbook suggests defining TEST_TARGET:

TEST_TARGET identifies the make-target in the upstream's Makefile, does not it? Not in the port's Makefile, which, as you can see upon closer examination, is different...

The problem with the upstream's test-target is that it always succeeds -- even if a test fails. So I have a little awk-script, which parses the results.

https://docs.freebsd.org/en/books/porters-handbook/book/#make-test
I don't see, where that text prohibits -- or even discourages -- what I am doing. Do you?

-mi
--------------11rPJi26WIvqEZ0XUFj8rLC9--