Re: git: 8d096cbc7af5 - main - sysutils/lsof: add a build depends on bash for the timebeing.

On Wed, Dec 13, 2023 at 7:20 AM Mathieu Arnold <mat@freebsd.org> wrote:

> On Wed, Dec 13, 2023 at 06:32:44AM -0500, Adam Weinberger wrote:
> > On Wed, Dec 13, 2023 at 12:26 AM Gerald Pfeifer <gerald@pfeifer.com>
> wrote:
> >
> > > On Mon, 4 Dec 2023, Larry Rosenman wrote:
> > > >>> +BUILD_DEPENDS=             /usr/local/bin/bash:shells/bash
> > > >> s,/usr/local,${LOCALBASE},
> > > > I'm out of practice :(
> > >
> > > No worries, just note we have tools to support us.
> > >
> > > I gave this a try and got the following from portlint:
> > >
> > >   % portlint -C
> > >   WARN: Makefile: possible use of absolute pathname
> > > "/usr/local/bin/bash:...".
> > >
> >
> > Also just FTR, BUILD/RUN_DEPENDS works without absolute pathnames. This
> > would work fine too (and is the more common invocation):
> > BUILD_DEPENDS=  bash:shells/bash
>
> They are semantically different.
>
> bash:shells/bash means I need a bash executable, like, for running shell
> scripts.
>
> LOCAL/bin/bash:shells/bash means I need the LOCAL/bin/bash file, it may
> not be for execution. It is more usually used for a header, I do not see
> why one would need bash but not for running it.
>
> --
> Mathieu Arnold
>

That's a good point, and my message definitely glossed over that.

  foo:net/foo  ==  ${LOCALBASE}/bin/foo:net/foo    (as long as foo is not
in base)

  ${LOCALBASE}/share/foo/foo.h:net/foo  for non-executables

# Adam


-- 
Adam Weinberger
adamw@adamw.org
https://www.adamw.org