Re: git: 364f59940199 - main - net/lavinmq: Fix build with openssl3

From: Moin Rahman <bofh_at_freebsd.org>
Date: Tue, 29 Aug 2023 07:29:04 UTC 

> On Aug 29, 2023, at 9:18 AM, Vanilla Hsu <vanilla@fatpipi.com> wrote:
> 
> I think the root cause should be lang/crystal, not lavinmq.
> --
> with extra patches, crystal only build with openssl 1.1, not compatible with openssl3.
Yes indeed. Looks like the dirty hack just applies on OSREL < 15 making it bypass the test and build while other ports dependent on that fails.


> Muhammad Moinur Rahman <bofh@freebsd.org <mailto:bofh@freebsd.org>> 於 2023年7月27日 週四 上午1:47寫道：
>> The branch main has been updated by bofh:
>> 
>> URL: https://cgit.FreeBSD.org/ports/commit/?id=364f59940199e45a608ea2c53363d08243e3aa93 <https://cgit.freebsd.org/ports/commit/?id=364f59940199e45a608ea2c53363d08243e3aa93>
>> 
>> commit 364f59940199e45a608ea2c53363d08243e3aa93
>> Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
>> AuthorDate: 2023-07-26 17:18:33 +0000
>> Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
>> CommitDate: 2023-07-26 17:47:05 +0000
>> 
>>     net/lavinmq: Fix build with openssl3
>> 
>>     Approved by:    portmgr (blanket)
>>     Sponsored by:   The FreeBSD Foundation
>> ---
>>  net/lavinmq/Makefile | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>> 
>> diff --git a/net/lavinmq/Makefile b/net/lavinmq/Makefile
>> index 5ae75f50cfc0..bf6c119b8173 100644
>> --- a/net/lavinmq/Makefile
>> +++ b/net/lavinmq/Makefile
>> @@ -11,8 +11,6 @@ WWW=          https://www.lavinmq.com/
>> 
>>  LICENSE=       APACHE20
>> 
>> -BROKEN_FreeBSD_14=     Incompatible with OpenSSL 3.0 in 14-CURRENT
>> -
>>  BUILD_DEPENDS= crystal:lang/crystal \
>>                 help2man:misc/help2man \
>>                 shards:devel/shards
>> @@ -40,6 +38,12 @@ OPTIONS_DEFINE=      DOCS
>>  SHARDS_ENV=    --time --verbose --production --release --no-color --stats \
>>                 --static
>> 
>> +.include <bsd.port.options.mk <http://bsd.port.options.mk/>>
>> +
>> +.if ( ${OPSYS} == FreeBSD && ${OSVERSION} >= 1400092 && ${SSL_DEFAULT} == base ) || ${SSL_DEFAULT:Mopenssl3*}
>> +CXXFLAGS+=     -DOPENSSL_API_COMPAT=0x30000000L
>> +.endif
>> +
>>  post-extract:
>>  # force shards to use local paths, not git repos, for dependencies
>>         @${RM} ${WRKSRC}/shard.lock