Re: git: 11e51925413b - main - devel/p5-DateTime-Format-MySQL: Update to 0.08

On Sat, Aug 19, 2023 at 3:59 AM Joseph Mingrone <jrm@freebsd.org> wrote:

> On Fri, 2023-08-18 at 16:08, Renato Botelho <garga@FreeBSD.org> wrote:
>
> > On 18/08/23 15:52, Joseph Mingrone wrote:
> >> On Fri, 2023-08-18 at 14:32, Renato Botelho <garga@FreeBSD.org> wrote:
>
> >>> On 17/08/23 10:37, Joseph Mingrone wrote:
> >>>> On Thu, 2023-08-17 at 10:15, Renato Botelho <garga@FreeBSD.org>
> wrote:
>
> >>>>> On 16/08/23 15:36, Po-Chuan Hsieh wrote:
> >>>>>> The branch main has been updated by sunpoet:
> >>>>>> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=11e51925413b7090544d4a4ac449c364717f7e50
> >>>>>> commit 11e51925413b7090544d4a4ac449c364717f7e50
> >>>>>> Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> >>>>>> AuthorDate: 2023-08-16 18:16:29 +0000
> >>>>>> Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> >>>>>> CommitDate: 2023-08-16 18:26:21 +0000
> >>>>>>        devel/p5-DateTime-Format-MySQL: Update to 0.08
> >>>>>>             Changes:
> https://metacpan.org/dist/DateTime-Format-MySQL/changes
> >>>>>> ---
> >>>>>>     devel/p5-DateTime-Format-MySQL/Makefile | 2 +-
> >>>>>>     devel/p5-DateTime-Format-MySQL/distinfo | 6 +++---
> >>>>>>     2 files changed, 4 insertions(+), 4 deletions(-)
> >>>>>> diff --git a/devel/p5-DateTime-Format-MySQL/Makefile
> b/devel/p5-DateTime-Format-MySQL/Makefile
> >>>>>> index 989d481a74d2..f9b0e03be278 100644
> >>>>>> --- a/devel/p5-DateTime-Format-MySQL/Makefile
> >>>>>> +++ b/devel/p5-DateTime-Format-MySQL/Makefile
> >>>>>> @@ -1,5 +1,5 @@
> >>>>>>     PORTNAME=    DateTime-Format-MySQL
> >>>>>> -PORTVERSION=    0.0701
> >>>>>> +PORTVERSION=    0.08
>
> >>>>> Hello Po-Chuan!
>
> >>>>> 0.08 is smaller than 0.0701 so port version went backwards after
> this change.
> >>>> 0.08 is greater than 0.0701, but not according to pkg version.
> >>>>    % pkg version -t 0.08 0.0701
> >>>>           <
>
> >>> Actually pkg is correct in this case.  Numerically 8 is smaller than
> 701.  I tested it on Ubuntu and dpkg --compare-versions has the same
> result, and I believe any other package management tool will do.
>
> >>> What seems to be wrong is the version schema used by this project.  It
> should be 0.0800 instead of 0.08.
> >> I didn't mean to suggest that pkg is wrong, but just pointing out that
> numerically, 0.08, which is equal to 0.0800, is greater than 0.0701.  This
> could be a source of confusion for anyone who assumes that the comparison
> of version numbers works the same as comparisons of
> >> real numbers.
>
> > Anyway, can you please fix the port by adding PORTEPOCH?
>
> Fixed in 49eb4309189da197f55dee54f8efb5e875f2daaa.  Thanks for reporting.
>
> Joe
>

No doubt 0.08 is less than 0.0701 in the pkg world.
Thank you all for fixing it.

We don't know if the versioning change is temporary or not. Instead of
adding PORTEPOCH, please consider the following fix/hack next time.
Thanks again.

--- a/devel/p5-DateTime-Format-MySQL/Makefile
+++ b/devel/p5-DateTime-Format-MySQL/Makefile
@@ -1,8 +1,9 @@
 PORTNAME=      DateTime-Format-MySQL
-PORTVERSION=   0.08
+PORTVERSION=   0.0800
 CATEGORIES=    devel perl5
 MASTER_SITES=  CPAN
 PKGNAMEPREFIX= p5-
+DISTNAME=      DateTime-Format-MySQL-${PORTVERSION:C|00$||}

 MAINTAINER=    perl@FreeBSD.org
 COMMENT=       Parse and format MySQL dates and times