From nobody Sat Aug 19 07:09:14 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RSVGk38Wdz4qKr9; Sat, 19 Aug 2023 07:09:18 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RSVGk2XWQz4Rxj; Sat, 19 Aug 2023 07:09:18 +0000 (UTC) (envelope-from jbeich@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692428958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8P8vdAXMtYbLQzpc7TacyP/Xk6yOi+JQWGARKQ5uHuc=; b=o+UWff+DL9rzgKcwpDi8G2qbpkmdOdkqmcjCXKdD4G+sKhL39HvHA1iaO6rrR0DaBtOEmM fxib2Qps3L375XgfiHT03UhNzZMCWo6l2hNSfkiO/CY+FvM0zvQs84VWgbPtRC2vDK8/WP Vo6ilAv/0NJ6f29INI1vYRfttRbzmNwXtR2ZmePs9TxNqQOpQuJOlz+Y7v+4squlKwOnR/ avWwVoiLyVWdinJXxz7YHenI/Q5eNHEldayCFv7nCp6/8fh/WCFEygKf1+I9TaDPMUujJ0 9oBzUI2Zry+s/yvw2ZQiXcritWIRNXm98RuxCgcsVYZOqcoRvF1Q5r0AMBG8dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692428958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8P8vdAXMtYbLQzpc7TacyP/Xk6yOi+JQWGARKQ5uHuc=; b=JiVTNctkNN6XPyufnBziSmSnezRtrtBaOhu+f9JOqjR74Us4zjF8yPudAMxxMCyeHhwk7a SV1at4UpDYhtcfuk3TvBYjYXOetARk82ZJccr6idsvuCGFM9rs+Ptwm9vW20SMTHDgjAkG VCuJqGme8GLvCe91vKD2wc0FbaeyXnX/PcZrxNKF7CeyK/GbyYJAh7g4+NvN19A8JXCHVe 6xfZusXw/dLxlAkq1oV2ULxK1Fgqm7ADyvOIJGYcphQ9GMu/v23FG+Qgc+F27COUylTwLy soP7gNxSEtsa2BQfeH0nI39X4mOhpg30UdgzOyF4zlwfl3vTbhCd6LCg8Driyw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692428958; a=rsa-sha256; cv=none; b=AKfPsfoGYZ11C4e5GFFUaASeBRTtsFhhezL+ezA1SWRlRX/AcZ4+0/ZF5OY+vdWQCbnSrE vlfH9TTE/2MqLqsGETgEg/WICYCUMz1ODXR3JyDo2FnVv5GegbMw0mPfJFnWmg1w1ofJKW WKApeCc349XaRwn9ezqpEvX+t8mgaKfa//CIBp9vUs8RrRdcPb94WTLUo1Ym9A1DFsFgUr Gw/eqSBSYfhXPjF9gZidq/jKsAqyOE06NPk0uLGkIU4YwEUqOy6pcnhBrdGxF3W1AU3RQa 1Eu2qC5qvy3k6WPz79srU8aDd5ritxPKJk+yzph8NotUiajmV0tzpGTQTa5+cg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: by freefall.freebsd.org (Postfix, from userid 1354) id 478CA12E64; Sat, 19 Aug 2023 07:09:18 +0000 (UTC) From: Jan Beich To: Daniel Engberg Cc: Po-Chuan Hsieh , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 616e8c13a4ce - main - devel/utf8cpp: Update to 3.2.4 In-Reply-To: <5be35ca3e7ac2390fdbce2e4792223b5@pyret.net> (Daniel Engberg's message of "Sat, 19 Aug 2023 07:36:07 +0200") References: <202308161944.37GJifUD062454@gitrepo.freebsd.org> <5be35ca3e7ac2390fdbce2e4792223b5@pyret.net> Date: Sat, 19 Aug 2023 09:09:14 +0200 Message-ID: List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain Daniel Engberg writes: > On 2023-08-16 21:44, Po-Chuan Hsieh wrote: >> --- a/devel/utf8cpp/Makefile >> +++ b/devel/utf8cpp/Makefile >> @@ -1,9 +1,9 @@ >> PORTNAME= utf8cpp >> +PORTVERSION= 3.2.4 >> DISTVERSIONPREFIX= v >> -DISTVERSION= 3.2.3 [...] > Can you please revert you changes so the port don't deviate from > Porters Handbook? > https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github > - Example 16 Did you overquote the whole commit just for DISTVERSION vs. PORTVERSION ? Neither portlint nor portclippy warn about mixing PORTVERSION with DISTVERSIONPREFIX. >> @@ -11,20 +11,14 @@ LICENSE= BSL >> LICENSE_FILE= ${WRKSRC}/LICENSE >> USES= cmake >> -USE_GITHUB= yes >> -GH_ACCOUNT= nemtrif >> -GH_PROJECT= utfcpp >> + >> +CMAKE_ON= UTF8_INSTALL >> +CMAKE_OFF= UTF8_SAMPLES UTF8_TESTS >> NO_ARCH= yes >> -PLIST_FILES= include/utf8cpp/utf8.h \ >> - include/utf8cpp/utf8/checked.h \ >> - include/utf8cpp/utf8/core.h \ >> - include/utf8cpp/utf8/cpp11.h \ >> - include/utf8cpp/utf8/cpp17.h \ >> - include/utf8cpp/utf8/unchecked.h \ >> - lib/cmake/utf8cpp/utf8cppConfig.cmake \ >> - lib/cmake/utf8cpp/utf8cppConfigVersion.cmake \ >> - lib/cmake/utf8cpp/utf8cppTargets.cmake >> +USE_GITHUB= yes >> +GH_ACCOUNT= nemtrif >> +GH_PROJECT= utfcpp Another style regression: out of order USE_GITHUB group of variables. https://docs.freebsd.org/en/books/porters-handbook/order/#porting-order-uses Noticed via portclippy from ports-mgmt/portfmt.