From nobody Thu Aug 17 10:31:31 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RRLrz4tY7z4qVtS; Thu, 17 Aug 2023 10:31:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RRLrz2NMQz4Rdm; Thu, 17 Aug 2023 10:31:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692268291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3b9bee1XdfpDLUpDBgvB2F5TdunjoB9axV9WYD1QQdw=; b=wH7CreSjOlnCwQ1pFrGVUxXudZ9vRjomivKXPu4wOafW0gS/WEtcwOBFiGDYWUmsoZ2VL7 L/aLJvSabHFbL5YlN7YWGE11mMICxu9MuhuzUVv3r3wkakqYH6Udw4uJvj/9RK3GG4BT/R Bt/g11+vfMekYJGYiA5XnvXlrJug1kReeRjarPoZCKUsY9N4X/IRLBWnAymZ5R4y/emNm4 BdaZMqSbU0YOh223nL0lhzc4LcrZ2RT3olf2WEiWvIG04WQV0w4vLuFHVwHiUB0UZc0QiB HLxxxvSWiImSziuYC6jVjF4S/q3mnCTmydg6NFYGiEjXUYqMQa1tg2tr/zATBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692268291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3b9bee1XdfpDLUpDBgvB2F5TdunjoB9axV9WYD1QQdw=; b=yVpOfySn0jTyz9kD0FZ9VpV/hvcfcPfUqjK9mi7vWaAgyWx/M7rpfr1Kfj6Y0kcOAcPcks 3YG4ZNSRpSXyUC+DMMJEZifXKwViacedbl5WSte7csjz6G0MNBcOJii9KUkI7YOOruzdY2 qTik3dQhfGfjsuRO5taHd+fWeQo9UzcDN7c2gD8j2I8rG12t//BmxjBbgazFz/oV2l5QPD NUbF+L1Rhylt6ccnRFfDJvbmdStztlehJ0KGIjRztlfESeWMpEMK/Q9TLTdVv05UGPUC1l MWMGWLkkivoaulKbw1B4/Kh6l7JKJzqRE0g7K9GZNoveYMkGNyCd9TyTdx47Qg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692268291; a=rsa-sha256; cv=none; b=rZcjAQQvWHooXUuhajfaZga4aQkkXnjZlBqq1XoVpmOoya+mY7GoSkLOJS6vEvEexGvtxi XRaEOYq7fIIUPeCq/4LOGU5WQlFzr1SRSBNieJbEAvseVvSThxqLV8E0ubVRKo7WMBjtHQ tFZJ5vQ0IAhR9oCXjhdNoC5EK7XVUca2VQ20C7+fzINSzQB5fl/WFbArt9/AvsvJSABd7B LpuQK1O05DCUvXdK2fHJ1qjfV3x966dyjk95lhy4JrB3FZJcHWkJ8gXeZJMo+poZ51xBmL GzdXo844bpK1qhtKra2lVq1DXnI1fDSzuOBSjfKvRqe5VywHNNbVVEmCnUFzVg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RRLrz19rBzVmj; Thu, 17 Aug 2023 10:31:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 37HAVVZG042809; Thu, 17 Aug 2023 10:31:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 37HAVVnl042806; Thu, 17 Aug 2023 10:31:31 GMT (envelope-from git) Date: Thu, 17 Aug 2023 10:31:31 GMT Message-Id: <202308171031.37HAVVnl042806@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Kai Knoblich Subject: git: 2f01d3233249 - main - www/qt5-webengine: Remove unnecessary ulimit calls List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kai X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2f01d32332494380dc4971717d2757415dcbd27e Auto-Submitted: auto-generated The branch main has been updated by kai: URL: https://cgit.FreeBSD.org/ports/commit/?id=2f01d32332494380dc4971717d2757415dcbd27e commit 2f01d32332494380dc4971717d2757415dcbd27e Author: John Hein AuthorDate: 2023-08-17 10:21:16 +0000 Commit: Kai Knoblich CommitDate: 2023-08-17 10:30:45 +0000 www/qt5-webengine: Remove unnecessary ulimit calls Before linking, which is far at the end of the long building process, the ulimit is tried to be set to 4096. If this fails, it will cause the whole linking process to abort and thus lead to a failed build, which is the case when qt5-webengine is build with a non-root user in a Poudriere jail. The problem could be probably solved by substituting "&&" with ";" in the affected lines, but in the course of bug 270041 it has become apparent that an ulimit of 1024, which is poudriere's default, is sufficient. [1] This could also be successfully verified with qt5-webengine builds (with either ALSA/PULSEAUDIO/SNDIO enabled and DEBUG set/unset) in non-root poudriere jail hence remove the ulimit calls to fix the problem. PR: 270041 Reported by: Tomoaki AOKI, John Hein [1] MFH: 2023Q3 With hat: kde --- www/qt5-webengine/files/patch-src_core_core__module.pro | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/www/qt5-webengine/files/patch-src_core_core__module.pro b/www/qt5-webengine/files/patch-src_core_core__module.pro index 3c6330bb2323..9251779d895e 100644 --- a/www/qt5-webengine/files/patch-src_core_core__module.pro +++ b/www/qt5-webengine/files/patch-src_core_core__module.pro @@ -1,11 +1,19 @@ +No need to limit max open file descriptors. +See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270041 + --- src/core/core_module.pro.orig 2021-12-15 16:12:54 UTC +++ src/core/core_module.pro -@@ -41,7 +41,7 @@ CONFIG -= bsymbolic_functions +@@ -41,10 +41,10 @@ QMAKE_INFO_PLIST = Info_mac.plist # and doesn't let Chromium get access to libc symbols through dlsym. CONFIG -= bsymbolic_functions -linux { +unix { !ccache:!use_gold_linker:!use_lld_linker { - QMAKE_LINK="ulimit -n 4096 && $$QMAKE_LINK" - QMAKE_LINK_SHLIB="ulimit -n 4096 && $$QMAKE_LINK_SHLIB" +- QMAKE_LINK="ulimit -n 4096 && $$QMAKE_LINK" +- QMAKE_LINK_SHLIB="ulimit -n 4096 && $$QMAKE_LINK_SHLIB" ++ QMAKE_LINK="$$QMAKE_LINK" ++ QMAKE_LINK_SHLIB="$$QMAKE_LINK_SHLIB" + } + qtConfig(separate_debug_info): QMAKE_POST_LINK="cd $(DESTDIR) && $(STRIP) --strip-unneeded $(TARGET)" + }