Re: git: 9f5034f55a47 - main - Mk/Uses/php.mk: Refactor

From: Antoine Brodin <antoine_at_freebsd.org>
Date: Mon, 24 Apr 2023 20:16:21 UTC 
On Mon, Apr 24, 2023 at 8:01 PM Muhammad Moinur Rahman <bofh@freebsd.org> wrote:
>
> The branch main has been updated by bofh:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=9f5034f55a47591288167cd49fe4bb963143caed
>
> commit 9f5034f55a47591288167cd49fe4bb963143caed
> Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
> AuthorDate: 2023-04-24 19:59:31 +0000
> Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
> CommitDate: 2023-04-24 20:01:01 +0000
>
>     Mk/Uses/php.mk: Refactor
>
>     - Replace old USE_APACHE_RUN with USES=apache:run
>     - Prior to php8.0 there was a check for the required libname which
>       contained the version number of php. Remove the conditional.
>
>     Sponsored by:   Bounce Experts
> ---
>  Mk/Uses/php.mk | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Hi,

Overriding USES doesn't look good.
Maybe it should be something like this instead:
apache_ARGS?=run
.include "${USESDIR}/apache.mk"

Antoine