From nobody Sat Apr 22 19:46:03 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q3hhr0Xc3z46CDp; Sat, 22 Apr 2023 19:46:04 +0000 (UTC) (envelope-from rene@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q3hhq6nChz3q3D; Sat, 22 Apr 2023 19:46:03 +0000 (UTC) (envelope-from rene@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682192764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uFLX0McORgWN7laU1wnVgVBR6TMkryN/0UTKPnHgvWo=; b=HmynkSfrCQtpUlfNs0lV3M5/kRFINXyrBjDND2MPYxa9L2SEML0ATTh/oR9mom7ACym6AQ BnQklGd6JP64Nkfn0BrFoJeTkNbeW0lf295bu61raYzEthkB0CLos3Tq66Mh1NCksss1xx DKSL1IoG1NlIVFSlReiTNfjYvhCzWreqVfgonD2AJLB+DmvLPDWwfViiccpq0VBUT7MyFX HbjPPqudhm9qx//2AxxSsZELa2vayumOFjmG1gi+S+MyiiBrxzvlFWVOqGQROa4yg8mA5A PoWT83pSw4AOkBxXczhJrdQnA8LF1Jsa+06OA/JsQCeAwc28WEPx6APAe+QiWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682192763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uFLX0McORgWN7laU1wnVgVBR6TMkryN/0UTKPnHgvWo=; b=rx8iovid0O3mhLlnlk2vnHSZ9ExD3icDQ82gzAbPfsft7dRo0vZK34BmFcWZgxwBX14kaa L9QpWnxL99XZI8fEFJ/wG9AFbsZCcB2Cgr8GD1UhyYVlHf7XxYCIg+3uFUvzWPX3YV+oLK /Q0r+sdYqsgp+BHiRQXKTxxqRk8gUcVfLb1tc6Y7NmDozxmf9bdkcFqHHYSZIq7kT7Surs aJoH2/2jiDmnHwN2BoBLHgUmVvi8NV+DMtF93ixZxBJkuBmiDc04m0w6O6ijoFUNaq0emE myYlAVCHkvy0H2zLn3kDSjwuz/VTAAHIW0JwIwFDOI9cClEiw1Y/JZKO3rw8NQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682192763; a=rsa-sha256; cv=none; b=kZLvFWaEfvnlkQVWQEagavhjZkNA0WM8TYpopbgVaEszhhcKRNM6NpA2ltDiF5fWxzqod3 MG2w8q38kd1XEnoUGwlGFkCiZ/kMkZrO0dLdA3UdnAeMkFsiEVbJ+GbgDYgA7hUPsugas6 Tm+nOP73BsVzAL4TewrygHMYrF2bl6yvaxt1K9/6k3YPNsPtEUJPwNH32uG9yMyjSs+3fg WRQ6N6BM8CFXfPqWWT/7bhej+2VVGZXwUoFLxsJTJvJdbESKHs9wpopkw0aVD825T3W6rc w5btb8ToPCe7M9KORnYG/WFOhFMa1cbwrcvGxde/TIMtKo9NEkHk7vfWzuN+2Q== Received: by freefall.freebsd.org (Postfix, from userid 1185) id D256412A23; Sat, 22 Apr 2023 19:46:03 +0000 (UTC) Date: Sat, 22 Apr 2023 19:46:03 +0000 From: Rene Ladan To: "Bjoern A. Zeeb" Cc: Emmanuel Vadot , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 3082cab3f868 - main - net/wifi-firmware-*: add framework and firmware for various WiFi chipsets Message-ID: References: <202304221526.33MFQ8Ah006135@gitrepo.freebsd.org> <20230422200746.f5de9ba748783b3c49ad6ffb@bidouilliste.com> <558rpr26-q19s-n3o3-7q47-011549so044s@serrofq.bet> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <558rpr26-q19s-n3o3-7q47-011549so044s@serrofq.bet> X-ThisMailContainsUnwantedMimeParts: N On Sat, Apr 22, 2023 at 07:06:40PM +0000, Bjoern A. Zeeb wrote: > On Sat, 22 Apr 2023, Emmanuel Vadot wrote: > > > On Sat, 22 Apr 2023 15:55:45 +0000 > > Rene Ladan wrote: > > > >> On Sat, Apr 22, 2023 at 03:26:08PM +0000, Bjoern A. Zeeb wrote: > >>> The branch main has been updated by bz: > >>> > >>> URL: https://cgit.FreeBSD.org/ports/commit/?id=3082cab3f868c1f7538d5221080703d891a2d0a6 > >>> > >>> commit 3082cab3f868c1f7538d5221080703d891a2d0a6 > >>> Author: Bjoern A. Zeeb > >>> AuthorDate: 2023-04-09 01:29:48 +0000 > >>> Commit: Bjoern A. Zeeb > >>> CommitDate: 2023-04-22 15:21:22 +0000 > >>> > >>> net/wifi-firmware-*: add framework and firmware for various WiFi chipsets > >>> > >>> Add a "base port framework" to fetch (WiFi) firmware and license files > >>> from the linux-firmware.git repository and an accompanying FreeBSD > >>> build kmod framework tarball (for now; we might do without that in > >>> the future). > >>> Add child ports for Realtek rtw88 and rtw89, Mediatek mt76, and > >>> Atheros ath10k and ath11k firmware as a start. > >>> > >>> This is a beginning in order to stop bloating src.git and the > >>> installed kernels with lots of MB of firmware files whereas usually > >>> only one vebdor/chipset/flavor is needed. Before fully switching > >>> more infrastructure needs to be in place but this is the first and > >>> most important step. > >>> > >>> PR: 270742 > >>> Reviewed by: lwhsu > >>> Approved by: lwhsu (ports) > >>> Differential Revision: https://reviews.freebsd.org/D39487 > >>> --- > >>> net/wifi-firmware-ath10k-kmod/Makefile | 88 ++++++++++++++++++++++++++ > >>> net/wifi-firmware-ath10k-kmod/distinfo | 79 ++++++++++++++++++++++++ > >>> net/wifi-firmware-ath10k-kmod/pkg-descr | 3 + > >>> net/wifi-firmware-ath11k-kmod/Makefile | 105 ++++++++++++++++++++++++++++++++ > >>> net/wifi-firmware-ath11k-kmod/distinfo | 23 +++++++ > >>> net/wifi-firmware-ath11k-kmod/pkg-descr | 3 + > >>> net/wifi-firmware-base/Makefile | 80 ++++++++++++++++++++++++ > >>> net/wifi-firmware-mt76-kmod/Makefile | 31 ++++++++++ > >>> net/wifi-firmware-mt76-kmod/distinfo | 27 ++++++++ > >>> net/wifi-firmware-mt76-kmod/pkg-descr | 5 ++ > >>> net/wifi-firmware-rtw88-kmod/Makefile | 34 +++++++++++ > >>> net/wifi-firmware-rtw88-kmod/distinfo | 19 ++++++ > >>> net/wifi-firmware-rtw88-kmod/pkg-descr | 7 +++ > >>> net/wifi-firmware-rtw89-kmod/Makefile | 28 +++++++++ > >>> net/wifi-firmware-rtw89-kmod/distinfo | 13 ++++ > >>> net/wifi-firmware-rtw89-kmod/pkg-descr | 6 ++ > >>> 16 files changed, 551 insertions(+) > >>> > >> Shouldn't these ports be added to net/Makefile ? > >> > >> Regards, > >> René > > > > Yes it should, and I really wished this was using flavors like we do > > for the gpu firmwares. Bjoern if you have questions on how to flavorise > > those ports don't hesitate to ask. > > You may notice that there are two places in the base port already > refering to FLAVOR and that the individual ports are split up into > "FWSUBS" which basically is a flavour later on. > These had been started very differently initially with changes to Mk/ > and then were rewritten based on feedback. > I'll be very happy to take this offline with you to sort flavours out > for each of them. > > For now the reason to have them in first place was the request to not > further bloat src and that should have happened months ago but on > initial request no one had offered help. > Next I'll need to figure out release problems for that. > > > For immediate help (before connecting them to the build): > > I also got a report from dvl/freshports that the base port (which should > never be built) doesn't have a pkg-descr. Do I need to add that too? > Hmm, I think it is cleaner that way, a placeholder text might do. The internal `make generate-plist` target in bsd.port.mk assumes a pkg-descr here, and having a pkg-descr avoids a /dev/null entry in INDEX in its place. The current -base port is not a meta-port in the traditional sense, see Mk/Uses/metaport.mk and e.g. x11/kde5/Makefile for an example. Personally it more feels like an extension of USES=kmod. Regards, René > /bz > > -- > Bjoern A. Zeeb r15:7