From nobody Wed Apr 12 14:21:40 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PxPz93r9rz44r9k; Wed, 12 Apr 2023 14:21:41 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PxPz92sJ3z3hwb; Wed, 12 Apr 2023 14:21:41 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681309301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=acDgvvgtk0c6iMi1TtyfW+pzxVJ+iqKCfgm6aOmprxE=; b=DX2SZRD17bYgKeP7zzqfMeGtSQuVAxoDqB14o1CApsr3wwMmTPaESFBJFJY8R+628zwDjt K11VibEk25zbFjWjCc2BAN6QL8PFIrF6W2xlXZ994WIHJBlSLhSNLTP7yY2PluisqVP8Os LILcYuqspIj/fhm6qV1s/pvmjFRtvRpBkXZtBkOWY8vQzwaFQhVnzQaStOpeQXlOW18ylJ 9yHTVxuaJe96WH+vS0yTT4uCqNvONwaJ7aiWNs0jsngJ/P4jfDBX/mhRSNxwf99VvvLjB7 iRdkroWa+uFk4wlgYJDzjehvnFW7P6FeaIqs2HVcj1v/bKXQo7ta/QLKBZgWLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681309301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=acDgvvgtk0c6iMi1TtyfW+pzxVJ+iqKCfgm6aOmprxE=; b=t4UpicLrzm7cqceCoOodbLp6VNzwm9V/KYas2epggRm7b9xYDU0NfUZRPaNKO2F+8+T4Cx OsqSlfUvOIoAp5ViE5JWBPckoQLk9lAfib2olzzyb5wOoOuePrsLHaxCx54lAc6cHdRp3P hVUeUB2UWQRKMDEzF9Z2irH0M797kJZze1Aoscna454JYcYpxrmn/KaL6Rjb8xc1pHPD6B KgRlE6CdL9q9+LgQsHpJYIiTjrj+nyTKYFFKsxEPv1a+NFu7Gz/9ji2ah3h2J4TehB2kaJ PFDvMCZUXnPH4gC3V4aKWuWEjnX49Uv3NPAju4vw8D8zhbAVIZsgVCoLxmjQ8w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681309301; a=rsa-sha256; cv=none; b=hE5MUWmwhw/cdwkvjehA1m+2zaIKPWqeC7cdJrbl13UsR/Az8CeoW5kcSkHliGYsHGouZG eY/iPWjmwrT+/xWIrM3kk8mb6Oi5rzJukQdwd659ZZwIw4ZC0nUw3u+QluNo9dz9Ba2+YF grBAQ9xAGkXzPclKxhE92ILHiCLTzwF2TJv2DFi38tECKGHBcR7BogIV7hj9cFhgNKr7zz a1oSUH1eYz+Hmxw2DV8PNmsxlKTB15ONmjwOi2sEZZbeBurssFfPE6i6AtP2Jm2uoPjXhe NP8bHcpT5pnNDsLY7MJHsxd79XAYJWpq2DQtbXBvxrnZdQEPVgMj9r0pCeIY4w== Received: by freefall.freebsd.org (Postfix, from userid 1033) id E83B11250B; Wed, 12 Apr 2023 14:21:40 +0000 (UTC) Date: Wed, 12 Apr 2023 14:21:40 +0000 From: Alexey Dokuchaev To: Mathieu Arnold Cc: Muhammad Moinur Rahman , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c89b6f279989 - main - lang/php8[12]: Fix build on aarch64 with ZTS Message-ID: References: <202304120539.33C5dOJA014331@gitrepo.freebsd.org> <6inj2unwo45zfdu65na77yeob7pteqy62gdrxganabcagk3pjc@tvkxg2g773o3> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6inj2unwo45zfdu65na77yeob7pteqy62gdrxganabcagk3pjc@tvkxg2g773o3> X-ThisMailContainsUnwantedMimeParts: N On Wed, Apr 12, 2023 at 03:55:00PM +0200, Mathieu Arnold wrote: > On Wed, Apr 12, 2023 at 01:43:43PM +0000, Alexey Dokuchaev wrote: > > On Wed, Apr 12, 2023 at 05:39:24AM +0000, Muhammad Moinur Rahman wrote: > > > commit c89b6f2799891129e89d1b4fedf8e25865241060 > > > > > > lang/php8[12]: Fix build on aarch64 with ZTS > > > > > > - Refresh patches > > > > What good did it bring other than cloaking the actual fix with tons > > of needless, unrelated changes? You've poured a glass of honey into > > a bucket of tar. :( > > Because that is something you have to do everytime a port is updated, No, you don't, and you shouldn't. Patches come and go all the time, blindly following this "rule" just brings useless noise to the commit diff, nothing else. > refresh the patches so that the line offsets are correct wrt current > sources, to make sure patch(1) can just apply the patches and not > resort to guesswork. If patch(1) cannot apply some patch, it will complain and the port won't build, so existing patches are applicable by definition. But we have already argued about this in the past. I prefer cleaner commit diffs, you don't, oh well. ./danfe