From nobody Mon Apr 10 13:00:04 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pw8G21RFsz45CWP; Mon, 10 Apr 2023 13:00:10 +0000 (UTC) (envelope-from matthias.andree@tu-dortmund.de) Received: from unimail.uni-dortmund.de (mx1.hrz.uni-dortmund.de [129.217.128.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "unimail.tu-dortmund.de", Issuer "GEANT OV RSA CA 4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pw8G113bFz4LYt; Mon, 10 Apr 2023 13:00:08 +0000 (UTC) (envelope-from matthias.andree@tu-dortmund.de) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=tu-dortmund.de header.s=unimail header.b=J1+fXvJF; spf=pass (mx1.freebsd.org: domain of matthias.andree@tu-dortmund.de designates 129.217.128.51 as permitted sender) smtp.mailfrom=matthias.andree@tu-dortmund.de; dmarc=none Received: from mandree.no-ip.org (pd9e07ecc.dip0.t-ipconnect.de [217.224.126.204]) (authenticated bits=0) by unimail.uni-dortmund.de (8.17.1.26/8.17.1.26) with ESMTPSA id 33AD05xi028435 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 10 Apr 2023 15:00:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tu-dortmund.de; s=unimail; t=1681131605; bh=6HI5Wf9gjdXxiDLCaJK/ytPOC334VlBJY8qyD74wxLM=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=J1+fXvJFXd+NqBw+EcRnI2DK+ax9+fx3RsdkTlOupu6hAFcPW7mq51vyX9zGwcQQw eVyjbFV3HcvQdDTVcsxy+Agprq7mOW8LXv9suJS4uMsmESstGMUxvAw3O3PYV/0DwI NQ8vwpmXjIL/QX7ylXsxslZN3HWcQGqTBWFmlDF8= Received: from [127.0.0.1] (localhost [127.0.0.1]) by ryzen.an3e.de (Postfix) with ESMTP id 1FDC2DF3D2C; Mon, 10 Apr 2023 15:00:05 +0200 (CEST) Message-ID: Date: Mon, 10 Apr 2023 15:00:04 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: git: 72ad532057c9 - main - archivers/zstd: Add CMake config files and adjust Makefile Content-Language: en-US To: Dima Panov Cc: Daniel Engberg , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Alexey Dokuchaev , Guido Falsi References: <202304050615.3356FKNq062154@gitrepo.freebsd.org> <7accd096-7871-29ad-0824-c035504d01b0@FreeBSD.org> From: Matthias Andree In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-5.30 / 15.00]; DWL_DNSWL_LOW(-1.00)[tu-dortmund.de:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:129.217.128.0/24]; RCVD_IN_DNSWL_MED(-0.20)[129.217.128.51:from]; R_DKIM_ALLOW(-0.20)[tu-dortmund.de:s=unimail]; MIME_GOOD(-0.10)[text/plain]; RWL_MAILSPIKE_GOOD(-0.10)[129.217.128.51:from]; RCPT_COUNT_SEVEN(0.00)[7]; DKIM_TRACE(0.00)[tu-dortmund.de:+]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-main@freebsd.org,dev-commits-ports-all@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:680, ipnet:129.217.0.0/16, country:DE]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[tu-dortmund.de]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 4Pw8G113bFz4LYt X-Spamd-Bar: ----- X-ThisMailContainsUnwantedMimeParts: N Am 06.04.23 um 23:36 schrieb Dima Panov: > Moin-moin! > > On 06.04.2023 16:32, Alexey Dokuchaev wrote: >> On Thu, Apr 06, 2023 at 03:19:55PM +0200, Guido Falsi wrote: >>> On 06/04/23 15:17, Alexey Dokuchaev wrote: >>>> On Wed, Apr 05, 2023 at 02:20:21PM +0200, Guido Falsi wrote: >>>>> On 05/04/23 08:15, Daniel Engberg wrote: >>>>>> commit 72ad532057c9f9fb6fa370c80f663c005e9dd021 >>>>>> >>>>>>        archivers/zstd: Add CMake config files and adjust Makefile >>>>>>        - Use upstream's short test for "make test" >>>>>>        - Use verbose output by default during build >>>>>>        * Tweak Makefile to follow Porters Handbook more closely >>>>>>        * Install CMake files (taken from CMake build framework) >>>>>>        PR:             267652 >>>>>>        Reported by:    fluffy >>>>>>        Approved by:    portmgr (maintainer timeout, 1+ month) >>>>> >>>>> Looks like this, un[luckily], causes a failure with devel/qt6-base >>>>> (abridged error, full log if needed): >>>>> >>>>> ld: error: relocation R_X86_64_32 cannot be used against local symbol; >>>>> recompile with -fPIC >>>>>    >>> defined in /usr/local/lib/libzstd.a(zstd_common.o) >>>>>    >>> referenced by zstd_common.c >>>>>    >>>               zstd_common.o:(ZSTD_versionString) in archive >>>> >>>> Yeah, I'm seeing this as well.  Admittedly, the whole commit looks >>>> dubious to me, with all these out-of-blue new files and gratuitous >>>> changes.  I guess sunpoet@ should revert it and merge only needed >>>> parts thereof properly. > > Nope. > This commit unmasked the real problem of using autocrap tools to build > zstd -- a broken static library. > Issue was not raised before 'cause cmake configs was absent and qt6 > (and may be other consumers) hooks up only shared lib. > Can you be more specific as to "autocrap tools" or how tools are held responsible for their (inadvertent) abuse by the clueless? You don't blame the screwdriver if a noob tries to drive a nail with the blade you know...