Re: git: 4cda17ab1458 - main - */*: Refactor java/openjdk7 removal
Date: Wed, 05 Apr 2023 16:59:15 UTC
> On Apr 5, 2023, at 5:48 PM, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > > On Tue, Apr 04, 2023 at 06:11:09PM +0000, Muhammad Moinur Rahman wrote: >> commit 4cda17ab14588e6e4fdac7f697e246554ce82af3 >> >> Refactor java/openjdk7 removal >> >> - Since the introduction of jdk version 18 it looks like similar with >> jdk version 8(java version string 1.8). This is prone to error as it >> looks similar and is only seperated by a '.'. Remove using >> JAVA_VERSION with dotted fomat of java version string and update all >> consumers to utilize version 8 instead of 1.8. >> >> @@ -17,7 +17,7 @@ NO_WRKSUBDIR= yes >> >> USES= zip:infozip >> USE_JAVA= yes >> -JAVA_VERSION= 1.8+ >> +JAVA_VERSION= 8+ > > Perhaps we should drop JAVA_VERSION as USE_JAVA accepts versions similar > to USE_GCC; separate JAVA_VERSION is just a needless cognitive burden. > > ./danfe You speak my mind; but one step at a time. That is planned in step 2 and in step 3 I am going to convert this into USES=java. Kind regards, Moin