From nobody Wed Apr 05 15:48:24 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ps8DT0nM0z43fxw; Wed, 5 Apr 2023 15:48:25 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ps8DT0G0Hz3w2y; Wed, 5 Apr 2023 15:48:25 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680709705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kNOI63VUyIcOcUyUnEt5ZUq00eqVxBzZsVB9LfHWHZg=; b=Fl0QlWcb8oiqco5LjEHMwfSAQk/B7A8WzyQPR6LEMHIR1USr6NaGyznua9yv/XLI/DN9/W 9M8lRpgAJZiBd3M9P2UMe4McVS4OSETGJhqh6QQGgKnDrZTFKJUFU/fX/t6EW9q8VeCvhO fld3BpnUffHhemkrd1vl4zeO9TqcpuDXdYmFJQPtudWyXBl//6NBNK9Y0h8q+3zHK6ahQI /6FdLh8sNEfOc4eM+cxyWJL/pDUiVZuEqWLLMCyEgyuiiZpncMo469UoKIvxT0fDvrgQ+E paP1e3Ma21ln1oQwx77a0g68DLQeQI9gbRLeHWBpxvkJaoKG/RQZU96bEJcooQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680709705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kNOI63VUyIcOcUyUnEt5ZUq00eqVxBzZsVB9LfHWHZg=; b=BimNsTw309HpNSMOA6kHjGVpJe6n455r8qy72Y2IHn5gxGEHtkUUbV78BOArdcnVgFUrZJ B36s/Yn0NKXafS67XwLKBZDXd6sXKZu3uXPuNwyqvVoV1f67vQhcwUYnT59Fu7J9Ye/8m0 Li5mAnbKTrZcgWogDtqzhT5NXpszGQEsYZeg5UaDjaMjZK+KkS/7dXDTpL9P0iuPT477km aiXEiZeuri6hYpKiYQs+s/OMS/Y8sFV1UGraeMK4I5M0dB06CAdZ7Jcf4SbfbjjpdwsqVF BYXASkiUsJ2RZIopsyHfxDTrnKs89sjjed5WNYjPseUW14dHaZHelGLdLzZmSQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680709705; a=rsa-sha256; cv=none; b=xJFc9W9Q+1HKg+F3WitbAWtQ3QmY7j7++66n3Jo6K4jYUG52K7Bnkts+xaSGFZZ0+akpmH IOqgxkfh9YCS1UKOmhjmEJ3aVkQeTdAGECT+qSfHdWKxYXwcrzSE2NniF/U3AxIkDoqJjD Z2HCIiir1qrLbr3xPHCtKszjkbzWnaj83YIntCIlG6C/p7KYJ8BPHeoT7Oz23FcJ4XdsfV DGyvnQj8ReIswan/6U1P3kzWz5TyAR+4jxQTR4sNOzkfqLekkbfgQrwia9xW3N47uxRZ6T k4sR2AmErNoY8xSBqL++12pkVkOEKFTEZgo9XWUKCvpMsQ7f91JjwsKtHdndgQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id DB35619F73; Wed, 5 Apr 2023 15:48:24 +0000 (UTC) Date: Wed, 5 Apr 2023 15:48:24 +0000 From: Alexey Dokuchaev To: Muhammad Moinur Rahman Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4cda17ab1458 - main - */*: Refactor java/openjdk7 removal Message-ID: References: <202304041811.334IB93k074119@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202304041811.334IB93k074119@gitrepo.freebsd.org> X-ThisMailContainsUnwantedMimeParts: N On Tue, Apr 04, 2023 at 06:11:09PM +0000, Muhammad Moinur Rahman wrote: > commit 4cda17ab14588e6e4fdac7f697e246554ce82af3 > > Refactor java/openjdk7 removal > > - Since the introduction of jdk version 18 it looks like similar with > jdk version 8(java version string 1.8). This is prone to error as it > looks similar and is only seperated by a '.'. Remove using > JAVA_VERSION with dotted fomat of java version string and update all > consumers to utilize version 8 instead of 1.8. > > @@ -17,7 +17,7 @@ NO_WRKSUBDIR= yes > > USES= zip:infozip > USE_JAVA= yes > -JAVA_VERSION= 1.8+ > +JAVA_VERSION= 8+ Perhaps we should drop JAVA_VERSION as USE_JAVA accepts versions similar to USE_GCC; separate JAVA_VERSION is just a needless cognitive burden. ./danfe