From nobody Thu Sep 29 12:50:29 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MdYB56Dtbz4cnCc; Thu, 29 Sep 2022 12:50:37 +0000 (UTC) (envelope-from rodrigo@osorio.me) Received: from smtp.osorio.me (mvd.osorio.me [5.196.94.126]) by mx1.freebsd.org (Postfix) with ESMTP id 4MdYB55TGpz3csX; Thu, 29 Sep 2022 12:50:37 +0000 (UTC) (envelope-from rodrigo@osorio.me) Received: from [192.168.75.89] (ns3309494.ip-5-135-160.eu [5.135.160.30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.osorio.me (Postfix) with ESMTPSA id 69A0119A4EA; Thu, 29 Sep 2022 12:50:29 +0000 (UTC) Message-ID: Date: Thu, 29 Sep 2022 14:50:29 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: git: 690a4c91c944 - main - sysutils/bsdebfetch: + Simple system info tool in bash Content-Language: en-US To: Piotr Kubaj , =?UTF-8?Q?Fernando_Apestegu=c3=ada?= Cc: Gleb Popov , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202209291218.28TCI0G0066014@gitrepo.freebsd.org> From: Rodrigo Osorio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4MdYB55TGpz3csX X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[] X-ThisMailContainsUnwantedMimeParts: N Hi, Sorry but I have to complain, the he package name is confusing bsdebfetch is a bsdinfo like tool write in shell -see the console output in the git repo[1] - and not a fetch tool. In my opinion a port for a wrapper around a couple of shell commands is probably not the best candidate for packaging, but If you wrote a bsd dedicated tool, having bsd in its own name at least try to chose a proper license and GPLv3 is clearly not my first choice. My two cents, -- rodrigo [1] https://git.sr.ht/~shiorid/bsdebfetch/blob/main/screenshot.png On 9/29/22 14:35, Piotr Kubaj wrote: > Add rsfetch :) > > On 22-09-29 14:27:30, Fernando Apesteguía wrote: >> On Thu, Sep 29, 2022 at 2:18 PM Gleb Popov wrote: >>> The branch main has been updated by arrowd: >>> >>> URL: https://cgit.FreeBSD.org/ports/commit/?id=690a4c91c9449548ae9f2c0c867694970e12d110 >>> >>> commit 690a4c91c9449548ae9f2c0c867694970e12d110 >>> Author: Filipe da Silva Santos >>> AuthorDate: 2022-09-29 11:50:29 +0000 >>> Commit: Gleb Popov >>> CommitDate: 2022-09-29 12:17:37 +0000 >>> >>> sysutils/bsdebfetch: + Simple system info tool in bash >>> >>> Summary: >>> BSDebfetch is a simple yet beautiful system information tool for FreeBSD >>> based on Debfetch, written in GNU Bash. >> Not that I complain, but how many of these do we have now in the ports? :-) >> >> neofetch >> onefetch >> pfetch >> screenfetch >> ufetch >> >> How different are they from each other? >> I talked a submitter out of committing another similar one because as >> he admitted, it did not add any value in terms of new features >> whatsoever. >> >> Cheers. >>> WWW: https://git.sr.ht/~shiorid/bsdebfetch >>> >>> Test Plan: Both ` poudriere testport` and `portlint -A` doesn't complain. >>> >>> Reviewed by: arrowd >>> >>> Differential Revision: https://reviews.freebsd.org/D34337 >>> --- >>> sysutils/Makefile | 1 + >>> sysutils/bsdebfetch/Makefile | 21 +++++++++++++++++++++ >>> sysutils/bsdebfetch/distinfo | 3 +++ >>> sysutils/bsdebfetch/pkg-descr | 2 ++ >>> 4 files changed, 27 insertions(+) >>> >>> diff --git a/sysutils/Makefile b/sysutils/Makefile >>> index 9e88daddf4ef..f99cabdb71c0 100644 >>> --- a/sysutils/Makefile >>> +++ b/sysutils/Makefile >>> @@ -138,6 +138,7 @@ >>> SUBDIR += bsd-splash-changer >>> SUBDIR += bsdconfig >>> SUBDIR += bsdcrashtar >>> + SUBDIR += bsdebfetch >>> SUBDIR += bsdfan >>> SUBDIR += bsdhwmon >>> SUBDIR += bsdinfo >>> diff --git a/sysutils/bsdebfetch/Makefile b/sysutils/bsdebfetch/Makefile >>> new file mode 100644 >>> index 000000000000..811d1c7c8c45 >>> --- /dev/null >>> +++ b/sysutils/bsdebfetch/Makefile >>> @@ -0,0 +1,21 @@ >>> +PORTNAME= bsdebfetch >>> +DISTVERSION= 1.1-bsd >>> +CATEGORIES= sysutils >>> +MASTER_SITES= https://git.sr.ht/~shiorid/${PORTNAME}/archive/${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/ >>> + >>> +MAINTAINER= ports@shiori.com.br >>> +COMMENT= Simple system info tool written in bash >>> +WWW= https://git.sr.ht/~shiorid/bsdebfetch >>> + >>> +LICENSE= GPLv3 >>> +LICENSE_FILE= ${WRKSRC}/LICENSE >>> + >>> +RUN_DEPENDS= bash:shells/bash >>> + >>> +NO_ARCH= yes >>> +NO_BUILD= yes >>> + >>> +PLIST_FILES= bin/bsdebfetch \ >>> + share/man/man1/bsdebfetch.1.gz >>> + >>> +.include >>> diff --git a/sysutils/bsdebfetch/distinfo b/sysutils/bsdebfetch/distinfo >>> new file mode 100644 >>> index 000000000000..13e293fdae6b >>> --- /dev/null >>> +++ b/sysutils/bsdebfetch/distinfo >>> @@ -0,0 +1,3 @@ >>> +TIMESTAMP = 1645509241 >>> +SHA256 (bsdebfetch-1.1-bsd.tar.gz) = b3eba6f94e7a3f57769b3a90a10276a6ffefc9ad1f2802e75c9a3031ab21197f >>> +SIZE (bsdebfetch-1.1-bsd.tar.gz) = 40372 >>> diff --git a/sysutils/bsdebfetch/pkg-descr b/sysutils/bsdebfetch/pkg-descr >>> new file mode 100644 >>> index 000000000000..d2ec4acee9ac >>> --- /dev/null >>> +++ b/sysutils/bsdebfetch/pkg-descr >>> @@ -0,0 +1,2 @@ >>> +BSDebfetch is a simple yet beautiful system information tool for FreeBSD >>> +based on Debfetch, written in GNU Bash.