From nobody Tue Sep 27 13:50:51 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4McLcl3j9Jz4d3KM; Tue, 27 Sep 2022 13:51:03 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4McLcl3FhMz3Xwh; Tue, 27 Sep 2022 13:51:03 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664286663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PoQ8vM1Sy1dwRDNHuoVqQzhyLeV637ZipCKVsWf38No=; b=ZUd18ow0nJj7uJGul7J5jFJHYBF5W26zTfOjByfkJU1g/1latAyvSUnOUCC3GinZs96bqc J+7T0wFS2MZhcI3V3DAuXLzvZrjwRxL+2VZlQVPEEeEGok0VG04CyA0SJ4hzmBwNt05A3z UquRQV1d7iVjJeUZvo0GBT/tseHEzKymL/KbyK39VyZhTOZkUtD+1PhG6WOik1sX5PW3n4 rWgI+rx5CtDGH6ZQ1GDQIOrpbcW3J7OaSZd3V5/cBx0prNJxF5IZwZHViznDWci2TMGTAj tRCkUng1BDtAhOUgkVlelnTUbjMWDjRzwZyS6pPo/XExgVAFPP1gMh4DyKPJXg== Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4McLcl295czmSs; Tue, 27 Sep 2022 13:51:03 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-vs1-f41.google.com with SMTP id d187so9722600vsd.6; Tue, 27 Sep 2022 06:51:03 -0700 (PDT) X-Gm-Message-State: ACrzQf0Adsa/HtbXwztLsViVDa1NE1zD+WM8jIDt7TrHhAl6VctyR0RB Zet03k2qc83aYXCk96YwZsx8H6jjPCUFVJzp7IM= X-Google-Smtp-Source: AMsMyM51Y3kRYMw69oXlOmpAgl+NnVJ/b9dYRa9PxW/9Ya7vecU2xCzq2vNuw8VHHE41MrA8AJLpTFCsuRn5F1Vve9c= X-Received: by 2002:a05:6102:2005:b0:398:cc09:ba3d with SMTP id p5-20020a056102200500b00398cc09ba3dmr10680548vsr.53.1664286662568; Tue, 27 Sep 2022 06:51:02 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202209261903.28QJ3knH012930@gitrepo.freebsd.org> In-Reply-To: From: Nuno Teixeira Date: Tue, 27 Sep 2022 14:50:51 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 860ce9aee61a - main - security/picocrypt: Whitelist 64-bit archs To: Alexey Dokuchaev Cc: "ports-committers@FreeBSD.org" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000053b08305e9a8efb3" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664286663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PoQ8vM1Sy1dwRDNHuoVqQzhyLeV637ZipCKVsWf38No=; b=SHv6w+0c5VAjlcojz7/otNhPQBP7L5cqyg9IobDvLbd4FqD7HKU2YqdOv3Td9wD/gXW3+1 7oTdjOpG2eiSO/NK6H1KIUhrtWsq4ql5Els77V6LY0D8ni+e5aWubSCj2tCigMMHq1GLsa S4+ljKRYnrs8SFxPY9AGawHkRvogrbiKSI3bjH5w54j0OSo7+yDin6ypXSCy/hMCER9dVc 5adws+koEfD4qXh/b74qZwdsdmlEgOFnSW4Tc+j8/M+cuOuZpRkE73kHJrICJISmU0D4Kv L91OsAo3c04imQ41Dhf6/Y6qFV9Yh2ga0cxLkJEwwZw5pcYCkE3egQYf6q7jmA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1664286663; a=rsa-sha256; cv=none; b=sRQvhn5I1yCIEJr/aGHoo0ONodlNICO/dcm3yi5naULexoJYF+mifxekxauAkwmx6fEdgC LkTr/PUobBqyJJHtKILvB34wdY5mIL5lsBLVJtlxOBMZaCFUl2fIFioLffKjpLaqrz1WIJ qEiB/i16NFb+S/Lbt8GK7zHICOPA8L0Z061oVSuwFcChC9VpiRpHD84is9xYGtoetZ3Dea U9b1/4fTBjonpikjROnjensa6DtT4/hJ7da0YMoJbn7iqqmA07O3CxWbJZNPRybpbc7+l8 RnFQKnJBm/QBk5psV6J2F6iWAw1/GDfN1AbVvYfb072TEZw4n68KMtZocGg8IA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --00000000000053b08305e9a8efb3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Alexey, Yes you are right, blacklist is shorter and best option to use since list will be smaller in the future. NOT_FOR_ARCHS=3D i386 armv6 armv7 mips powerpc powerpcspe Coul you take a look before I commit? Thanks, Nuno Alexey Dokuchaev escreveu no dia ter=C3=A7a, 27/09/2022= =C3=A0(s) 03:36: > On Mon, Sep 26, 2022 at 07:03:46PM +0000, Nuno Teixeira wrote: > > commit 860ce9aee61aacd34f0b1c29d54f44dd86168835 > > > > security/picocrypt: Whitelist 64-bit archs > > This is not the best approach, I'll elaborate more on this below. > > > - Upstream only supports 64-bit > > Can they be convinced to enable it again? When I first ported this > program it definitely compiled everywhere, albeit I don't recall if > I tried to run it on my i386 desktop. > > > +ONLY_FOR_ARCHS=3D amd64 arm64 mips64 powerpc64 powerpc64le riscv6= 4 > sparc64 > > +ONLY_FOR_ARCHS_REASON=3D upstream only supports 64-bit > > 64-bit list is more likely to change than 32-bit and is also much shorter > (i386, arv{6,7}), so if you prefer arch limitation over fixing the bug th= an > NOT_FOR_ARCHS is better as it entails less churn over time. Also, suppor= t > for sparc64 is pretty much dropped (and even when it was kind of supporte= d, > we stopped building packages for it for a long time), less sure of mips64 > but I think it had been phased out in src land recently as well. > > ./danfe > --=20 Nuno Teixeira FreeBSD Committer (ports) --00000000000053b08305e9a8efb3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Alexey,

Yes you are right, blacklist is = shorter and best option to use since list will be smaller in the future.

NOT_FOR_ARCHS=3D i386 armv6 armv7 mips powerpc p= owerpcspe

Coul you take a look before I commit?

Thanks,
Nuno

Alexey Dokuchaev <= ;danfe@freebsd.org> escreveu no= dia ter=C3=A7a, 27/09/2022 =C3=A0(s) 03:36:
On Mon, Sep 26, 2022 at 07:03:46PM +0000, Nuno= Teixeira wrote:
> commit 860ce9aee61aacd34f0b1c29d54f44dd86168835
>
>=C2=A0 =C2=A0security/picocrypt: Whitelist 64-bit archs

This is not the best approach, I'll elaborate more on this below.

>=C2=A0 =C2=A0- Upstream only supports 64-bit

Can they be convinced to enable it again?=C2=A0 When I first ported this program it definitely compiled everywhere, albeit I don't recall if
I tried to run it on my i386 desktop.

> +ONLY_FOR_ARCHS=3D=C2=A0 =C2=A0 =C2=A0 amd64 arm64 mips64 powerpc64 po= werpc64le riscv64 sparc64
> +ONLY_FOR_ARCHS_REASON=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0upstream only supp= orts 64-bit

64-bit list is more likely to change than 32-bit and is also much shorter (i386, arv{6,7}), so if you prefer arch limitation over fixing the bug than=
NOT_FOR_ARCHS is better as it entails less churn over time.=C2=A0 Also, sup= port
for sparc64 is pretty much dropped (and even when it was kind of supported,=
we stopped building packages for it for a long time), less sure of mips64 but I think it had been phased out in src land recently as well.

./danfe


--
Nun= o Teixeira
FreeBSD Committer (ports)
--00000000000053b08305e9a8efb3--