From nobody Tue Sep 27 02:36:09 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mc3f14xjxz4cw4C; Tue, 27 Sep 2022 02:36:09 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mc3f14QjYz3PgM; Tue, 27 Sep 2022 02:36:09 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664246169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7FwZe0lshDGfeNR+2xhC+lB1jEXllRtlIWSHbdvnBbk=; b=jeTxLhEf2Ll9rfh5GUAZOIcCNPYExc/CRmd4CRb8KJ9QzzJmSwZyXjN2IZP89DkEm+2cpZ lUFihOhk6lrMnv82hYrIz089GcY5ERPX5mr1uXXRrqRUWxASy2atlBb6ABh34EuUB8ycHv 66CbioXBaKpV7CyLdM2insLSsCDHxpIkHPaS79JUuEhyOGKFYxE0DTVrLeZCQpjptuZAFA mtVUqTjzNWTGZN7FiNEwumGBqOgPSkKw6S5ck6imOuE/NqnDp3bgJ8ub1x3AXXBom4aiYF l5Rx+1eUBurYTNHJHT4e7W/O1mLZ6RA80zoSol/8gAp3+A4XcJ+XriJR5DsyuA== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 87CA6CED9; Tue, 27 Sep 2022 02:36:09 +0000 (UTC) Date: Tue, 27 Sep 2022 02:36:09 +0000 From: Alexey Dokuchaev To: Nuno Teixeira Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 860ce9aee61a - main - security/picocrypt: Whitelist 64-bit archs Message-ID: References: <202209261903.28QJ3knH012930@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202209261903.28QJ3knH012930@gitrepo.freebsd.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664246169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7FwZe0lshDGfeNR+2xhC+lB1jEXllRtlIWSHbdvnBbk=; b=b8hu1Knne4s/d8yzmi/6jilCo4HtowKEsQ7p/1mM6R9PRICKHXF7Huw2azqAuKN/nT3Chw 4guSP+xrtxpr1If+1lH8jmUbY5Ora+eF1kfPU5SG+MiaK1FI+DcAZ1Qfp4xBtA8qc3HnEg WRBnEDI6Y2HX3s/omKugp8wZRcM0+nUF4TLTrTsjkiCRxR+JId9Temwo5faPCXQaEyH3uo x0jXsJ1U6hstegYdek6lBh7Lrxf3UM0DWiDBoOocXpUT8n4IXyyt0rv9BOabZ4IR7MVfsn rviycZdv3z3Fpr70gxQlydxt4M5wllhfNLlVqmMHaocVvoiLytECxdJ0wl4cew== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1664246169; a=rsa-sha256; cv=none; b=RjCIa/c6zPV0kh/2ijGA9GL0md57T8cOFc6rRlrWa2RJoeTkUgcXInVWukndRqIPyCG1qL I5RpkcgH5jfhD+JDWUhgc8BC52v6zoLaLOzIwLfESRiatbhFb+j8/tRRcTYZgxnKkcoxVl 1sDNIXvhxeVaCJIMisr/no6XRdJlnYq1T/zkU8ojZPtER2Ylx6ijE8yh01e8D5nGg2wzme JmHKuCfc5pgrBmf/FtYhIRGx3dGZwYbZPr82qH6YQgrZt77fACu/I+oGqX3jhxWYMkZhel zd5tpwqVYdsOlVwfSbemMyhzZS53spTa3QVyz787fRoDzPo2Mj0GENdD3unofQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Mon, Sep 26, 2022 at 07:03:46PM +0000, Nuno Teixeira wrote: > commit 860ce9aee61aacd34f0b1c29d54f44dd86168835 > > security/picocrypt: Whitelist 64-bit archs This is not the best approach, I'll elaborate more on this below. > - Upstream only supports 64-bit Can they be convinced to enable it again? When I first ported this program it definitely compiled everywhere, albeit I don't recall if I tried to run it on my i386 desktop. > +ONLY_FOR_ARCHS= amd64 arm64 mips64 powerpc64 powerpc64le riscv64 sparc64 > +ONLY_FOR_ARCHS_REASON= upstream only supports 64-bit 64-bit list is more likely to change than 32-bit and is also much shorter (i386, arv{6,7}), so if you prefer arch limitation over fixing the bug than NOT_FOR_ARCHS is better as it entails less churn over time. Also, support for sparc64 is pretty much dropped (and even when it was kind of supported, we stopped building packages for it for a long time), less sure of mips64 but I think it had been phased out in src land recently as well. ./danfe