From nobody Tue Sep 06 01:18:31 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MM6wS65kcz4bhnj for ; Tue, 6 Sep 2022 01:18:48 +0000 (UTC) (envelope-from adamw@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MM6wS5gX3z3yVn for ; Tue, 6 Sep 2022 01:18:48 +0000 (UTC) (envelope-from adamw@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662427128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j698tgS/jsYvMp+JfLexcXVO/L+998m5bF/Q6EJXxkQ=; b=WRRcF7uJ8pnG0JGt1Jh4Jcg0i7gCbWxENyoekI1qa173lo2zCjDFlSw+zl9SfEfYTAESrZ DwPoTeJPOFuOljt9H2q1Z85zBxJnbWZsOKAtkNMcCkHZDlCMD2U6oE8dY6k+2a8kUIUfyK M/veqIk2nbiIBO2FuIlnSEL0kQDP78zTuF1YuzsYPKKbWlTiaUqzd+4PN+nnX4rhWKcNj3 BX3F4Oz1ifhXQh/GqxxbDy2i2YFOk51nJ4OByE5/hl6KSuaLWroiUyqxnYWWAJyhpD9ddt rs2NnNp9Cw9CA780SKDF90bMHyzbzGX6m5ZfYpZbqgNgUmFPo2qexxSjCmEbyg== Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: adamw/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MM6wS4YrKzx5m for ; Tue, 6 Sep 2022 01:18:48 +0000 (UTC) (envelope-from adamw@freebsd.org) Received: by mail-ej1-f47.google.com with SMTP id se27so19960297ejb.8 for ; Mon, 05 Sep 2022 18:18:48 -0700 (PDT) X-Gm-Message-State: ACgBeo1Dk6tYjQ03PqQRlzAoNRunPsPd5Ri4wrJdodpj1Ciw0CgzsgHd ZALGUNxABzd6UennPTrxh4k/yUwTfFTSTiT65aI4tw== X-Google-Smtp-Source: AA6agR4ju9acX3FBPxNo0P0UTH1RdJ6VtxazAg1Vf4zEwHpOXzIrOMMMtsezE/u/C6iYRdJK2l7uA//F+3fO9eHCDNM= X-Received: by 2002:a17:907:70c:b0:740:33f3:cbab with SMTP id xb12-20020a170907070c00b0074033f3cbabmr33985274ejb.600.1662427127573; Mon, 05 Sep 2022 18:18:47 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202209031633.283GXB0x034705@gitrepo.freebsd.org> <20220906000036.8EE7DFB@slippy.cwsent.com> In-Reply-To: <20220906000036.8EE7DFB@slippy.cwsent.com> From: Adam Weinberger Date: Mon, 5 Sep 2022 19:18:31 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: c51ce87a4ef5 - main - editors/vim-colorschemes-legacy: Add port To: Cy Schubert , michael.osipov@siemens.com Cc: Adam Weinberger , ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000679dde05e7f7fa3f" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662427128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j698tgS/jsYvMp+JfLexcXVO/L+998m5bF/Q6EJXxkQ=; b=S8cWR1wQGIIUXDC5/2xB6QVEVfcW23/K+GoxjrcGHt6xD1DT2Uj7HKc3WEaaNaa93Ae0W0 OUmappYhn28pze4vqsPgx7af90My2853WQHj/cciWbCQ+ONIQH33s9uQJGSbDYTVAMiUfj YLSuequEJ2f3RLxRwKYK/Ud3MJRikyexMT9ItPR0k83s+2j8ei2ACRBZ0R7So+3lG+5NyX Jo+3eecPWQR2d/QFcMIRS3w1s/Ju9C/LJiQBA4lePY3mmxT352gcF47YYSs4yqvLT6gvGo N1LisO1rTC/R6lQnIOCDqESBWivIrdCcAspwWANK6lLV/FRfgP42iJowpmZT2Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662427128; a=rsa-sha256; cv=none; b=kjMcvKGFUDLc9Q51FwSG6udvHgVl263wYdzKuLVoEwe6yY/enWrxM5OOeSL4o360ICdvLt Y+PEedVEEQOCnaywJ5PgkM2hQDRVO+70dMy1srReiajqN/kd30oghGAq+cr2utZxBoBgEw +IvRkMrI5ukJadN6erFTOU+8oVks5Eth+yVUyVKk6KcigM2XCX7Xt19VcDMLNzNVJBii/j MDQg/+ioVXtF0RCF+2XSDTs6Eg1sjIGSvJhUHDR5UcxcoP0HHSmfpMXoXsUfo/NK5WaPFA 1alJ+DIYPqgXft75UfgQjtxhuRH+kbhOKt3BPZtUr+kf5UBqCPkbFuI3AyinFQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --000000000000679dde05e7f7fa3f Content-Type: text/plain; charset="UTF-8" On Mon, Sep 5, 2022 at 6:00 PM Cy Schubert wrote: > In message <202209031633.283GXB0x034705@gitrepo.freebsd.org>, Adam > Weinberger w > rites: > > The branch main has been updated by adamw: > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=c51ce87a4ef535f7df2c31bbf8b1cb > > d1a0f1d579 > > > > commit c51ce87a4ef535f7df2c31bbf8b1cbd1a0f1d579 > > Author: Adam Weinberger > > AuthorDate: 2022-09-03 16:26:48 +0000 > > Commit: Adam Weinberger > > CommitDate: 2022-09-03 16:26:48 +0000 > > > > editors/vim-colorschemes-legacy: Add port > > > > Upstream vim modernized their colorschemes, which is a good thing. > > However, the look of them has changed, which is jarring at best for > > users used to the original look. > > > > Upstream colorscheme development was split into a new repo, and the > > original colorschemes were imported there. This port installs those > > colorschemes. > > > > The rest of that repo are the colorschemes included in vim, so > there's > > not really any benefit to packaging anything else from it. > > > > PR: 265798 > > --- > > editors/Makefile | 1 + > > editors/vim-colorschemes-legacy/Makefile | 33 ++++++++++++ > > editors/vim-colorschemes-legacy/distinfo | 3 ++ > > editors/vim-colorschemes-legacy/files/LICENSE | 78 > +++++++++++++++++++++++++ > > ++ > > editors/vim-colorschemes-legacy/pkg-descr | 7 +++ > > editors/vim-colorschemes-legacy/pkg-plist | 17 ++++++ > > 6 files changed, 139 insertions(+) > > > > diff --git a/editors/Makefile b/editors/Makefile > > index 2a49e4899e93..2f7ab5ece415 100644 > > --- a/editors/Makefile > > +++ b/editors/Makefile > > @@ -268,6 +268,7 @@ > > SUBDIR += vigor > > SUBDIR += vile > > SUBDIR += vim > > + SUBDIR += vim-colorschemes-legacy > > SUBDIR += vscode > > SUBDIR += web-mode > > SUBDIR += with-editor > > diff --git a/editors/vim-colorschemes-legacy/Makefile > b/editors/vim-colorsche > > mes-legacy/Makefile > > new file mode 100644 > > index 000000000000..b5c1ad467ada > > --- /dev/null > > +++ b/editors/vim-colorschemes-legacy/Makefile > > @@ -0,0 +1,33 @@ > > +PORTNAME= vim-colorschemes-legacy > > +DISTVERSION= g20220816 > > +CATEGORIES= editors > > + > > +MAINTAINER= michael.osipov@siemens.com > > +COMMENT= Legacy colorschemes for Vim > > + > > +LICENSE= VIM > > +LICENSE_NAME= VIM License > > +LICENSE_FILE= ${FILESDIR}/LICENSE > > +LICENSE_PERMS= dist-mirror dist-sell pkg-mirror pkg-sell > auto-accept > > + > > +RUN_DEPENDS= vim:editors/vim > > Those who install vim-gtk* or vim-motif will notice that pkg install will > uninstall the GUI version of vim and install vim-console. > Good catch, Cy. This port doesn't actually depend on Vim and is usable by all Vim flavors (and neovim!). It does need a Vim parser of some sort to do any good, but even things like vimpager and nvimpager can use it. Michael, I'd suggest removing the RUN_DEPENDS entirely. Also, reading up on it more, this should probably go into LOCALBASE/vim/vimfiles/colors/legacy rather than in Vim's (private) runtime library path. You good with those two changes? # Adam -- Adam Weinberger adamw@adamw.org // adamw@FreeBSD.org https://www.adamw.org --000000000000679dde05e7f7fa3f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


<= div dir=3D"ltr" class=3D"gmail_attr">On Mon, Sep 5, 2022 at 6:00 PM Cy Schu= bert <Cy.Schubert@cschubert= .com> wrote:
In message <202209031633.283GXB0x034705@gitrepo.freebsd.or= g>, Adam
Weinberger w
rites:
> The branch main has been updated by adamw:
>
> URL: https://cgit.Fre= eBSD.org/ports/commit/?id=3Dc51ce87a4ef535f7df2c31bbf8b1cb
> d1a0f1d579
>
> commit c51ce87a4ef535f7df2c31bbf8b1cbd1a0f1d579
> Author:=C2=A0 =C2=A0 =C2=A0Adam Weinberger <adamw@FreeBSD.org> > AuthorDate: 2022-09-03 16:26:48 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Adam Weinberger <adamw@FreeBSD.org> > CommitDate: 2022-09-03 16:26:48 +0000
>
>=C2=A0 =C2=A0 =C2=A0editors/vim-colorschemes-legacy: Add port
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0Upstream vim modernized their colorschemes, which i= s a good thing.
>=C2=A0 =C2=A0 =C2=A0However, the look of them has changed, which is jar= ring at best for
>=C2=A0 =C2=A0 =C2=A0users used to the original look.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0Upstream colorscheme development was split into a n= ew repo, and the
>=C2=A0 =C2=A0 =C2=A0original colorschemes were imported there. This por= t installs those
>=C2=A0 =C2=A0 =C2=A0colorschemes.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0The rest of that repo are the colorschemes included= in vim, so there's
>=C2=A0 =C2=A0 =C2=A0not really any benefit to packaging anything else f= rom it.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= 265798
> ---
>=C2=A0 editors/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 1 +
>=C2=A0 editors/vim-colorschemes-legacy/Makefile=C2=A0 =C2=A0 =C2=A0 | 3= 3 ++++++++++++
>=C2=A0 editors/vim-colorschemes-legacy/distinfo=C2=A0 =C2=A0 =C2=A0 |= =C2=A0 3 ++
>=C2=A0 editors/vim-colorschemes-legacy/files/LICENSE | 78 +++++++++++++= ++++++++++++
> ++
>=C2=A0 editors/vim-colorschemes-legacy/pkg-descr=C2=A0 =C2=A0 =C2=A0|= =C2=A0 7 +++
>=C2=A0 editors/vim-colorschemes-legacy/pkg-plist=C2=A0 =C2=A0 =C2=A0| 1= 7 ++++++
>=C2=A0 6 files changed, 139 insertions(+)
>
> diff --git a/editors/Makefile b/editors/Makefile
> index 2a49e4899e93..2f7ab5ece415 100644
> --- a/editors/Makefile
> +++ b/editors/Makefile
> @@ -268,6 +268,7 @@
>=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D vigor
>=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D vile
>=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D vim
> +=C2=A0 =C2=A0 SUBDIR +=3D vim-colorschemes-legacy
>=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D vscode
>=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D web-mode
>=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D with-editor
> diff --git a/editors/vim-colorschemes-legacy/Makefile b/editors/vim-co= lorsche
> mes-legacy/Makefile
> new file mode 100644
> index 000000000000..b5c1ad467ada
> --- /dev/null
> +++ b/editors/vim-colorschemes-legacy/Makefile
> @@ -0,0 +1,33 @@
> +PORTNAME=3D=C2=A0 =C2=A0 vim-colorschemes-legacy
> +DISTVERSION=3D g20220816
> +CATEGORIES=3D=C2=A0 editors
> +
> +MAINTAINER=3D=C2=A0 michael.osipov@siemens.com
> +COMMENT=3D=C2=A0 =C2=A0 =C2=A0Legacy colorschemes for Vim
> +
> +LICENSE=3D=C2=A0 =C2=A0 =C2=A0VIM
> +LICENSE_NAME=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 VIM License
> +LICENSE_FILE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 ${FILESDIR}/LICENSE
> +LICENSE_PERMS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0dist-mirror dist-sell pkg-= mirror pkg-sell auto-accept
> +
> +RUN_DEPENDS=3D vim:editors/vim

Those who install vim-gtk* or vim-motif will notice that pkg install will <= br> uninstall the GUI version of vim and install vim-console.
<= div>
Good catch, Cy.

This port doesn't actually depend on Vim and is= usable by all Vim flavors (and neovim!). It does need a Vim parser of some= sort to do any good, but even things like vimpager and nvimpager can use i= t.

Michael, I'd suggest removing the RUN_DEPEND= S entirely. Also, reading up on it more, this should probably go into LOCAL= BASE/vim/vimfiles/colors/legacy rather than in Vim's (private) runtime = library path. You good with those two changes?

# Adam

<= br>--
Adam Weinberger
adamw@adamw.org // ad= amw@FreeBSD.org
http= s://www.adamw.org
--000000000000679dde05e7f7fa3f--