From nobody Sun Oct 16 12:21:09 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MqzkV0q2yz4g4qf; Sun, 16 Oct 2022 12:21:22 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MqzkV0PNtz3Hg3; Sun, 16 Oct 2022 12:21:22 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665922882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tvuYXYbamZ9OxB0TW8+r8HwqYd+Ta0mZONfL34Om5sQ=; b=I0vn4AbvYWtkv6VAZNvo2jP59LAfz71shtv2YzIpVQP4rLBPNejNEBGrF/0zL+KtHNPjxC d0YbC0/lZ72XYmhhlgKecvH/TpMsCNTnbDnTjVqL4oQxbIwdbTkhnW94XFc1gKd85Wrd4w vkC9Yo87F7F+0obs2H38jUNJLOwbO2nbZLZy4eamAc4jpOuLvnSFO/w8sOMU6ykDRnpfys W+vW/cGahDNJD9S7hw8Zir4ehDQtsj0ywxEWlrHVPAd9vXD+JmDRaxsTmLab1IZ4k43Umd w0WqgCMTeyqaldLgHHuPjCaC/jw1S5iKFS+kHEM+ZGGqgcOF44qZ5GYjJR67YQ== Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MqzkT6VQVz1NjQ; Sun, 16 Oct 2022 12:21:21 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-vs1-f46.google.com with SMTP id x66so402546vsb.3; Sun, 16 Oct 2022 05:21:21 -0700 (PDT) X-Gm-Message-State: ACrzQf0jvEQ8P4oQmPTviRBsncCJgVz7v0TupTfDkGdVaJAtvuUBNSTV VBDFmUU7DaucPtIUgNhQncVNdXg5qbYPPRon34A= X-Google-Smtp-Source: AMsMyM7vcfQIpRxSUmD3pBk2g41JEPUvoYHSiRW06855F7rdCT9nwlfDl+HOlH14j7qqz297FvpBWuKd9wHBJtX7aGE= X-Received: by 2002:a67:d78f:0:b0:3a7:60cc:94f2 with SMTP id q15-20020a67d78f000000b003a760cc94f2mr2282838vsj.19.1665922881358; Sun, 16 Oct 2022 05:21:21 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202210121908.29CJ8aGO082553@gitrepo.freebsd.org> <20221013134520.vresa2tbdkflowdw@aniel.nours.eu> <20221016083759.vx46x6ei7if6dxuy@aching.in.mat.cc> In-Reply-To: <20221016083759.vx46x6ei7if6dxuy@aching.in.mat.cc> From: Nuno Teixeira Date: Sun, 16 Oct 2022 13:21:09 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 2b9b771202b2 - main - www/luakit-devel: update to 2.3.1-6 To: Mathieu Arnold Cc: Baptiste Daroussin , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000091103705eb25e5c0" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665922882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tvuYXYbamZ9OxB0TW8+r8HwqYd+Ta0mZONfL34Om5sQ=; b=GvOKsWWgD37nwt52NdhMK6lBBe6s4vCkf+N+xeMkIvn+OP7bS1Ldd7+mDqInjP3Qg53DQr CTWjRF8ODCAEhzcdbDsdFKuti9KPDipg4TnJ4TMYl+fk9ZPAGS/HcU2KBcwiQ1c9bYyM09 pnBZROwq4laD+7rwhsbgLJrebt57w7uKA4KEWTMDZr1RwU3xlH8A0O6y2QCgdu9qDszN8/ kWwuicOLc6A7klZjybIpcNkFcyMmjvqhRNa5vAOHumj5PRJK+QgyyMEe441ncllwBBSBKM ReS34ounDhXjol7wzs3S9bnkL7qU0yM9lr0fIOyrB0b3KaIjHfwAQglg0iujWg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1665922882; a=rsa-sha256; cv=none; b=DZl7q6y3x5AYA9m2Veno8bfv4y6kfn33sdZpgE4H6FNWnHKrBkzt6kwXvUZM/LgDG1pdmE uCgE0P7KwkrwU8cXHRJJ+LvoZJ1wn9A/gyUoLD0pdL/j2IMZx0HCq7wr2dK34mTdD7/AWl YPb71+O2mbB6PXzKsaoGWM1jSoQAIJ5SoWMZqgjsTf+dSKCGA3gQoM70ihiudlWpdyqF2u kPtzIL1qA6kwtAB5HCTmtjK5rmCvybhfTb4fbTcLPazOSe6df8NRcz9dcDHTgAYG+ff0s2 xbEK8Ub0RcFSYgS6FZ1oX4Ng2Jug+CQd0v5cvm029Ek8U+K3VPoxcIy4OHbgVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --00000000000091103705eb25e5c0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, portepoch should be used with caution and when is no chance to avoid it, e.g., upstream versioning changes. That's not the case on this port that suffers from a bad version design from the beginning: First portepoch: 2.2.8 -> 2.2.1*-16* Second portepoch (actual): 2.3-26 -> 2.3.1*-6* *-* is the number of commits In the future will be more portepoch bumping due to '*-'* being interpertated as '*.'* IMHO, solution is to think in a better port versioning. I will talk with maintainer to see what is his opinion. Thanks Mathieu Arnold escreveu no dia domingo, 16/10/2022 =C3=A0= (s) 09:38: > On Sun, Oct 16, 2022 at 01:12:19AM +0100, Nuno Teixeira wrote: > > Hello, > > > > Yes, you are right > > pkg version -t 2.3.1.6,1 2.3.26,1 =3D=3D < > > > > -DISTVERSION=3D 2.3-26 > > +DISTVERSION=3D 2.3.1-6 > > > > This will cause problems in the future and we cannot bump PORTEPOCH for > > this reason. > > This is exactly what PORTEPOCH is for, so I do not understand your > sentence. > > -- > Mathieu Arnold > --=20 Nuno Teixeira FreeBSD Committer (ports) --00000000000091103705eb25e5c0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

portepoch should be used= with caution and when is no chance to avoid it, e.g., upstream versioning = changes.

That's not the case on this port that= suffers from a bad version design from the beginning:

=
First portepoch: 2.2.8 -> 2.2.1-16
Second portepoc= h (actual): 2.3-26 -> = 2.3.1-6

-<commits count> is the number of commits
In the future will be more portepoch bumping due to '-'<= commits count> being interpertated as '.'<committs cou= nt>

IMHO, solution is to think in a better port versioning.

I = will talk with maintainer to see what is his opinion.

=
Thanks

Mathieu Arnold <mat@f= reebsd.org> escreveu no dia domingo, 16/10/2022 =C3=A0(s) 09:38:
=
On Sun, Oct 16, 202= 2 at 01:12:19AM +0100, Nuno Teixeira wrote:
> Hello,
>
> Yes, you are right
> pkg version -t 2.3.1.6,1 2.3.26,1 =3D=3D <
>
> -DISTVERSION=3D 2.3-26
> +DISTVERSION=3D 2.3.1-6
>
> This will cause problems in the future and we cannot bump PORTEPOCH fo= r
> this reason.

This is exactly what PORTEPOCH is for, so I do not understand your
sentence.

--
Mathieu Arnold


--
Nun= o Teixeira
FreeBSD Committer (ports)
--00000000000091103705eb25e5c0--