From nobody Fri Oct 14 19:17:25 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mpx3q1f8Sz4g5nP for ; Fri, 14 Oct 2022 19:17:43 +0000 (UTC) (envelope-from adamw@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mpx3q17ZXz3VZM for ; Fri, 14 Oct 2022 19:17:43 +0000 (UTC) (envelope-from adamw@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665775063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GgdGyenfUrDxJoUWaFgaci+HSHZVwoEvR+af+YuIYnA=; b=YA6s7uKJSqMlAxqDLO4+nmcEgfBozUrg+aQHFoQXbXYG324jRoM25/Wr9J85FQKz7EkXPP EaPiCRXmLYjsGDIOlaDauq/1MXkpJR7xYNCII0F67V+qVOSzWBbXymmVrr7EfLOmeTnN7x QNacEpNuoCVMm938FddKAxq5gO5ca8O6fMf04/Uz8kre6yGZwvRfXIfeiw/SpblalpyZwp YOX2uujEw3QhUx+jmwi9WzHHBAADkrP0AI5nLoHR1cg/YrKvl5PGO3rY/SJwpTUSw1peho AnFNw/bL6aUjgpOlnrJLzMMx1sm8mXFnGGN5UR2UJhEgYPSyEUPj2YikRBkxlA== Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: adamw/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Mpx3q0BpNz1FLM for ; Fri, 14 Oct 2022 19:17:43 +0000 (UTC) (envelope-from adamw@freebsd.org) Received: by mail-ed1-f51.google.com with SMTP id l22so8136768edj.5 for ; Fri, 14 Oct 2022 12:17:42 -0700 (PDT) X-Gm-Message-State: ACrzQf3lgi4Fo29Dlq9/d/G3nxaW970TcvL2IpvqJN5W2aO1UwDs4YNj mT5nCEYg1J4Egq97Wdo2hHNKdmFOo1wcWA4ZZ9hcWg== X-Google-Smtp-Source: AMsMyM5Z5M2WWde9rJuo1qKl+ypb/R4K/ttmKY+PWNYuLFeY9cb2amOPJEzR8RP8Pr0jmf9GaszJEFF/65vPqLcnXDc= X-Received: by 2002:a05:6402:2710:b0:45c:d7b4:6948 with SMTP id y16-20020a056402271000b0045cd7b46948mr5429267edd.215.1665775061500; Fri, 14 Oct 2022 12:17:41 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202210141707.29EH7i08013647@gitrepo.freebsd.org> In-Reply-To: From: Adam Weinberger Date: Fri, 14 Oct 2022 13:17:25 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 9d241a90370c - main - Mk: Add USES=luajit To: Jan Beich Cc: Adam Weinberger , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000d122d705eb037a05" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665775063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GgdGyenfUrDxJoUWaFgaci+HSHZVwoEvR+af+YuIYnA=; b=f1/KsUAaEEpAu5KxiFc7HOyiKvlcLHlmSK2oALXoPaDfGj0+qImqrlVp6FqJvKEXCmJiiE SWEdDC7Uk6BItVr7FEWqXzv1wNBTsiQT/4FbtzbbaB7h+bdb/H8tSfJGgIn7h3J/i3ShFW M1qGV2HEFLaD5zaumHPClFmRggaQ3UReqa5hXKYYZnPccBbLVVyWtvVyog35+baL2VNbAB xhKXwBI+zrBe/OSn7HXbtawb2J90Gi6k7+su27c1Od0JekqUhLw+WcCCKiRuyltC94wDzb mOu8h39WdMZACftFZVru0NxYj8kre9cagA6qUNBeHxECHeMtFkkBvuk9Lc/4qQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1665775063; a=rsa-sha256; cv=none; b=lTsYyKPvYE4hR5sMLafFtRhvhSgBGYxX25OHZQjwS0dsC2Yz0pkzDrqvK6/tbkGyGKQaLU blJFg57xpzfBYV8b9bv32mtjUyZYdIgjpSvMfajtdUozuWhG49UomwrSCHL3znPIIHFEfD B/q9SGFlIOCNgAtjfKVwYyvhDM6/xLL7SlibKSBLJGZP9CNLRddfdI9f6f06cUde4n2MDF xIXhsYzmGI0YIMyadDxdi6ZwRCYOGDPQAaRLU9mtw+n4wVkJNev7IL1vEvoXPwQajb95eC YP8VBsnEsJD1Uyjwrstn17GOVCcwEP5HzJFTAd3d4FduLFd3QWyc0bR91fplOw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --000000000000d122d705eb037a05 Content-Type: text/plain; charset="UTF-8" On Fri, Oct 14, 2022 at 12:33 PM Jan Beich wrote: > Adam Weinberger writes: > > > On Fri, Oct 14, 2022 at 11:25 AM Jan Beich wrote: > > > >> Adam Weinberger writes: > >> > >> > For the vast majority of situations, USES=luajit will be > sufficient. > >> > Ports that use openresty's API additions can specify > >> > USES=luajit:openresty. > >> > >> Are consumers to be switched "en masse" or "one by one"? > >> > > > > Hi Jan, > > > > I'm going to switch a couple ports (neovim and luv) right now, but my > > thinking is that perhaps the best approach is two exp-runs. The first run > > can switch everything depending on lang/luajit to USES=luajit. For the > > second run, I'll need to look at everything that depends on > > luajit-openresty to find out whether it uses it because it uses the > > openresty API or because what they actually wanted was "anything other > than > > the old version in lang/luajit." > > > > Does that sound sensible? > > Probably: > - exp-runs can be reduced via local testing as USES=luajit only has ~50 > candidates > - luajit -> luajit-devel is safe due to same upstream and tested by other > distros > - luajit-openresty -> luajit-devel build test may show false negatives[1] > but > ARCH-specific cases are likely safe > > [1] www/openresty and {devel,www}/lua-resty-* build fine with > lang/luajit-devel. > However, not every instance maybe as obvious whether to ask maintainer. > Everything you said sounds very sensible. It sounds more like one-by-one conversion makes the most sense. I could really use help on that if anyone has the time. I don't have a great development machine that I can use to test stuff, so if anybody wants to help with converting it'd be a big help. # Adam -- Adam Weinberger adamw@adamw.org // adamw@FreeBSD.org https://www.adamw.org --000000000000d122d705eb037a05 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


<= div dir=3D"ltr" class=3D"gmail_attr">On Fri, Oct 14, 2022 at 12:33 PM Jan B= eich <jbeich@freebsd.org> w= rote:
Adam Weinb= erger <adamw@free= bsd.org> writes:

> On Fri, Oct 14, 2022 at 11:25 AM Jan Beich <jbeich@freebsd.org> wrote:
>
>> Adam Weinberger <adamw@FreeBSD.org> writes:
>>
>> >=C2=A0 =C2=A0 =C2=A0For the vast majority of situations, USES= =3Dluajit will be sufficient.
>> >=C2=A0 =C2=A0 =C2=A0Ports that use openresty's API additio= ns can specify
>> >=C2=A0 =C2=A0 =C2=A0USES=3Dluajit:openresty.
>>
>> Are consumers to be switched "en masse" or "one by = one"?
>>
>
> Hi Jan,
>
> I'm going to switch a couple ports (neovim and luv) right now, but= my
> thinking is that perhaps the best approach is two exp-runs. The first = run
> can switch everything depending on lang/luajit to USES=3Dluajit. For t= he
> second run, I'll need to look at everything that depends on
> luajit-openresty to find out whether it uses it because it uses the > openresty API or because what they actually wanted was "anything = other than
> the old version in lang/luajit."
>
> Does that sound sensible?

Probably:
- exp-runs can be reduced via local testing as USES=3Dluajit only has ~50 c= andidates
- luajit -> luajit-devel is safe due to same upstream and tested by othe= r distros
- luajit-openresty -> luajit-devel build test may show false negatives[1= ] but
=C2=A0 ARCH-specific cases are likely safe

[1] www/openresty and {devel,www}/lua-resty-* build fine with lang/luajit-d= evel.
=C2=A0 =C2=A0 However, not every instance maybe as obvious whether to ask m= aintainer.

Everything you said sounds very sensible. I= t sounds more like one-by-one conversion makes the most sense. I could real= ly use help on that if anyone has the time. I don't have a great develo= pment machine that I can use to test stuff, so if anybody wants to help wit= h converting it'd be a big help.

# Adam


--
Adam Weinberger
adamw@adamw.org // adamw@FreeBSD.or= g
https://www.adamw.= org --000000000000d122d705eb037a05--