From nobody Wed Oct 12 08:12:58 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MnQPn1F1Xz4fjVc; Wed, 12 Oct 2022 08:13:01 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MnQPn0f3Pz3V05; Wed, 12 Oct 2022 08:13:01 +0000 (UTC) (envelope-from bapt@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665562381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HB9zwhPNu0sl1euNiZ43zwzNtNDhu1QKQmogHBtJZ5M=; b=cwSbOBg8q10JR8VN1lXpainkLPPL9PbbUVUOmCGQnNnr/+6bKaN+i0AdI8IRZGHLSkMRY0 PStk25JX8DovlZJcE8tz+Dgu4uFXv0z5UTIrqWHyUw1WoOuaHBAiUP08BWyw3I1AVkLpid +fi0N2b/aj7FrYnxLFarjGkcX7HAqnk/XG0k95G4si+IIXes7DgOreGW7mEg1i++zP1708 b+32w8ZAaELYYRW4o6/q/I2GoECdhTtoxvod8gWIT/z3lzp+O8+4Z0aeHtrJrik1QYaBlT Y6sW4b8sdNSDughh4fC+zpPmkHCXu6G5l3AWs4l24ZumH85gfj7ZbtuZpWbB3g== Received: from aniel.nours.eu (nours.eu [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MnQPm6Dz5z13D5; Wed, 12 Oct 2022 08:13:00 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id CF94D986AD; Wed, 12 Oct 2022 10:12:58 +0200 (CEST) Date: Wed, 12 Oct 2022 10:12:58 +0200 From: Baptiste Daroussin To: Dan Langille Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 318400ae027b - main - security/acme.sh: Change crontab and add newsyslog Message-ID: <20221012081258.mkxhkc2mbm2w6v4o@aniel.nours.eu> References: <202210112004.29BK4VcO062127@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202210112004.29BK4VcO062127@gitrepo.freebsd.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665562381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HB9zwhPNu0sl1euNiZ43zwzNtNDhu1QKQmogHBtJZ5M=; b=Fe5RCxfvlEKMqdFpz64QyxwlTS9UrmVEAVJYd5VPrLVcJSc2tTRieziswwotH/bYSOku2H CVoYGh90dF9Ww7jY2y2YL9ZjK/4ELdQqRTVYCwxVT6vgP7kf/fhC8QKUI7coc4AJc3/WKc mJZTOTgvF+VmKidnTecLAERR8bMF987uxBDMSmRSZ0YDAX3ueiaI4TspnW6IALvg94H2RH xv4UUAzlBXRaHvGK40mtqElTJF35S/uWZ7apshDwAgP4oKt0kbfKb77OcTvF1FqWdGlhyl 0j3iYkh/XqX34ZphuA7cmnzGPO/BzblNEwLXlcO4bO/4t+7Xwhg8V+sr0DEZ6Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1665562381; a=rsa-sha256; cv=none; b=m+DNXgLQtIwJVnjH9V0mvcfdWEjyJ0VwfCdEHIP6t4VPK26WfHas6ya+FHViamiQcBqnNd eNZ1PNEz5IcvJ/NZ3Xmkqyp2isEc8xV7yvAK1+oSXd3aK6+1GqXJcnFSQSUaYTLdT3W5Bo BDexQnMfq0QAsYmW0p+Z+SA3cBPcirnzW13SFrRH2yS125RD5NbMjLq8EzFuGrVXNOVY2L ZTZ6STpq1ALccK3lagIn9zGSKHE5RRxOj2ivdssFdnhPQ7h3d/DjlubAPRSD+CymMl7DxP i3HnyzhUDGfR4P00ThooCjkaCjMLdm7/hnEJ7eMmqJB65t3sWOyPq+34TEWAyg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Tue, Oct 11, 2022 at 08:04:31PM +0000, Dan Langille wrote: > The branch main has been updated by dvl: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=318400ae027bf074838191f09437c19be5b062ff > > commit 318400ae027bf074838191f09437c19be5b062ff > Author: Dan Langille > AuthorDate: 2022-10-11 20:00:40 +0000 > Commit: Dan Langille > CommitDate: 2022-10-11 20:04:23 +0000 > > security/acme.sh: Change crontab and add newsyslog > > This update may break your install if you were using a symlink to > %%EXAMPLESDIR%%/acme.sh.conf - that file is no longer installed. Instead, > a log rotation configuration is now installed to etc/cron.d/acme.sh.sample > you should modify etc/cron.d/acme.sh to needs. This is very wrong for cron.d because it means 1 the crontab is now run twice. acme.sh.sample and acme.sh are both read by crontab. Second we don't want something to be activated by default, the right way to go is the previous way and let the admin decide if the crontab needs to be activated and create a symlink to do so. Nothing should never activate a crontab by default in our packages. please revert that part, note this is not the case for newsyslog. Best regards, Bapt