From nobody Thu Nov 24 03:16:29 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NHjnn3c3nz4hvQW; Thu, 24 Nov 2022 03:16:29 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NHjnn35Q4z3Dlr; Thu, 24 Nov 2022 03:16:29 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669259789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QFNc9veOjHE3qMYpW/s0aL1mLg44t1OA2VE4U4AeKFI=; b=jbVAhXzI88xpVyueY68CvxHwwo5qip5kz+iJVn6O2/ZlC6oFW7tFMOxsoaOn49ccwtV9fb vLeUXVOxD0Vg+zxLZ2HForLD4ZYqsDOQn4neNA1mz+NyehR+vK7Nn9cfdAfVNPnkaHlkkN Sgtic7IRjPXtr9YS3lSiYKbpYN3IzvKaqM9nc2wr5Ozk/uKV0dXtccexcrtbg6KLI94iub trnSUu/ToS6+wORrPcGdq5WTQ+cbkFiXARquFBl4ckPmjL1N70ckxKKjZ0My7wAMEnr34N HetUUFb78XU31Wg9hqom9DdeL+rD8KQO3VG3kwsWntI0rKDYb8/1EIwLNzi+Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669259789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QFNc9veOjHE3qMYpW/s0aL1mLg44t1OA2VE4U4AeKFI=; b=vfPK2ciWkprU/tYUH0NuE4mFrNccphW/JHrACzw6M70rwDzr5EjhDYstds9ym4tFxW1m/g TTOzAOuGeH94cbIuaW/24RtP+vjdnU8VnjQlhtDmQRUqXZD2ZvwyfC+JMgxeLKXOvBFKro Jy2sXLd+mb7Z1/TkHovhIE31L2vMDQHwrb2l5oib8h7PteqMZE+0BSlU8mkYPBAfF9XB92 I+2DqJns41wj659TtNGJ7eyI06CpO3jjxn03m1OcFDAqD/2P63mi9Kqva5OMFntQ6Bi2zM a52uARy+arIXJQvBDSie23ZLGS1w1qzBI82vHTp4sMrJqYivXUKwH2AirUvOBg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1669259789; a=rsa-sha256; cv=none; b=H1sVRErVrxyYB8GunbX/j8OfQTSfzz3T/7IMNlzAYaCbp7ACy0Ebh1e6VNqUi5npa5xkaL dywRuIAm1lmXrrROs3fxBTItmE9GN3BCoApQclu5OnPhSi4P19Oafvqjd1HrtkMu+ciPrW GYgxVntN6hulk2sqgeOqClsrPABY9EhT7H6qPnr08PyWpqZkeCuj978xFAf/VAhAP1X+Gm HQOiaxLqAgu1OnEfg8j7GNWGYpYEHXVBPDBxggDfHHHCWHo5bzNMbtiUNHygOjdI/sUo7X cMfyr4+aOJm9FTioaF/TrzEU0wuepDvsA4oCgVUZYcyjvCbs9ZuBvHuH8UQljQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 57ED3E7A4; Thu, 24 Nov 2022 03:16:29 +0000 (UTC) Date: Thu, 24 Nov 2022 03:16:29 +0000 From: Alexey Dokuchaev To: Baptiste Daroussin Cc: Gleb Popov , Jan Beich , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6a5b2121a0ad - main - graphics/libimagequant: update to 4.0.4 Message-ID: References: <202211021359.2A2DxrBH094375@gitrepo.freebsd.org> <20221123124550.uxesmrgrd6ewbx2r@aniel.nours.eu> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221123124550.uxesmrgrd6ewbx2r@aniel.nours.eu> X-ThisMailContainsUnwantedMimeParts: N On Wed, Nov 23, 2022 at 01:45:50PM +0100, Baptiste Daroussin wrote: > On Fri, Nov 04, 2022 at 03:33:28PM +0300, Gleb Popov wrote: > > On Fri, Nov 4, 2022 at 3:20 PM Alexey Dokuchaev wrote: > > > Not everyone is using binary packages, and there's always a trade-off to > > > make. For many of us Rust is a big "no", and if LIQ is not particularly > > > useful for a typical user, there is little reason to have it enabled by > > > default, given the price. Defaults should be sane. > > > > Can't agree with you on that. Defaults should be sane for users, not > > developers. Most users use binary packages and do not compile stuff > > themselves, so we should prefer defaults convenient for them. > > 1000% agree, here, there is no issue with providing option to ease people > building in place Yes there is. People type "make" and the rabbit hole just gets deeper. Having an option is good, but it should be on or off by default based on how useful it is and what it entails. Even with build dependencies, we used to take special care and e.g. not to pull full LaTeX suite by default because of its ridiculously huge (>3GB) distfile. At the very least, do not let it leak into common path like documentation building as it would affect many ports and users. > Other users can by design tweak the options. They can, and some do, but for many of them who's not accustomed to the framework it's actually quite hard (it sounds funny for seasoned porter, but we're talking about *users* here, remember?). They try to install some innocent port and stumble at why it's downloading Rust now (or worse, they've wasted several hours building it only to find out that there is not enough RAM in their laptop so the build fails). > but the default should be sane for binary packages users. Do you even know how useful LIQ option in `graphics/gd' is? Mind you, it was introduced* in 2022 only to prevent unregistered dependency, not because someone had *asked* for it. It was okay to have it enabled by default when it was written in C, but now it's in Rust and this causes lots of pain and grief. While I generally sympathize with featureful packages by default idea, this is the case when non-essential, minor, recently added feature of popular library widely used since the end of the last century which now comes with big needless burden. So how about this: we disable IMAGEQUANT (LIQ) in `graphics/py-pillow' and `graphics/gd' and see how many people complain and how many would say big "thank you"? ./danfe *) https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263185