Re: git: ecf09fe34600 - main - graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64
Date: Wed, 04 May 2022 15:31:30 UTC
On Wed, 4 May 2022 17:30:13 +0200 Piotr Kubaj <pkubaj@anongoth.pl> wrote: > On 22-05-04 17:16:04, Baptiste Daroussin wrote: > > On Wed, May 04, 2022 at 04:32:59PM +0200, Piotr Kubaj wrote: > > > On 22-05-04 15:22:00, Emmanuel Vadot wrote: > > > > On Wed, 4 May 2022 12:57:26 GMT > > > > Piotr Kubaj <pkubaj@FreeBSD.org> wrote: > > > > > > > > > The branch main has been updated by pkubaj: > > > > > > > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=ecf09fe3460067b442ba41a6adb85897c99442b5 > > > > > > > > > > commit ecf09fe3460067b442ba41a6adb85897c99442b5 > > > > > Author: Piotr Kubaj <pkubaj@FreeBSD.org> > > > > > AuthorDate: 2022-05-04 12:54:19 +0000 > > > > > Commit: Piotr Kubaj <pkubaj@FreeBSD.org> > > > > > CommitDate: 2022-05-04 12:54:19 +0000 > > > > > > > > > > graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64 > > > > > > > > > > amdgpu has known endianness issues and doesn't work on powerpc64. > > > > > radeonkms works, while amdgpu works on powerpc64le. > > > > > --- > > > > > graphics/gpu-firmware-amd-kmod/Makefile | 4 +- > > > > > graphics/gpu-firmware-kmod/Makefile | 67 +++++++++++++++++---------------- > > > > > 2 files changed, 37 insertions(+), 34 deletions(-) > > > > > > > > > > > > > Can you respect MAINTAINER and open a review next time ? > > > > > > I believe this falls under tier 2 blanket. Correct me if I'm mistaken. > > > > It somehow is and somehow isn't, basically the blanket for tier 2 is to commit > > trivial changes which allows a port to work (or be flagged as not working on a > > given architecture) exactly the same as the "just fix it blanket". > > > > Intrusive changes should anyway be discussed with the maintainer, and yes it is > > almost impossible to document what is intrusive from what is not, we have to > > rely on common sense here, and if one has a doubt, it is cheap to send a mail, > > open a PR, open a review to the maintainer anyway. > > > > The change here does not "fix" anything, so in my opinion, seeking for review > > and opening a discussion with the maintainer would have been a good idea. > > > > As for whether your change is a good idea or not, I will let you discuss that > > with the maintainer. > > > > Best regards, > > Bapt > > OK, then if you want me to revert that commit, I can do it. No need for revert. > Just note that graphics/gpu-firmware-kmod/Makefile already contained > architecture conditional for intel. And sending a mail/PR/review wouldn't have cost you a lot for this patch, I just ask that you do that next time. Cheers, -- Emmanuel Vadot <manu@bidouilliste.com> <manu@FreeBSD.org>