Re: git: ecf09fe34600 - main - graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64
Date: Wed, 04 May 2022 14:32:59 UTC
On 22-05-04 15:22:00, Emmanuel Vadot wrote: > On Wed, 4 May 2022 12:57:26 GMT > Piotr Kubaj <pkubaj@FreeBSD.org> wrote: > > > The branch main has been updated by pkubaj: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=ecf09fe3460067b442ba41a6adb85897c99442b5 > > > > commit ecf09fe3460067b442ba41a6adb85897c99442b5 > > Author: Piotr Kubaj <pkubaj@FreeBSD.org> > > AuthorDate: 2022-05-04 12:54:19 +0000 > > Commit: Piotr Kubaj <pkubaj@FreeBSD.org> > > CommitDate: 2022-05-04 12:54:19 +0000 > > > > graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64 > > > > amdgpu has known endianness issues and doesn't work on powerpc64. > > radeonkms works, while amdgpu works on powerpc64le. > > --- > > graphics/gpu-firmware-amd-kmod/Makefile | 4 +- > > graphics/gpu-firmware-kmod/Makefile | 67 +++++++++++++++++---------------- > > 2 files changed, 37 insertions(+), 34 deletions(-) > > > > Can you respect MAINTAINER and open a review next time ? I believe this falls under tier 2 blanket. Correct me if I'm mistaken. > Also why doing that at all ? Because if someone wants to work on > amdgpu on powerpc64 they now need to revert your commit to have the > firmware build. I really don't see a point of doing that. To avoid giving a false impression that this is supported. If anyone works on it, they'll probably use Linux, which has the same issue but you can use upstream DRM code on it. But with big-endian usage fading, and modern POWER supporting little-endian mode, I doubt it will happen, especially considering the size of amdgpu drivers. > > -- > Emmanuel Vadot <manu@bidouilliste.com> <manu@FreeBSD.org>