From nobody Tue May 03 16:53:23 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2703A1ABF594; Tue, 3 May 2022 16:53:28 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kt5d40Zrhz4rLV; Tue, 3 May 2022 16:53:28 +0000 (UTC) (envelope-from jbeich@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651596808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=S5PV5KR7gyKNDK1MLLX5qAcz4bN0QgJRYoyhoMMG82k=; b=wGQ+toKOEKkNHSk8Mjyoh3YoPkx/8zSkTY92TopSVZ1VHcks8hVjt6u/iQMO/Q3FGfVznO Ewm6uIPPAxdPIhtuC0eq7JeeErzseQN4GsnS3g1EBjIkp8aYivLIA8EIck5rjuix/PUU9k CCwnt0eKKoyH1HpHVgbpbJA9EFVAXqzTpunWx3Y8tpzk9bEe1nt95LytJtLByoZwjGpk1z gHwd+QlISiqaxJtRkvnIB3+8fPYVBdL4VkjlmMhVPkef+H7GNodDdIHUxe8pM5/cp8Lw8a WJkJ86KHdfugTNBqt7BjAZqV/KLpEHVU5QBKf84SMKLJST4KNHRHcPTZL5Yb2w== Received: by freefall.freebsd.org (Postfix, from userid 1354) id E842E46B8; Tue, 3 May 2022 16:53:27 +0000 (UTC) From: Jan Beich To: Emmanuel Vadot Cc: Christoph Moench-Tegeder , Joseph Mingrone , Craig Leres , Christoph Moench-Tegeder , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 980444a82fbd - main - www/firefox: update to 100.0 (rc2) References: <202204291458.23TEwiL4068411@gitrepo.freebsd.org> <58e45f7c-b79f-9f14-4df5-00617fee9ea4@freebsd.org> <05c2a241-5d32-24d9-c223-66aa9ca99b75@freebsd.org> <76d4fb65-b1df-2941-cc06-5ab23607a233@freebsd.org> <20220503094616.ad8309626972ab0c7d6c1cd9@bidouilliste.com> <4k26-hkiv-wny@FreeBSD.org> <86y1ziab1f.fsf@phe.ftfl.ca> <20220503175240.89a47079840b06ce1a6cc22a@bidouilliste.com> Date: Tue, 03 May 2022 18:53:23 +0200 Message-ID: List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651596808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=S5PV5KR7gyKNDK1MLLX5qAcz4bN0QgJRYoyhoMMG82k=; b=CHrZV3BqAxGaAgWg1dQ0ZhgxocaJQoJVmGyqOliQT9yrRHllrwt+/JkSi2hoDIyejMmIwV G8wMG+7+JhLsu8eWAhKkZhxDrEoiEv9mYfU8GheKvlB+cBqWp7c/tcM6UnLibc7160LPQZ AQ9s1SQ6DrMG6trzC6/79TxKvH/uWpgakv6nbdf9Nj18kPKd5UzCsEBO+H+14odBSY+XEp nlNT3ZL6RPEgzrU786hW3MCcozK9AH1LGHF1rnXAov6S5FJktm6GcCYP7a7u6XEn5dlJtD bjxD3bpr5qkjoWkUCeZAG9tps2HNkF6aAmmURL/Folu/QT5z9y4VmgjKaw56IA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651596808; a=rsa-sha256; cv=none; b=bUEJaMZ5biBOrK7Oh/s0ZY3W6xSmZcB/mRD+m3j6AD4ozN5paKXXOjTo64MxDEnw60Dc5v 1HygecsIQlABjGWjiLdzoUvPYGx/5qebFGlU89Mm9/Yfjbrb90RnxMdXUR505srQJdRGk4 UiItICVA/HKuT0DoDYq00fSnjEylainVdhyj8Ohx7CPdRMtZyK6hg6We45wZ1cbBFIOVKE KWdzdw++oUkDVciY69T5A69WS9yCj4CLeTwkww098zdd4MOezsDASFSTn52NbqQG783kn4 PHRbdaTT67bci/gzLqm0IJwr7IvtsBXMGGgEUn+mYOBwHcbGe7G7tXVtgsq4fA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Emmanuel Vadot writes: > On Tue, 3 May 2022 17:45:14 +0200 > Christoph Moench-Tegeder wrote: > >> ## Joseph Mingrone (jrm@FreeBSD.org): >> >> > Turning LTO off fixed the problem here. >> >> I just found out that turning LTO on breaks firefox for me, so that >> settles that. I'll push that soon. > > That's good for now thanks but what about the futur ? > Should we allow to have LTO turn on on port that uses both LLVM and > Rust ? Because otherwise it will happen again when a new rust version > if released and the llvm version isn't the same. - Known since https://cgit.freebsd.org/ports/commit/?id=b1c90afe23f9 - Adhered previously in https://cgit.freebsd.org/ports/commit/?id=124261fa7deb - Complicated by wasi-compiler-rt* split from llvm* packages Mozilla recommends its own Firefox builds due to LTO + PGO. FreeBSD is a Tier3 (aka "patches welcome" and no CI), so disabling LTO will reduce performance with no fallback binaries. Rebuilding Firefox locally isn't a good proposition due to long build time (more with LTO), high memory requirement (more with LTO), frequent updates to firefox and many of its dependencies (harfbuzz, nss, ffmpeg, etc). I've enabled LTO by default a year ago to prevent dilapidation. Back then when LTO was exposed there were numerious bug reports about broken build.