From nobody Tue Mar 29 13:38:38 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 766721A3B373 for ; Tue, 29 Mar 2022 13:39:15 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KSVz72r7dz3F9T for ; Tue, 29 Mar 2022 13:39:15 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648561155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tZ7o+cPiS8kkWztSEHNxwto4NdK5awloRbnN+iySJ4w=; b=oP3AWtGb03bJin2V2gJeci+UnFHUCJJBOUPeu/jawn3BNPSe10Xnmh33QHJiTjw66bbV+2 lZBvSDVJTv9WrXsH2J72dyGrK8DdqGAKmTpwMa/Rl4o1yU9rRvo9RtpPUHNEtyoRlfjguF 65YNSCREMsAjzm+zDZTb+jTAh1MjgjACvEoQSuzdw36KCAX/XrsvwBPoe0QLeqipsitHjy 6x9sb86p0zhHoCPYWowsoflz3F9TUH2+Hj9tw+aLXs8mwZikj2pd0OPYpryhZ5RXhkfSt7 49fcIHe4M1FCbu+Ek9EQTO1cNyQjzEtTW4XxKJkDL7maKWDdZgonQ1bqIVJ+ng== Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 3352D315BD for ; Tue, 29 Mar 2022 13:39:15 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-vs1-f45.google.com with SMTP id i186so19162531vsc.9 for ; Tue, 29 Mar 2022 06:39:15 -0700 (PDT) X-Gm-Message-State: AOAM5308KZvEx7PV7StVd6fSkIeLn8l5s5KyzxNKCE2G+1GCUJ1/cpY2 0Moo89A2yoPVKpQsIyZG5x9ORSyA1iCV1Yft0W+KpA== X-Google-Smtp-Source: ABdhPJwzQz13hgQJO2HUKMMMkB1gMXXTnEwW8MiPVTb2MdRIeCO32osW/pOq8cdThHUc793ESWafg439rVZma2vhoIo= X-Received: by 2002:a05:6102:390a:b0:325:9ee9:3635 with SMTP id e10-20020a056102390a00b003259ee93635mr8516822vsu.72.1648561154574; Tue, 29 Mar 2022 06:39:14 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202203291244.22TCiupK014470@gitrepo.freebsd.org> In-Reply-To: <202203291244.22TCiupK014470@gitrepo.freebsd.org> From: Po-Chuan Hsieh Date: Tue, 29 Mar 2022 21:38:38 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: b71f7e3faa71 - main - graphics/gdal: switch to C++17 for upcoming poppler To: Adriaan de Groot Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000000269e905db5b8ea9" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648561155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tZ7o+cPiS8kkWztSEHNxwto4NdK5awloRbnN+iySJ4w=; b=wt0/naODabJ4pHxqPuwtTw5KlJXiejQTZ17K8gELt86dyxdPu9Vmov8tLZqO9jBVWL2sMx 9ZRCMX8yAk6/B8jkewGzrl7KVUKZOmLz0je4hszzje0U23EC4mBmsPRPSmK8PV7soQdE2Y jeLDomujtPCbP92FJuDB4ibH3Jz4GSCwbmcd3e5fQsJYVjMsqyn2hLpTDimfnVmkmVmBS7 iLvrPFt5EuW6VHzX47ch1CZd/kjxlj21ADJD3gFfAmUZaDWp1q48gM0Dm6Yc7F0p7ZcHdH LuIR6UtHKog0U3+AenSLeOROmjw8jN5aAyQSKpYWajGvIEqSota2RJQNWrKeZA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1648561155; a=rsa-sha256; cv=none; b=BlXjA/wQFaHazgq5x3tmRfgFINu1c0lOO2UhjNtUkYd+c8rcT/0CRhpfttA562J2ZIXtl7 e/RDCknGEeVuYxcDgMFtIRMglbKoMDDRXL5W2U3vqTBIExN0qTdRidQ7Kjr3Zvl/R4qR9n wNreIxLK88mYMOCaoIXd2oWmTYGK+vky5qSpq9ZhyXwKdm/AxBorYjChNaKRqO7tN0yCde Xgeg5T/wQym/JvN3dHbSZsl/XlZp+Plapmz/KdADP9mzaHEKF8jdUwE64LZpeDhvFJ0uFZ ThYbtSPqcskmg+wT0Q149RXds9Qm7rHmNusH/sFlsOxzZbiGB+nAwDNgihVwBA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --0000000000000269e905db5b8ea9 Content-Type: text/plain; charset="UTF-8" On Tue, Mar 29, 2022 at 8:45 PM Adriaan de Groot wrote: > The branch main has been updated by adridg: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=b71f7e3faa7181387717df55cfd009db723b3d71 > > commit b71f7e3faa7181387717df55cfd009db723b3d71 > Author: Adriaan de Groot > AuthorDate: 2022-03-28 19:20:06 +0000 > Commit: Adriaan de Groot > CommitDate: 2022-03-29 12:44:53 +0000 > > graphics/gdal: switch to C++17 for upcoming poppler > > This is a fix-it-before-it-breaks for a poppler update that requires > consumers (like gdal) to compile in C++17 mode. > > PR: 260956 > --- > graphics/gdal/Makefile | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/graphics/gdal/Makefile b/graphics/gdal/Makefile > index 5cd9500a265b..9d874f096276 100644 > --- a/graphics/gdal/Makefile > +++ b/graphics/gdal/Makefile > @@ -2,7 +2,7 @@ > > PORTNAME= gdal > PORTVERSION= 3.4.1 > -PORTREVISION= 8 > +PORTREVISION= 9 > CATEGORIES= graphics geography > MASTER_SITES= https://download.osgeo.org/gdal/${PORTVERSION}/ \ > LOCAL/sunpoet > @@ -42,12 +42,12 @@ PCRE2_DESC= Regular expression support for SQLite > RASTERLITE2_DESC= RasterLite2 support > TILEDB_DESC= TileDB support > > -USES= compiler:c++14-lang cpe gmake iconv jpeg localbase > pkgconfig ssl tar:xz > +USES= compiler:c++17-lang cpe gmake iconv jpeg localbase > pkgconfig ssl tar:xz > > CFLAGS+= -fPIC > CONFIGURE_ARGS= --datadir=${PREFIX}/share \ > --enable-static=yes \ > - --with-cpp14 \ > + --with-cpp17 \ > Please revert this. There is no such argument (--with-cpp17). Thanks. > --with-crypto=yes \ > --with-geotiff=yes \ > --with-gif=yes \ > @@ -69,7 +69,7 @@ CONFIGURE_ARGS= --datadir=${PREFIX}/share \ > GNU_CONFIGURE= yes > LDFLAGS+= ${ICONV_LIB} > MAKEFILE= GNUmakefile > -USE_CXXSTD= c++14 > +USE_CXXSTD= c++17 > USE_LDCONFIG= yes > > PLIST_SUB= PORTVERSION=${PORTVERSION} > > --0000000000000269e905db5b8ea9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Mar 29, 2022 at 8:45 PM Adriaan d= e Groot <adridg@= freebsd.org> wrote:
The branch main has been updated by a= dridg:

URL: https://cgi= t.FreeBSD.org/ports/commit/?id=3Db71f7e3faa7181387717df55cfd009db723b3d71

commit b71f7e3faa7181387717df55cfd009db723b3d71
Author:=C2=A0 =C2=A0 =C2=A0Adriaan de Groot <adridg@FreeBSD.org>
AuthorDate: 2022-03-28 19:20:06 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2022-03-29 12:44:53 +0000

=C2=A0 =C2=A0 graphics/gdal: switch to C++17 for upcoming poppler

=C2=A0 =C2=A0 This is a fix-it-before-it-breaks for a poppler update that r= equires
=C2=A0 =C2=A0 consumers (like gdal) to compile in C++17 mode.

=C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0260956
---
=C2=A0graphics/gdal/Makefile | 8 ++++----
=C2=A01 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/graphics/gdal/Makefile b/graphics/gdal/Makefile
index 5cd9500a265b..9d874f096276 100644
--- a/graphics/gdal/Makefile
+++ b/graphics/gdal/Makefile
@@ -2,7 +2,7 @@

=C2=A0PORTNAME=3D=C2=A0 =C2=A0 =C2=A0 gdal
=C2=A0PORTVERSION=3D=C2=A0 =C2=A03.4.1
-PORTREVISION=3D=C2=A0 8
+PORTREVISION=3D=C2=A0 9
=C2=A0CATEGORIES=3D=C2=A0 =C2=A0 graphics geography
=C2=A0MASTER_SITES=3D=C2=A0 https://download.osge= o.org/gdal/${PORTVERSION}/ \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 LOCAL/sunpoet
@@ -42,12 +42,12 @@ PCRE2_DESC=3D Regular expression support for SQLite
=C2=A0RASTERLITE2_DESC=3D=C2=A0 =C2=A0 =C2=A0 RasterLite2 support
=C2=A0TILEDB_DESC=3D=C2=A0 =C2=A0TileDB support

-USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler:c++14-lang cpe gmake ic= onv jpeg localbase pkgconfig ssl tar:xz
+USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler:c++17-lang cpe gmake ic= onv jpeg localbase pkgconfig ssl tar:xz

=C2=A0CFLAGS+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0-fPIC
=C2=A0CONFIGURE_ARGS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 --datadir=3D${PREFIX}/sh= are \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --enable-static=3Dy= es \
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--with-cpp14 \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--with-cpp17 \
<= /blockquote>

Please revert this. There is no such argume= nt (--with-cpp17).
Thanks.
=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --with-crypto=3Dyes= \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --with-geotiff=3Dye= s \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --with-gif=3Dyes \<= br> @@ -69,7 +69,7 @@ CONFIGURE_ARGS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0--datadir=3D$= {PREFIX}/share \
=C2=A0GNU_CONFIGURE=3D yes
=C2=A0LDFLAGS+=3D=C2=A0 =C2=A0 =C2=A0 ${ICONV_LIB}
=C2=A0MAKEFILE=3D=C2=A0 =C2=A0 =C2=A0 GNUmakefile
-USE_CXXSTD=3D=C2=A0 =C2=A0 c++14
+USE_CXXSTD=3D=C2=A0 =C2=A0 c++17
=C2=A0USE_LDCONFIG=3D=C2=A0 yes

=C2=A0PLIST_SUB=3D=C2=A0 =C2=A0 =C2=A0PORTVERSION=3D${PORTVERSION}

--0000000000000269e905db5b8ea9--