Re: git: 2b7653e70047 - main - x11-fm/polo: new port had been added (+)
Date: Sat, 26 Mar 2022 13:29:49 UTC
On Sat, 2022-03-26 at 01:11, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > The branch main has been updated by danfe: > URL: https://cgit.FreeBSD.org/ports/commit/?id=2b7653e700471527065941373b7f0b9158e33fbd > commit 2b7653e700471527065941373b7f0b9158e33fbd > Author: Alexey Dokuchaev <danfe@FreeBSD.org> > AuthorDate: 2022-03-26 01:10:00 +0000 > Commit: Alexey Dokuchaev <danfe@FreeBSD.org> > CommitDate: 2022-03-26 01:10:00 +0000 > x11-fm/polo: new port had been added (+) > Advanced file manager for Unix-like systems written in Vala. Supports > multiple panes (single, dual, quad) with multiple tabs in each pane. > Supports archive creation, extraction, and browsing. Support for cloud > storage; running and managing KVM images, modifying PDF documents and > image files, booting ISO files in KVM, writing ISO files to USB drives. > WWW: https://teejee2008.github.io/polo/ <snip> Is there a good reason to install the binaries unstripped? Stripping them reduces the size by about 20% in this case. If there is a good reason, then '5.16.2. Stripping Binaries and Shared Libraries' of the Porter's Handbook, which says "Installed binaries should be stripped." should be clarified. > diff --git a/x11-fm/polo/files/patch-share_polo_files_gtk-theme_install-gtk-theme b/x11-fm/polo/files/patch-share_polo_files_gtk-theme_install-gtk-theme > new file mode 100644 > index 000000000000..a174735f961f > --- /dev/null > +++ b/x11-fm/polo/files/patch-share_polo_files_gtk-theme_install-gtk-theme > @@ -0,0 +1,17 @@ > +--- share/polo/files/gtk-theme/install-gtk-theme.orig 2018-08-12 04:41:58 UTC > ++++ share/polo/files/gtk-theme/install-gtk-theme > +@@ -1,4 +1,4 @@ > +-#!/bin/bash > ++#!/bin/sh > + > + gtk_major=$( polo-gtk3-helper --major ) > + if [ $? -ne 0 ]; then exit 1; fi > +@@ -11,7 +11,7 @@ DIR="$( cd "$( dirname "$0" )" && pwd )" > + cd $DIR > + if [ $? -ne 0 ]; then exit 1; fi > + > +-if (($gtk_minor == 14)) || (($gtk_minor == 16)) || (($gtk_minor == 18)) || (($gtk_minor == 20)) || (($gtk_minor == 22)); then > ++if [ $gtk_minor = 14 -o $gtk_minor = 16 -o $gtk_minor = 18 -o $gtk_minor = 20 -o $gtk_minor = 22 ]; then [ .. ] || [ .. ] || .. is a better choice than -o within [ .. ]. See the BUGS section of TEST(1) and https://github.com/koalaman/shellcheck/wiki/SC2166.