Re: git: 7e597115f051 - main - multimedia/tvheadend: Add dependency on libunwind

From: Dima Panov <fluffy_at_FreeBSD.org>
Date: Sun, 20 Mar 2022 14:32:44 UTC
Moin!

It will broke build for any arch which not listed in list from libunwind/Makefile:
ONLY_FOR_ARCHS= aarch64 amd64 armv6 armv7 i386 powerpc64 powerpc64le

Better way is add dependency only on supported arches:

LIB_DEPENDS+= ${LIB_DEPENDS_${ARCH}}
LIB_DEPENDS_aarch64= libunwind.so:devel/libunwind
LIB_DEPENDS_amd64= libunwind.so:devel/libunwind
LIB_DEPENDS_armv7= libunwind.so:devel/libunwind
LIB_DEPENDS_i386= libunwind.so:devel/libunwind
LIB_DEPENDS_powerpc64= libunwind.so:devel/libunwind
LIB_DEPENDS_powerpc64le= libunwind.so:devel/libunwind

--
Dima. (desktop, kde, x11, office, ports-secteam)@FreeBSD team
(fluffy@FreeBSD.org, https://t.me/dima_panov)

> On Sunday, Mar 20, 2022 at 3:27 PM, Bernhard Froehlich <decke@FreeBSD.org (mailto:decke@FreeBSD.org)> wrote:
> The branch main has been updated by decke:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=7e597115f051a56e7c9313a07ac3733d18216280
>
> commit 7e597115f051a56e7c9313a07ac3733d18216280
> Author: Bernhard Froehlich <decke@FreeBSD.org>
> AuthorDate: 2022-03-20 12:22:31 +0000
> Commit: Bernhard Froehlich <decke@FreeBSD.org>
> CommitDate: 2022-03-20 12:27:13 +0000
>
> multimedia/tvheadend: Add dependency on libunwind
>
> Up to now libunwind was silenty used from base but now on 14-current
> libunwind is not available in base anymore so it fails. I decided to
> unconditionally use libunwind from ports on all FreeBSD version for
> consistency.
> ---
> multimedia/tvheadend/Makefile | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/multimedia/tvheadend/Makefile b/multimedia/tvheadend/Makefile
> index b2faf96eefa3..98af2a01f542 100644
> --- a/multimedia/tvheadend/Makefile
> +++ b/multimedia/tvheadend/Makefile
> @@ -3,7 +3,7 @@
> PORTNAME= tvheadend
> PORTVERSION= 4.2.8
> DISTVERSIONPREFIX= v
> -PORTREVISION= 5
> +PORTREVISION= 6
> CATEGORIES= multimedia
>
> MAINTAINER= decke@FreeBSD.org
> @@ -16,7 +16,8 @@ BUILD_DEPENDS= bash:shells/bash \
> cmake:devel/cmake \
> ${LOCALBASE}/include/linux/videodev2.h:multimedia/v4l_compat
> LIB_DEPENDS= libcurl.so:ftp/curl \
> - liburiparser.so:net/uriparser
> + liburiparser.so:net/uriparser \
> + libunwind.so:devel/libunwind
> RUN_DEPENDS= dtv-scan-tables>=0:multimedia/dtv-scan-tables
>
> USES= compiler:c++11-lang gettext gmake pkgconfig python shebangfix ssl
>