Re: git: 9bdc78861688 - main - sysutils/screen: Update to 4.9.0

From: Po-Chuan Hsieh <sunpoet_at_freebsd.org>
Date: Fri, 18 Mar 2022 09:49:51 UTC
On Fri, Mar 18, 2022 at 7:44 AM Cy Schubert <cy@freebsd.org> wrote:

> The branch main has been updated by cy:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=9bdc788616889d0a2b3f9c8b8996610cdfe82be7
>
> commit 9bdc788616889d0a2b3f9c8b8996610cdfe82be7
> Author:     Cy Schubert <cy@FreeBSD.org>
> AuthorDate: 2022-03-17 17:54:50 +0000
> Commit:     Cy Schubert <cy@FreeBSD.org>
> CommitDate: 2022-03-17 23:44:10 +0000
>
>     sysutils/screen: Update to 4.9.0
>
>     Update screen to 4.9.0. From the release announcement:
>
>     New in this release:
>       * Hardstatus option for used encoding (escape string '%e')
>

Hi,

It seems the SHOWENC option is no longer needed.
And it breaks the build as follows:
===>  Building for screen-4.9.0
gmake[1]: Entering directory
'/usr/ports/works/usr/ports/sysutils/screen/work/screen-4.9.0'
CPP="cpp -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"'" srcdir=. sh
./osdef.sh
AWK=/usr/bin/awk CC="cc -O2 -pipe  -I/usr/include -DCOLORS256
-fstack-protector-strong -fno-strict-aliasing " srcdir=. sh ./comm.sh
AWK=/usr/bin/awk srcdir=. sh ./term.sh
sh ./tty.sh tty.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  putenv.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  kmapdef.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  term.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  comm.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  screen.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  ansi.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  fileio.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  mark.c
screen.c:1215:5: warning: expression result unused [-Wunused-value]
    *--av;
    ^~~~~
screen.c:2789:10: error: duplicate case value '101'
    case 'e':
         ^
screen.c:2766:7: note: previous case defined here
        case 'e':
             ^
1 warning and 1 error generated.

Regards,
sunpoet

      * Fixes:
>         - fix combining char handling that could lead to a segfault
>         - CVE-2021-26937: possible denial of service via a crafted UTF-8
>           character sequence (bug #60030)
>         - make screen exit code be 0 when checking --help
>         - session names limit is 80 symbols (bug #61534)
>         - option -X ignores specified user in multiuser env (bug #37437)
>         - a lot of reformations/fixes/cleanups (man page and source code)
>
>     For full list of changes see
>     https://git.savannah.gnu.org/cgit/screen.git/log/?h=v.4.9.0
>
>     Note that CVE-2021-26937 was fixed in the FreeBSD port in 2021.