From nobody Fri Jun 10 12:50:25 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 76D37859D08 for ; Fri, 10 Jun 2022 12:51:02 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LKLRp0p3Xz4h6L for ; Fri, 10 Jun 2022 12:51:01 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654865462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZpSsftNwQVuzj/NjQMITHFr5Ci9n4jAaukZAXcGEBuE=; b=JwjEhm4Juk+JE940BlHAbt+V8fcC+ESZJahnLGcdmPZf74wFIaB/LsHNha8KpgPsic8uLE uYFHsRsM+K3HhDSh9EQuiehh6SAI/fuIvdpTDN3LFfmbsj5gxcrV/76i2+OgloO9P8IzA2 LAPbnFNaWlwWaouQIqUUltj63eFR1LAYVLQ7sX7QOGzmCOGHURCmqkPR6gMfmadhEzJN1w 5BN0MYLtg6sKeVERBt8D8OD/KgaQHcZ19Y17Xa0gt9zDs6g+Rxyy+an0/QX72Y/qlNj8Tj Z0sJRyWhYL+kyvvTv6TVcaopZHKEE5hJEm6bHP32oeIKzARvyR0VPGMTnA3c+Q== Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id CBE212CE4A for ; Fri, 10 Jun 2022 12:51:01 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ua1-f52.google.com with SMTP id z15so9031251uad.7 for ; Fri, 10 Jun 2022 05:51:01 -0700 (PDT) X-Gm-Message-State: AOAM531w5Fv+cX4nMsM5sUVbay7oMwAWPsa/BLIBdIhDlH7Ctx3PFSvm SnjsEO8vGGE4pKeeJ4igz3xBJdDPsregMwolWnjjBA== X-Google-Smtp-Source: ABdhPJwYLuz83S2cMqCLaYO5YiANm6BGm+WcuW9l59iR46x9LXNpPy0sQ+17I37vcKf86I0r1KiBmUCuO2tJMym9EWE= X-Received: by 2002:ab0:3851:0:b0:373:7516:b1d2 with SMTP id h17-20020ab03851000000b003737516b1d2mr19442540uaw.115.1654865461279; Fri, 10 Jun 2022 05:51:01 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202206101239.25ACdhAx024843@gitrepo.freebsd.org> In-Reply-To: <202206101239.25ACdhAx024843@gitrepo.freebsd.org> From: Po-Chuan Hsieh Date: Fri, 10 Jun 2022 20:50:25 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 53aec4c8cab1 - main - databases/tarantool: Depend on a specific version of devel/msgpuck. To: Gleb Popov Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000f896cf05e11763f8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654865462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZpSsftNwQVuzj/NjQMITHFr5Ci9n4jAaukZAXcGEBuE=; b=PbHu/zJfdkeOKFJAKryNhYTqiDtstLLbI7xhP7UVL2RdDTRUlsJ9j299RAi37tuwMQp/hw 3w56GmH5Vt0NUx0UNYfzuIEwjQALCisxAdQPQXI0XIQv0EpxTVz3bwCl6e/pC0rKG7reTu 21w9/dVEFS6YPMAqRD6RwCqzpNaymeLqxLe0AQAkCYzb/cROPx6t4CciWC34dZi74/bcSH IYRh2uModxmccmY2hoEH56qB+APwFohYJggvlnyWeL6sN9/jHv9iDv0ctBzWoqn1DKNafd xBcmPbtH+8n8IvOxaBYb+e53+ji4mXJigtI/SW+60GbFj0nUzdgUfuLQOE7kMA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654865462; a=rsa-sha256; cv=none; b=ivlwAAOQOF8vvocGqeaMmJt1/LlFVNnTVcZRa0XkKwnW4l1JjYi+wiydkmMw629baxWfyy 7PtLTTFiQkmgz4sQyLKkOuQDYv8+NXsbNI59CDp9S8P9h4d1CfJuDQ7qPqRxB2M51Ej0Bh jTmwl+7NEBkGAw55OMe5M6wYyENjgo5ecUyqsQGmPR7Vvl5e+srYzzCn3lXaY7NVaI6bGr V79rZZSaSFlfnFbvBwqayUx1Hpbn5dITTKGPSkbD8M5/DHqykYCFoKfXG3DMpGjON0jgfH mnI8xsDzqMjKe3NyoK92M12UgInVXG0w0DbgomW2t/M8dp7r2o3T3AUK0Ib/Kw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --000000000000f896cf05e11763f8 Content-Type: text/plain; charset="UTF-8" Hi, On Fri, Jun 10, 2022 at 8:39 PM Gleb Popov wrote: > The branch main has been updated by arrowd: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=53aec4c8cab1306efeabf80d6841953515d3be57 > > commit 53aec4c8cab1306efeabf80d6841953515d3be57 > Author: Pavel Balaev > AuthorDate: 2022-06-10 12:38:15 +0000 > Commit: Gleb Popov > CommitDate: 2022-06-10 12:38:15 +0000 > > databases/tarantool: Depend on a specific version of devel/msgpuck. > > The last msgpuck release introduced an ABI change, but did not bump > .so version. > --- > databases/tarantool/Makefile | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/databases/tarantool/Makefile b/databases/tarantool/Makefile > index 05f808fb8ae0..d2263ad82338 100644 > --- a/databases/tarantool/Makefile > +++ b/databases/tarantool/Makefile > @@ -2,6 +2,7 @@ > > PORTNAME= tarantool > PORTVERSION= 2.10.0 > +PORTREVISION= 1 > CATEGORIES= databases > MASTER_SITES= https://download.tarantool.org/tarantool/src/ > > @@ -16,12 +17,13 @@ BROKEN_riscv64= fails to compile: > mmintrin.h:50:12: invalid conversion between > NOT_FOR_ARCHS= armv6 powerpc64 sparc64 > NOT_FOR_ARCHS_REASON= fails to build: Unsupported architecture > > -BUILD_DEPENDS= gsed:textproc/gsed > +BUILD_DEPENDS= gsed:textproc/gsed \ > + ${RUN_DEPENDS} > LIB_DEPENDS= libcurl.so:ftp/curl \ > libicui18n.so:devel/icu \ > - libmsgpuck.so:devel/msgpuck \ > libyaml.so:textproc/libyaml \ > libzstd.so:archivers/zstd > +RUN_DEPENDS= msgpuck>=2.0_4:devel/msgpuck > Thanks for adding the check but I would do it in a different way. The simplest solution is to add "msgpuck>=2.0_4:devel/msgpuck" to BUILD_DEPENDS. Besides, since tarantool link against libmsgpuck.so, it is better to use LIB_DEPENDS instead of BUILD_DEPENDS+RUN_DEPENDS. Regards, sunpoet --000000000000f896cf05e11763f8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

On Fri, Jun 10, 2022 at 8:39 PM Gleb Popov <arrowd@freebsd.org> wrote:
The branch main has be= en updated by arrowd:

URL: https://cgi= t.FreeBSD.org/ports/commit/?id=3D53aec4c8cab1306efeabf80d6841953515d3be57

commit 53aec4c8cab1306efeabf80d6841953515d3be57
Author:=C2=A0 =C2=A0 =C2=A0Pavel Balaev <balaev@tarantool.org>
AuthorDate: 2022-06-10 12:38:15 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2022-06-10 12:38:15 +0000

=C2=A0 =C2=A0 databases/tarantool: Depend on a specific version of devel/ms= gpuck.

=C2=A0 =C2=A0 The last msgpuck release introduced an ABI change, but did no= t bump .so version.
---
=C2=A0databases/tarantool/Makefile | 6 ++++--
=C2=A01 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/databases/tarantool/Makefile b/databases/tarantool/Makefile index 05f808fb8ae0..d2263ad82338 100644
--- a/databases/tarantool/Makefile
+++ b/databases/tarantool/Makefile
@@ -2,6 +2,7 @@

=C2=A0PORTNAME=3D=C2=A0 =C2=A0 =C2=A0 tarantool
=C2=A0PORTVERSION=3D=C2=A0 =C2=A02.10.0
+PORTREVISION=3D=C2=A0 1
=C2=A0CATEGORIES=3D=C2=A0 =C2=A0 databases
=C2=A0MASTER_SITES=3D=C2=A0 https://download.tarantool.= org/tarantool/src/

@@ -16,12 +17,13 @@ BROKEN_riscv64=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0fails to compile: mmintrin.h:50:12: invalid conversion between =C2=A0NOT_FOR_ARCHS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0armv6 powerpc64 spa= rc64
=C2=A0NOT_FOR_ARCHS_REASON=3D=C2=A0 fails to build: Unsupported architectur= e

-BUILD_DEPENDS=3D gsed:textproc/gsed
+BUILD_DEPENDS=3D gsed:textproc/gsed \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0${RUN_DEPENDS}
=C2=A0LIB_DEPENDS=3D=C2=A0 =C2=A0libcurl.so:ftp/curl \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 libicui18n.so:devel= /icu \
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0libmsgpuck.so:devel= /msgpuck \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 libyaml.so:textproc= /libyaml \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 libzstd.so:archiver= s/zstd
+RUN_DEPENDS=3D=C2=A0 =C2=A0msgpuck>=3D2.0_4:devel/msgpuck

Thanks for adding the check but I would do it in a d= ifferent way.
The simplest solution is to add "msgpuck>= =3D2.0_4:devel/msgpuck" to BUILD_DEPENDS.
Besides, since tar= antool link against=C2=A0libmsgpuck.so, it is better to use LIB_DEPENDS ins= tead of BUILD_DEPENDS+RUN_DEPENDS.

Regards,
sunpoet
--000000000000f896cf05e11763f8--