From nobody Thu Jun 02 13:31:44 2022
X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id F31B81B59B20;
	Thu,  2 Jun 2022 13:31:44 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4LDRkS6bsJz4f7q;
	Thu,  2 Jun 2022 13:31:44 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
	t=1654176704;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=0vFl2hjPcs+DsVlG9+k2F4I9+9yrgZZMMDKtut+Dtd4=;
	b=iRNNSn1lajjng6AmK7Et3CINECJLN9c9PgkuHEKhoX9n2wNQyk+2krfHDI5W9sihQATzKn
	mUc+Yw6iqmNGquUe3aJVXYn3f1K/zac1lshxnVtwo78vkydhsO2UK00HGjLitosZQtlNWm
	D+59NpFYofmK2WF5xWZ9ftlPLNM/7GDwXIi6njrGV8ri2U7Lm5BuB+PTU5quan3ZPotD6b
	ztJJgNm4AC6nMwhEuOSLePSlKE/a/8RI7tCYwbTbv2QfZSzOqm3aEC59Rnxoe+9hJJD0f8
	En40/KKbScKOMWsivzfGMd2udIe8XxP7RCbkdFAOWbwhgz+rF/7DL8olGGVHyg==
Received: by freefall.freebsd.org (Postfix, from userid 1033)
	id C9FE0175E0; Thu,  2 Jun 2022 13:31:44 +0000 (UTC)
Date: Thu, 2 Jun 2022 13:31:44 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Ganael LAPLANCHE <martymac@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,
	dev-commits-ports-main@freebsd.org
Subject: Re: git: 7ca4bf132765 - main - devel/ncurses: Do not strip libraries
 when DEBUG option is set
Message-ID: <Ypi7wHWf2LphTK22@FreeBSD.org>
References: <202206021021.252ALr89052824@gitrepo.freebsd.org>
List-Id: Commits to the main branch of the FreeBSD ports repository <dev-commits-ports-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main
List-Help: <mailto:dev-commits-ports-main+help@freebsd.org>
List-Post: <mailto:dev-commits-ports-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-ports-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-ports-main+unsubscribe@freebsd.org>
Sender: owner-dev-commits-ports-main@freebsd.org
X-BeenThere: dev-commits-ports-main@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202206021021.252ALr89052824@gitrepo.freebsd.org>
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
	s=dkim; t=1654176704;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=0vFl2hjPcs+DsVlG9+k2F4I9+9yrgZZMMDKtut+Dtd4=;
	b=GPMKWab0AQnyIGIv4wptqw+oSnZItI6+sYRwpyfn68YAauK9I4Lc0oR3MZZsc67sTZNDhx
	Yz9QdVlmonRBd/yTwOljyEBNRes8tiXb+7ropV3vFGAYgcAIH72Hx4ewrWrWj0lcyXwj0A
	Ir4qo1UNnrinOu3VMTKXARV1kGyYGTn6yE6uuEV3JxLFpdZi0vyKCjVam2shdN9NDLto8H
	ZDeDFUp40h0jfIt/naT92DkqSDMPZkQ/y7i8m54rs1MnA6Jcikgp0Py1o4DbqKmpcznU3v
	3GHE5jUNXvReV04q11Bg08WBZDh2l1alGJQ7F7BDnfi01oZ6PUDpw2NRMWRPJw==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654176704; a=rsa-sha256; cv=none;
	b=Q2dBeyPM0uocAKDN0zRN4xTd8e9TKAUoCkF6cz6efPNvA5pHuw6+vqGqCvxzTaBYSqA4qv
	KqUxt/fLt/LCNp7dGGwPEfqokTUpGx+42DpzM7H1OYO6/wiYaJDJmgvO/EtUUN+Hd41BGO
	xbthoatFH9VWUQuPalUYhsv8i5//c/706dGIqnSKKB3B+gJpSaI5GUDdNKtF4kSD5u1U16
	Ho3PYKsKNb1C5gTV5AhduuwRvKW52aMDP1BwpHmpnzc04iKaJ0jY3uag00TQVdMl+NN1iZ
	0peiF57WjBqnhLcskPdawU1gWE7KAR+Z7zp8IPHX+uXuaONJ9ZtwCbUWvb2Oug==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
X-ThisMailContainsUnwantedMimeParts: N

On Thu, Jun 02, 2022 at 10:21:53AM +0000, Ganael LAPLANCHE wrote:
> commit 7ca4bf13276577544841a58c208e9b3fd7230b9a
> 
>   devel/ncurses: Do not strip libraries when DEBUG option is set
>     
> @@ -95,7 +95,9 @@ post-install:
>  	${RM} ${STAGEDIR}${PREFIX}/lib/libncurses.so
>  	${ECHO} "INPUT(libncurses.so.${PORTVERSION:R} AS_NEEDED(-ltinfo))" > ${STAGEDIR}${PREFIX}/lib/libncurses.so
>  
> +.if ! ${PORT_OPTIONS:MDEBUG}
>  	${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/*.so.${DISTVERSION}
> +.endif

Correct fix is to drop the DEBUG option and wrap --with-debug with
.if defined(WITH_DEBUG).  ${STRIP_CMD} respects WITH_DEBUG by itself
via Mk/b.p.m.  See `mail/mailutils' as an example.

./danfe